There seems to be something strange with these files in WebRTC:
https://chromium.googlesource.com/external/webrtc/+/master/webrtc/video/receive_statistics_proxy.h
https://chromium.googlesource.com/external/webrtc/+/master/webrtc/video/receive_statistics_proxy.cc
https://chromium.googlesource.com/external/webrtc/+/master/webrtc/video/receive_statistics_proxy_unittest.cc
Patching always fails for these files for some of our bots (but not all), even if the patch is up to date. The error looks like this:
Connecting to https://codereview.webrtc.org
Downloading patch from https://codereview.webrtc.org/2577073002/#ps110001
webrtc/video/receive_statistics_proxy.cc
webrtc/video/receive_statistics_proxy.h
webrtc/video/receive_statistics_proxy_unittest.cc
Applying the patch from https://codereview.webrtc.org/2577073002/#ps110001
Failed to apply patch for webrtc/video/receive_statistics_proxy.cc:
While running git apply --index -3 -p1 --verbose;
Checking patch webrtc/video/receive_statistics_proxy.cc...
error: webrtc/video/receive_statistics_proxy.cc: does not exist in index
There are plenty of examples in https://codereview.webrtc.org/2577073002
It seems the "*_baremetal" bots are always failing, while others mostly work (but not all).
I logged in to one of the machines and the checkout turned out to be in a bad state:
130] chrome-bot@build144-b4:(Linux 14.04):/b/c/b/linux_baremetal/src/webrtc/video$ git status
HEAD detached at origin/master
Changes to be committed:
(use "git reset HEAD <file>..." to unstage)
modified: ../../DEPS
Unmerged paths:
(use "git reset HEAD <file>..." to unstage)
(use "git rm <file>..." to mark resolution)
both deleted: quality_threshold.cc
both deleted: quality_threshold.h
both deleted: receive_statistics_proxy.cc
both deleted: receive_statistics_proxy.h
both deleted: receive_statistics_proxy_unittest.cc
Doing a git reset --hard reset the checkout.
I wonder how the src/ dir could end up like that and that bot_update no longer resolves it?
Looking in the bot_update log, it only does these commands:
===Running git remote set-url origin /b/c/git_cache/chromium.googlesource.com-external-webrtc (attempt #1)===
In directory: /b/c/b/linux_baremetal/src
===Succeeded in 0.0 mins===
===Running git fetch origin (attempt #1)===
In directory: /b/c/b/linux_baremetal/src
===Succeeded in 0.0 mins===
===Running git checkout --force origin/master (attempt #1)===
In directory: /b/c/b/linux_baremetal/src
HEAD is now at c3a2b7f48... RTCIceCandidateStats.isRemote added and collected.
===Succeeded in 0.1 mins===
===Running git clean -dff (attempt #1)===
In directory: /b/c/b/linux_baremetal/src
===Succeeded in 0.0 mins===
===Running git log --format=%H --max-count=1 (attempt #1)===
In directory: /b/c/b/linux_baremetal/src
c3a2b7f4877b09357ab453f698451bdb75c7bc1c
===Succeeded in 0.0 mins===
Comment 1 by kjellander@chromium.org
, Jan 2 2017