New issue
Advanced search Search tips

Issue 677819 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe is flaky

Project Member Reported by engedy@chromium.org, Jan 2 2017

Issue description

Investigation revealed that ui_test_utils::NavigateToURL() is returning too early (before the navigation is actually finished) because of a spurious DidStopLoading call that belongs to the previous navigation.

Disabling the test for now.
 
[ RUN      ] SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe
Xlib:  extension "RANDR" missing on display ":99".
Xlib:  extension "RANDR" missing on display ":99".
[28454:28454:0101/004117.839181:WARNING:audio_manager.cc(317)] Multiple instances of AudioManager detected
[28454:28454:0101/004117.839224:WARNING:audio_manager.cc(278)] Multiple instances of AudioManager detected
[28454:28454:0101/004117.870674:WARNING:password_store_factory.cc(248)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[28454:28526:0101/004120.155647:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /non-existent.html
../../chrome/browser/subresource_filter/subresource_filter_browsertest.cc:271: Failure
Value of: frame
  Actual: false
Expected: true
Google Test trace:
../../chrome/browser/subresource_filter/subresource_filter_browsertest.cc:269: one
../../chrome/browser/subresource_filter/subresource_filter_browsertest.cc:448: http://127.0.0.1:38154/non-existent.html
../../chrome/browser/subresource_filter/subresource_filter_browsertest.cc:453: Failure
Expected: ExpectParsedScriptElementLoadedStatusInFrames( kSubframeNames, kExpectScriptInFrameToLoad) doesn't generate new fatal failures in the current thread.
  Actual: it does.
Google Test trace:
../../chrome/browser/subresource_filter/subresource_filter_browsertest.cc:448: http://127.0.0.1:38154/non-existent.html
[  FAILED  ] SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe, where TypeParam =  and GetParam() =  (2525 ms)

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe&testType=browser_tests
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47af625a9035c464bd59bfc935f83890138ed0be

commit 47af625a9035c464bd59bfc935f83890138ed0be
Author: engedy <engedy@chromium.org>
Date: Mon Jan 02 16:23:55 2017

Disable SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe.

The test is flaky on all platforms.

TBR=melandory@chromium.org
BUG= 677819 

Review-Url: https://codereview.chromium.org/2608153002
Cr-Commit-Position: refs/heads/master@{#441071}

[modify] https://crrev.com/47af625a9035c464bd59bfc935f83890138ed0be/chrome/browser/subresource_filter/subresource_filter_browsertest.cc

Status: Started (was: Untriaged)
Looking into the root cause.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fb9af565efc05fe461fb27117a5419a6f04de69

commit 5fb9af565efc05fe461fb27117a5419a6f04de69
Author: engedy <engedy@chromium.org>
Date: Tue Jan 03 14:14:45 2017

Fix race in SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe.

Ensure server-supplied content for the 404 error page. This prevents showing
Chrome's built in error page, which would trigger a background request to
load navigation corrections (aka. Link Doctor), and once the results are back,
would make a navigation to a second error page containing the suggestions,
which, unfortunately, makes WaitForLoadStop() in NavigateToURL() racey.

BUG= 677819 

Review-Url: https://codereview.chromium.org/2609163003
Cr-Commit-Position: refs/heads/master@{#441116}

[modify] https://crrev.com/5fb9af565efc05fe461fb27117a5419a6f04de69/chrome/browser/subresource_filter/subresource_filter_browsertest.cc

Status: Fixed (was: Started)

Sign in to add a comment