SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe is flaky |
|||
Issue descriptionInvestigation revealed that ui_test_utils::NavigateToURL() is returning too early (before the navigation is actually finished) because of a spurious DidStopLoading call that belongs to the previous navigation. Disabling the test for now.
,
Jan 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47af625a9035c464bd59bfc935f83890138ed0be commit 47af625a9035c464bd59bfc935f83890138ed0be Author: engedy <engedy@chromium.org> Date: Mon Jan 02 16:23:55 2017 Disable SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe. The test is flaky on all platforms. TBR=melandory@chromium.org BUG= 677819 Review-Url: https://codereview.chromium.org/2608153002 Cr-Commit-Position: refs/heads/master@{#441071} [modify] https://crrev.com/47af625a9035c464bd59bfc935f83890138ed0be/chrome/browser/subresource_filter/subresource_filter_browsertest.cc
,
Jan 2 2017
Looking into the root cause.
,
Jan 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5fb9af565efc05fe461fb27117a5419a6f04de69 commit 5fb9af565efc05fe461fb27117a5419a6f04de69 Author: engedy <engedy@chromium.org> Date: Tue Jan 03 14:14:45 2017 Fix race in SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe. Ensure server-supplied content for the 404 error page. This prevents showing Chrome's built in error page, which would trigger a background request to load navigation corrections (aka. Link Doctor), and once the results are back, would make a navigation to a second error page containing the suggestions, which, unfortunately, makes WaitForLoadStop() in NavigateToURL() racey. BUG= 677819 Review-Url: https://codereview.chromium.org/2609163003 Cr-Commit-Position: refs/heads/master@{#441116} [modify] https://crrev.com/5fb9af565efc05fe461fb27117a5419a6f04de69/chrome/browser/subresource_filter/subresource_filter_browsertest.cc
,
Jan 3 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by engedy@chromium.org
, Jan 2 2017