New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 677781 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature

Blocking:
issue 646841



Sign in to add a comment

In ClickBasedCategoryRanker listen to section dismissal.

Project Member Reported by vitaliii@chromium.org, Jan 2 2017

Issue description

Currently ClickBasedCategoryRanker does not know anything about section dismissal, however, this may be a good signal that the category must be moved down.
 
Blockedon: -646841
Blocking: 646841
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d9423e34805ed9a6046d44e6ce144a39b16f603

commit 3d9423e34805ed9a6046d44e6ce144a39b16f603
Author: vitaliii <vitaliii@chromium.org>
Date: Tue Jan 03 17:08:13 2017

[NTP::SectionOrder] Make ClickBasedRanker move dismissed sections down.

Move dissmised sections 2 positions down in ClickBasedRanker. Dismissing a
section is a strong negative signal, thus, category rankers can react to it.

BUG= 677781 

Review-Url: https://codereview.chromium.org/2610553002
Cr-Commit-Position: refs/heads/master@{#441140}

[modify] https://crrev.com/3d9423e34805ed9a6046d44e6ce144a39b16f603/components/ntp_snippets/category_rankers/category_ranker.h
[modify] https://crrev.com/3d9423e34805ed9a6046d44e6ce144a39b16f603/components/ntp_snippets/category_rankers/click_based_category_ranker.cc
[modify] https://crrev.com/3d9423e34805ed9a6046d44e6ce144a39b16f603/components/ntp_snippets/category_rankers/click_based_category_ranker.h
[modify] https://crrev.com/3d9423e34805ed9a6046d44e6ce144a39b16f603/components/ntp_snippets/category_rankers/click_based_category_ranker_unittest.cc
[modify] https://crrev.com/3d9423e34805ed9a6046d44e6ce144a39b16f603/components/ntp_snippets/category_rankers/constant_category_ranker.cc
[modify] https://crrev.com/3d9423e34805ed9a6046d44e6ce144a39b16f603/components/ntp_snippets/category_rankers/constant_category_ranker.h
[modify] https://crrev.com/3d9423e34805ed9a6046d44e6ce144a39b16f603/components/ntp_snippets/category_rankers/fake_category_ranker.cc
[modify] https://crrev.com/3d9423e34805ed9a6046d44e6ce144a39b16f603/components/ntp_snippets/category_rankers/fake_category_ranker.h
[modify] https://crrev.com/3d9423e34805ed9a6046d44e6ce144a39b16f603/components/ntp_snippets/category_rankers/mock_category_ranker.h
[modify] https://crrev.com/3d9423e34805ed9a6046d44e6ce144a39b16f603/components/ntp_snippets/content_suggestions_service.cc
[modify] https://crrev.com/3d9423e34805ed9a6046d44e6ce144a39b16f603/components/ntp_snippets/content_suggestions_service_unittest.cc

Status: Fixed (was: Started)
In the end, it is "1 position down" and not "2 positions down".

Sign in to add a comment