App crashes on continuously tapping 3 to 4 times on “Cancel” and “Delete Read” in Reading list screen. |
||||
Issue descriptionApp Version: 57.0.2967.0 Canary iOS Version: 9.3.5, iOS 10 Device: iPhone,iPad PreCondition : 1. Enable Reading List from Device experimental settings 2. Have few links in Reading list and few links in Read Mode. Steps to reproduce: 1. Launch chrome. 2. Tap on Menu > Reading list. 3. Tap on EDIT. 4. Quickly tap on “Cancel” and “Delete Read” simultaneously 3 to 4 times. Observed results: App Crashes Expected results: App should not crash. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Dolphin/Safari/Firefox: NA Bug reproducible on current stable build (App Version, iOS Version): No,New feature. Bug reproducible on the current beta channel build (App Version, iOS Version): No,New feature Link to Video : https://drive.google.com/a/google.com/file/d/0B--UpU2GW2EpcHgwNFhsVHp4ZG8/view?usp=sharing Crash log : https://crash.corp.google.com/browse?stbtiq=3b2aa66080000000 Stack Trace : Stack Quality81%Show frame trust levels 0x000000018859a1c0 (CoreFoundation + 0x0012f1c0 ) __exceptionPreprocess 0x0000000186fd4558 (libobjc.A.dylib + 0x00008558 ) objc_exception_throw 0x000000018859a104 (CoreFoundation + 0x0012f104 ) +[NSException raise:format:] 0x0000000188f8b8dc (Foundation + 0x000128dc ) -[NSIndexSet initWithIndexesInRange:] 0x0000000188fe9634 (Foundation + 0x00070634 ) +[NSIndexSet indexSetWithIndex:] 0x000000010029dfe0 (Chrome -reading_list_view_controller.mm:741 ) __47-[ReadingListViewController deleteAllReadItems]_block_invoke.305 0x000000018ecf4ea4 (UIKit + 0x0090fea4 ) -[UICollectionView _performBatchUpdates:completion:invalidationContext:tentativelyForReordering:animator:] 0x000000018ecf4d70 (UIKit + 0x0090fd70 ) -[UICollectionView _performBatchUpdates:completion:invalidationContext:tentativelyForReordering:] 0x000000018ecf4cf4 (UIKit + 0x0090fcf4 ) -[UICollectionView _performBatchUpdates:completion:invalidationContext:] 0x000000018e5cf1bc (UIKit + 0x001ea1bc ) -[UICollectionView performBatchUpdates:completion:] 0x000000010029de5c (Chrome -reading_list_view_controller.mm:737 ) -[ReadingListViewController deleteAllReadItems] 0x0000000100299f10 (Chrome -reading_list_toolbar.mm:209 ) -[ReadingListToolbar deleteAction] 0x000000018e42a480 (UIKit + 0x00045480 ) -[UIApplication sendAction:to:from:forEvent:] 0x000000018e42a400 (UIKit + 0x00045400 ) -[UIControl sendAction:to:forEvent:] 0x000000018e4148b4 (UIKit + 0x0002f8b4 ) -[UIControl _sendActionsForEvents:withEvent:] 0x000000018e429cec (UIKit + 0x00044cec ) -[UIControl touchesEnded:withEvent:] 0x000000018e429814 (UIKit + 0x00044814 ) -[UIWindow _sendTouchesForEvent:] 0x000000018e424a5c (UIKit + 0x0003fa5c ) -[UIWindow sendEvent:] 0x000000018e3f5528 (UIKit + 0x00010528 ) -[UIApplication sendEvent:] 0x000000018ebe2a50 (UIKit + 0x007fda50 ) __dispatchPreprocessedEventFromEventQueue 0x000000018ebdc4b8 (UIKit + 0x007f74b8 ) __handleEventQueue 0x0000000188548274 (CoreFoundation + 0x000dd274 ) __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 0x0000000188547bbc (CoreFoundation + 0x000dcbbc ) __CFRunLoopDoSources0 0x00000001885457bc (CoreFoundation + 0x000da7bc ) __CFRunLoopRun 0x0000000188474044 (CoreFoundation + 0x00009044 ) CFRunLoopRunSpecific 0x0000000189efa194 (GraphicsServices + 0x0000c194 ) GSEventRunModal 0x000000018e4602f8 (UIKit + 0x0007b2f8 ) -[UIApplication _run] 0x000000018e45b030 (UIKit + 0x00076030 ) UIApplicationMain 0x0000000100010404 (Chrome -chrome_exe_main.mm:66 ) main 0x00000001874585b4 (libdyld.dylib + 0x000045b4 ) start
,
Jan 2 2017
,
Jan 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22b65df274844b3a459a8dd02cce8f8eaa655a7f commit 22b65df274844b3a459a8dd02cce8f8eaa655a7f Author: olivierrobin <olivierrobin@chromium.org> Date: Mon Jan 02 10:10:44 2017 Check editing status before doing actions. Mode switching is animated so buttons can be pressed after mode was switched. Check the editing mode and cancel action if editing mode is off. BUG= 677777 Review-Url: https://codereview.chromium.org/2609023002 Cr-Commit-Position: refs/heads/master@{#441054} [modify] https://crrev.com/22b65df274844b3a459a8dd02cce8f8eaa655a7f/ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm
,
Jan 2 2017
,
Jan 3 2017
Verified in 57.0.2970.0 canary, iPhone 6 plus iOS 10.2, iPhone 9.3.5 Looks good. |
||||
►
Sign in to add a comment |
||||
Comment 1 by olivierrobin@chromium.org
, Jan 2 2017Labels: ReleaseBlock-Stable M-57
Owner: gambard@chromium.org
Status: Assigned (was: Untriaged)