New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 677772 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature


Participants' hotlists:
Fixing-touch


Sign in to add a comment

Can't take screenshot in TouchView mode

Project Member Reported by reve...@chromium.org, Jan 2 2017

Issue description

There's no easy way to take a screenshot in TouchView mode as the normal keyboard shortcut is disabled as part of the rest of the physical keyboard.

Would be nice if holding down "power + volume-down" (consistent with Android) would work on devices with these buttons on the side of the device.

 

Comment 1 by osh...@chromium.org, Jan 20 2017

Cc: abodenha@chromium.org
abodenha@, who worked on the power button change?
Cc: derat@chromium.org zork@chromium.org yhanada@chromium.org oka@chromium.org
Components: UI>Shell>TouchView
Labels: -Pri-3 Pri-2
Owner: omrilio@chromium.org
Status: Assigned (was: Untriaged)
Omri, could you define this feature? I needed this to file a virtual keyboard bug, but I was stuck. :) BTW, there are three flavors:

1) Ctrl-F5 - full screenshot
2) Ctrl-Shift-F5 - region
3) Ctrl-Alt-F5  - window

I guess we'd only need 1) in the tablet mode.
Labels: M-60
Owner: reve...@chromium.org
We have defined the MVP of screenshot taking to be identical to Android: Power + Volume down button (exactly as comment#1 asks).
This should already work now, on some devices it's still power+volume up though :-/
In the future we are also looking into adding a UI element for this like the stylus menu "take a screenshot" action.

TL;DR This should be fixed, reveman@ could you try and take a screenshot using power+volume button on your specific device (after updating)?


Status: Fixed (was: Assigned)
Just tested on Kevin. Power + Volume Down seems to be working now. Thanks!
Great! Glad to hear :)
Does this work with Caroline as well? I think it didn't work with my caroline but need to check again next week

Comment 8 by flackr@chromium.org, Apr 15 2017

The code responsible for this is in ash::PowerButtonController::OnPowerButtonEvent. As long as the device knows it's in touchview / maximize mode it should work.

https://cs.chromium.org/chromium/src/ash/wm/power_button_controller.cc?dr=C&l=93
Cc: conradlo@chromium.org
Note that we plan to change it to also be supported in clamshell mode per offline discussion with +conradlo.

Comment 10 by satorux@google.com, Apr 17 2017

Didn't work with my caroline: Pressing Power + Volume down turned off the device

Google Chrome	58.0.3029.68 (Official Build) beta (64-bit)
Revision	0
Platform	9334.43.0 (Official Build) beta-channel caroline

I guess my system image is too old?
Note you should hold the volume down key and press power. That code to take screenshots with the hotkey landed a long time ago https://codereview.chromium.org/263813002/ you're definitely not on too old of an image. I know devices with "legacy" power buttons shut off immediately when the button is pressed so it would not work if you had accidentally hit power first on such a device, but I'm not familiar with caroline.
flacker: it worked with your instruction!

Re comment 10, I was long pressing Power + Volume down, with Power button pressed a little earlier.

Maybe I'm the only person who pressed the power button first thus ended up turning off the device, but would be good if the feature could work nicely for users like me. :) I'll fiel a separate bug.


We could probably make code changes to make it more reliable (i.e. delay powering off, support pressing either button first).

Comment 14 by satorux@google.com, Apr 17 2017

Filed  issue 712072  for making the hotkey more reliable
Status: Verified (was: Fixed)
Chrome OS 9532.0.0, 60.0.3092.0
and more tracking  issue 712072   

Sign in to add a comment