New issue
Advanced search Search tips

Issue 677679 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

URLs that are too long to fit entirely in URL bar should fade on Android

Reported by billdill...@gmail.com, Dec 31 2016

Issue description

Steps to reproduce the problem:
I just noticed a small detail in Chrome for iPhone that is not present in Chrome for Android phones: if a URL is too long to fit entirely in the URL bar, in Chrome for iPhone, the ends fade out to indicate that the entire URL is not being shown. But on Chrome for Android phones, it just abruptly chops off, which is not good. It should also fade out just like Chrome for iPhone

What is the expected behavior?

What went wrong?
see above

Did this work before? N/A 

Chrome version: 55  Channel: stable
OS Version: 6.0
Flash Version: 

There are quite a few other small differences between Chrome for iPhone and Chrome for Android phones and this is not right, if there is a feature or enhancement for one, it should go to the other if possible. The Chrome for iPhone team and Chrome for Android phone teams should be one in the same! Right now, clearly there is some separation and this needs to be remedied.
 
fadeoverflow.png
54.2 KB View Download
Owner: tedc...@chromium.org
Status: Assigned (was: Unconfirmed)
Cc: rolfe@chromium.org k...@chromium.org
I believe fading was removed when we added support for theme colors.  We have to draw the fade ourselves instead of relying on Android and the composed colors of theme colors makes that difficult.

Adding UX and PM to discuss further though.
Cc: tedc...@chromium.org
Components: -UI UI>Browser>Omnibox
Owner: ----
Status: Available (was: Assigned)

Comment 4 by k...@chromium.org, Jan 6 2017

Cc: emilyschechter@chromium.org
+emily from omnibox team

I'm open to using the fading behavior of iOS. Is it a significant amount of work to make it fade?

Comment 5 by rolfe@chromium.org, Jan 6 2017

UX agreeing - like ktam@ it's fine with me to match iOS if it doesn't cause any performance problems and it's not a hassle to implement.
It would be great for Android to match iOS! It's important that the eTLD+1 is preserved -- iOS does this correctly - see slide 3 here (https://docs.google.com/presentation/d/1OVXsjFm5DqzxnK97klcJ-qfeBB_nI1DloK9fEoHanGc/edit#slide=id.g15cb312756_0_117)

Not directly related to this URL fading feature, but there is another small feature that is in Chrome for Android phones but not Chrome for iPhone, and I cannot fathom why other than the Chrome for iPhone team and Chrome for Android phones team are separate and not communicating well... I'll report it but the root of the problem is, there should be 1 unified "Chrome for Phones" team (I understand there is significant differences between Android and the iPhone, but still), but at the moment it really seems like there is a Chrome for iPhone team and also a Chrome for Android phones team and they aren't communicating well. A website wrote an article recently stating how strangely, Google's iPhone apps are in some ways better than Google's Android apps! If anything, it should be the other way around! 
here is the other small missing feature for those interested https://bugs.chromium.org/p/chromium/issues/detail?id=679083 I just filed it
Summary: URL's that are too long to fit entirely in URL bar should fade on Android (was: URL's that are too long to fit entirely in URL bar do not fade out as they do in Chrome for iPhone)
Summary: URLs that are too long to fit entirely in URL bar should fade on Android (was: URL's that are too long to fit entirely in URL bar should fade on Android)
Well if theme colors is preventing the fading from happening, it can still be done in incognito mode because the incognito bar color is always the same 
Just thought I should mention that Firefox for Android fades out too 
posting this here because it's very very similar, if not the same https://bugs.chromium.org/p/chromium/issues/detail?id=688867 
Cc: maxwalker@chromium.org jdonnelly@chromium.org
Issue 688867 has been merged into this issue.

Comment 15 by rolfe@chromium.org, Mar 22 2017

Cc: -rolfe@chromium.org
maxwalker@ to be the design person on this
Is this being worked on? The URL bar is visible such a large amount of the time, it really should fade out. I really do think of this as something important, it's not about prettiness, it's functional
Cc: pschaffner@chromium.org srahim@chromium.org
Adding pschaffner@ and srahim@ who are working on a Chrome standard for truncation.
Labels: -Pri-2 Hotlist-Polish Pri-3
I think this should be a higher priority because it's so highly visible. And since Chrome Home no longer has theme colors, could this be re-enabled just for Chrome Home?
It's a visible surface, but we have only a couple of people to work on hundreds of bugs in that visible surface, and many of them are more immediately critical than this one.

Comment 21 by k...@chromium.org, Feb 15 2018

Cc: -k...@chromium.org
Please don't forget this!
Bumping in case this was forgotten :) 
Cc: hannahs@google.com
The clipping can occur on the left and right in the steady- and edit state, see attachment for examples.

Ted, could you comment on technical feasibility? Any performance considerations? If fading isn't feasible for theme colors, would limiting it to regular and incognito toolbars be an option? (A solution that works everywhere would be preferable of course.)

Adding Hannah for Clank visual design.
Clipped vs Fade.png
403 KB View Download
Cc: twelling...@chromium.org mdjones@chromium.org
+twellington +mdjones

If we have a reliable way to calculate the computed color of the text box w/ transparency and the underlying color (ColorUtils#getColorWithOverlay perchance), then we should be able to do it for all variants of the toolbar.

The main complexity at this point would be the focusing/unfocusing animation.  We need to animate the clipped area as we are doing the transition.

We are looking at rewriting a bunch of that logic though, so we might be able to add this in as a feature enhancement along the way.

Sign in to add a comment