[WPT Export] Move to webkitpy.common.net.web.Web in WPTGitHub |
|||||
Issue description
,
Jan 3 2017
,
Mar 8 2017
This currently isn't possible as-is since webkitpy.common.net.web.Web only supports HTTP GET. We'd have to add HTTP POST and PUT support.
,
Mar 16 2017
This is also in conflict with bug 691653 for making WPT Sync its own library.
,
Mar 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa791ce4bcf3885b3325406ccbbdc6e974d2357b commit fa791ce4bcf3885b3325406ccbbdc6e974d2357b Author: Jeff Carpenter <jeffcarp@chromium.org> Date: Tue Mar 21 06:34:49 2017 [WPT Export] Fix logic error in WPTGitHub, move requests into common.net.web I discovered a bug in WPTGitHub. The only way to add a test for it was to move the request logic into webkitpy.common.net.web.Web, conveniently killing two birds with one stone. BUG= 677669 R=qyearsley@chromium.org Change-Id: I6eee236daff67c990348eb43be5f84d47c8dd8b7 Reviewed-on: https://chromium-review.googlesource.com/457198 Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#458328} [modify] https://crrev.com/fa791ce4bcf3885b3325406ccbbdc6e974d2357b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/web.py [modify] https://crrev.com/fa791ce4bcf3885b3325406ccbbdc6e974d2357b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/web_mock.py [modify] https://crrev.com/fa791ce4bcf3885b3325406ccbbdc6e974d2357b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py [modify] https://crrev.com/fa791ce4bcf3885b3325406ccbbdc6e974d2357b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github_unittest.py [modify] https://crrev.com/fa791ce4bcf3885b3325406ccbbdc6e974d2357b/third_party/WebKit/Tools/Scripts/wpt-export
,
Mar 21 2017
,
Jul 3 2017
,
Jul 3 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by qyears...@chromium.org
, Jan 3 2017