New issue
Advanced search Search tips

Issue 677666 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Feb 2018
Cc:
alexilin@chromium.org
mmenke@chromium.org
pasko@chromium.org
lizeb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 631966



Sign in to add a comment

Audit //net APIs in resource_prefetcher.cc

Project Member Reported by csharrison@chromium.org, Dec 30 2016 
This code had a few net bugs in it, and was a re-land of an old project with only minor modifications. Let's pass some eyes through it just in case.

+lizeb and +pasko fixed a bunch of bugs already, but there could be some sharp edges (that //net team is trying to document with [1])

[1]: https://docs.google.com/document/d/1i2sZ-B4Wy7ucxt-rGN8eKrnsxLgEJBHYKFNUtlJr5a4/edit#

Comment 1 by pasko@chromium.org, Jan 2 2017

Cc: alexilin@chromium.org mmenke@chromium.org
Labels: -Pri-3 Pri-2
Status: Available (was: Untriaged)
Thank you for creating the bug, Charles. Special thanks for the link, the document is awesome!! I really wanted something like this for a while, but could not find it. Is it new?

+alexilin@ who is actively working on speculative prefetch.

I think the likely path forward is that we'd do an initial audit+fixing together with alexilin+lizeb+pasko and then will ask some wizard like +mmenke@ to have the final stamp. SG?

Comment 2 by pasko@chromium.org, Jan 2 2017

Blocking: 631966

Comment 3 by csharrison@chromium.org, Jan 2 2017 

The document is indeed new and will probably be changing. Comments welcome!


As long as mmenke is okay with doing a quick audit the plan SGTM.

Comment 4 by mmenke@chromium.org, Jan 3 2017 

SGTM.  Also happy to do passes on reviews before the final stamp, though I can be slow.

Comment 5 by pasko@chromium.org, Jan 3 2017 

Thank you, Matt!
Project Member

Comment 6 by sheriffbot@chromium.org, Feb 15 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by alexilin@chromium.org, Feb 15 2018

Status: WontFix (was: Untriaged)
resource_prefetcher.cc is not used anymore and will be deleted soon.
►

Sign in to add a comment