New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 677656 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 526154
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Missing Xrefs

Project Member Reported by emso@chromium.org, Dec 30 2016

Issue description

From phajdan:

I was looking at https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/text/CharacterEmoji.cpp?q=CharacterEmoji.cpp&sq=package:chromium&dr and apparently there don't appear to be any cross-references for the following snippet of code (and possibly others). Is that expected? Should I file a bug?

Specifically, I'd expect xrefs for icu::UnicodeSet, ICUError and especially applyPattern method.

static void applyPatternAndFreeze(icu::UnicodeSet* unicodeSet,
                                  const char* pattern) {
  ICUError err;
  // Use ICU's invariant-character initialization method.
  unicodeSet->applyPattern(icu::UnicodeString(pattern, -1, US_INV), err);
  unicodeSet->freeze();
  ASSERT(err == U_ZERO_ERROR);
}
 

Comment 1 by emso@chromium.org, Jan 3 2017

Looking into this in more detail, the file in question is included in the grok index but the referenced section is not included due to the condition on this line: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/text/CharacterEmoji.cpp?rcl=0&l=25, i.e., this is true:

#if defined(USING_SYSTEM_ICU) || (U_ICU_VERSION_MAJOR_NUM <= 57

USING_SYSTEM_ICU appears to be defined in https://cs.chromium.org/chromium/src/build/linux/unbundle/icu.gn?rcl=0&l=17
as part of a “icu_config” object, and U_ICU_VERSION_MAJOR_NUM is defined to be 58 (https://cs.chromium.org/chromium/src/third_party/icu/source/common/unicode/uvernum.h?rcl=0&l=61).

This config does not appear to be included in the one we are currently building for on Linux (https://cs.chromium.org/chromium/build/scripts/slave/recipes/chromium_codesearch.py?rcl=0&l=72), e.g., 'all'. 

Is this a config that should be included in all, or should we adjust our config to include it?

Comment 2 by emso@chromium.org, Jan 6 2017

Labels: Xrefs
Mergedinto: 526154
Status: Duplicate (was: Assigned)

Sign in to add a comment