New issue
Advanced search Search tips

Issue 677623 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

crosh: update crosh_builtin extension name

Project Member Reported by fbeaufort@chromium.org, Dec 30 2016

Issue description

Google Chrome	57.0.2965.0 (Official Build) canary (64-bit)
Platform	9129.0.0 (Official Build) canary-channel samus

What steps will reproduce the problem?
(1) Open Crosh with [Ctrl] + [Alt] + t

What is the expected result?
Extension chip name should be readable.

What happens instead?
It says "crosh_builtin"

Please change crosh extension name to "Crosh" or "Terminal" in https://chromium.googlesource.com/chromium/src/+/master/chrome/browser/resources/chromeos/crosh_builtin/manifest.json#3

 
Screenshot 2016-12-30 at 9.20.43 AM.png
98.4 KB View Download

Comment 1 Deleted

Comment 2 Deleted

Comment 3 Deleted

Comment 4 Deleted

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3861aa1017702ce97842ed438c5da30dc2f591c5

commit 3861aa1017702ce97842ed438c5da30dc2f591c5
Author: vapier <vapier@chromium.org>
Date: Sat Apr 01 19:57:11 2017

crosh_builtin: update name to be more friendly

We don't translate this, but nothing in crosh is translated either.

BUG= chromium:677623 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2788863005
Cr-Commit-Position: refs/heads/master@{#461329}

[modify] https://crrev.com/3861aa1017702ce97842ed438c5da30dc2f591c5/chrome/browser/resources/chromeos/crosh_builtin/manifest.json

Status: Fixed (was: Available)
should be available in R59+
Status: Verified (was: Fixed)
Chrome OS 9532.0.0, 60.0.3092.0

Sign in to add a comment