New issue
Advanced search Search tips

Issue 677582 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Privacy] Manage certs needs 'open-in-new' icon

Project Member Reported by bettes@chromium.org, Dec 30 2016

Issue description

This is mac-only. 

According to this guideline: 
If the button opens a new tab and/or an application not owned by Chrome, use [➚]
If the button helps you manage Chrome UI and is owned by Chrome (either web or system), use the ►

Manage certificates opens the native system preferences so we should use the "open in new" icon instead of the ►

What does Linux do? Please advise.
 

Comment 1 by bettes@chromium.org, Dec 30 2016

Labels: -Pri-2 Pri-3
On Linux the "manage certificates" button opens a UI managed by Chrome, see attachment. So based on the guidelines above, we should display [➚] for Mac, and ► for all other platforms. 
cert_subpage.png
26.1 KB View Download
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d47305072d3bf73cc0ad4998f0c9970f2b0b8c8

commit 5d47305072d3bf73cc0ad4998f0c9970f2b0b8c8
Author: dpapad <dpapad@chromium.org>
Date: Fri Jan 06 02:48:42 2017

MD Settings: Use appropriate icon for "manage certificates" button.

BUG= 677582 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2613023003
Cr-Commit-Position: refs/heads/master@{#441849}

[modify] https://crrev.com/5d47305072d3bf73cc0ad4998f0c9970f2b0b8c8/chrome/browser/resources/settings/privacy_page/privacy_page.html

Status: Fixed (was: Started)

Sign in to add a comment