Payment Request API fails because of depth limit on JS dictionary parsing |
|||||
Issue descriptionThe Payment Request spec (https://w3c.github.io/browser-payment-api/) defines a pretty deep structure of types (inside the PaymentRequest type) to be passed from the page to the browser. The depth limit of 6 on dictionary values returned by JS evaluations (as established in http://crrev.com/2335483004) broke the API implementation on iOS. [mahmadi@ actually has a test in review which would have caught this. My bad for not establishing such a test earlier.] Can I increase the depth limit to 8 or was that limit based on some analysis? That would cover everything in the spec.
,
Dec 30 2016
,
Dec 30 2016
Assigning back to jif@ who implemented recursion limit and probably remembers why we have limit of 6.
,
Dec 30 2016
Chrome's JSON parser has a depth limit of 1000, btw.
,
Jan 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ba585a2d3f47b3f80cb12ea5b559858b1807c8f commit 1ba585a2d3f47b3f80cb12ea5b559858b1807c8f Author: mahmadi <mahmadi@chromium.org> Date: Thu Jan 05 16:44:39 2017 Increases the depth of parsing dictionaries returned by JS evaluation BUG= 677574 Review-Url: https://codereview.chromium.org/2617433004 Cr-Commit-Position: refs/heads/master@{#441674} [modify] https://crrev.com/1ba585a2d3f47b3f80cb12ea5b559858b1807c8f/ios/web/web_state/ui/web_view_js_utils.mm
,
Jan 5 2017
,
Jan 6 2017
The depth limit of 6 was arbitrary; Increasing it to 8 is fine.
,
Jun 27 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jdonnelly@chromium.org
, Dec 29 2016