New issue
Advanced search Search tips

Issue 677561 link

Starred by 2 users
Status: Fixed
Owner:
qyears...@chromium.org
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove unused functions and methods from webkitpy.

Project Member Reported by qyears...@chromium.org, Dec 29 2016 
By searching for names that only appear after "def" but nowhere else, we can find potentially unused functions.

In particular, the following functions appear to be (probably) be unused currently:

webkitpy/common/checkout/scm/git.py:    add_all
webkitpy/common/checkout/scm/git.py:    _deleted_files
webkitpy/common/checkout/scm/scm_mock.py:    add_all
webkitpy/common/checkout/scm/scm.py:    add_all
webkitpy/common/checkout/scm/scm.py:    _deleted_files
webkitpy/common/checkout/scm/scm_unittest.py:    _git_diff
webkitpy/common/checkout/scm/scm_unittest.py:    _rmtree
webkitpy/common/checkout/scm/scm_unittest.py:    _run_silent
webkitpy/common/checkout/scm/scm_unittest.py:    _shared_test_add_recursively
webkitpy/common/checkout/scm/scm_unittest.py:    _shared_test_delete_recursively_or_not
webkitpy/common/checkout/scm/scm_unittest.py:    _shared_test_delete_recursively_or_not
webkitpy/common/checkout/scm/scm_unittest.py:    _shared_test_delete_recursively
webkitpy/common/checkout/scm/scm_unittest.py:    _shared_test_move_recursive
webkitpy/common/checkout/scm/scm_unittest.py:    _shared_test_move_recursive
webkitpy/common/checkout/scm/scm_unittest.py:    _shared_test_move
webkitpy/common/checkout/scm/scm_unittest.py:    _write_binary_file
webkitpy/common/net/buildbot.py:    latest_layout_test_results
webkitpy/common/net/buildbot_unittest.py:    fetch_layout_test_results_with_no_responses
webkitpy/common/net/web_mock.py:    select_form
webkitpy/common/system/executive_mock.py:    kill_all
webkitpy/common/system/executive.py:    wait_newest
webkitpy/common/system/user.py:    prompt_password
webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:    _find_test_in_trie
webkitpy/layout_tests/models/test_expectations.py:    has_pixel_failures
webkitpy/layout_tests/port/base.py:    _check_port_build
webkitpy/layout_tests/port/base.py:    _chromium_baseline_path
webkitpy/layout_tests/port/base.py:    warn_if_bug_missing_in_test_expectations
webkitpy/layout_tests/port/base_unittest.py:    _file_with_contents
webkitpy/layout_tests/port/linux.py:    _check_apache_install
webkitpy/layout_tests/port/port_testcase.py:    assert_servers_are_down
webkitpy/layout_tests/port/port_testcase.py:    assert_servers_are_up
webkitpy/layout_tests/port/server_process_unittest.py:    process_kill_time
webkitpy/layout_tests/port/win.py:    _modules_to_search_for_symbols
webkitpy/layout_tests/run_webkit_tests_unittest.py:    assertEmpty
webkitpy/layout_tests/run_webkit_tests_unittest.py:    has_test_of_type
webkitpy/layout_tests/views/buildbot_results_unittest.py:    assertEmpty
webkitpy/layout_tests/views/printing_unittest.py:    assertEmpty
webkitpy/performance_tests/perftestsrunner_unittest.py:    test_run_silent_test
webkitpy/style/checkers/cpp.py:get_initial_spaces_for_line
webkitpy/style/checkers/cpp.py:    set_did_inside_namespace_indent_warning
webkitpy/style/checkers/cpp_unittest.py:    function_body_with_blank_lines
webkitpy/style/checkers/cpp_unittest.py:    verify_all_categories_are_seen
webkitpy/style/checkers/test_expectations.py:    _handle_error_message
webkitpy/tool/commands/rebaseline.py:    _run_webkit_patch
webkitpy/tool/servers/reflection_handler.py:    _read_entity_body_as_json
webkitpy/webgl/update_webgl_conformance_tests_unittest.py:    dont_strip_other_headers

Comment 1 by qyears...@chromium.org, Dec 29 2016

Labels: Hotlist-GoodFirstBug
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05f888ef0ee28b52ecfe89976bbeb3d22fc37210

commit 05f888ef0ee28b52ecfe89976bbeb3d22fc37210
Author: qyearsley <qyearsley@chromium.org>
Date: Tue Jan 03 23:17:25 2017

Remove unused function _invert_dictionary from baseline_optimizer.py.

BUG= 677561 

Review-Url: https://codereview.chromium.org/2609613002
Cr-Commit-Position: refs/heads/master@{#441244}

[modify] https://crrev.com/05f888ef0ee28b52ecfe89976bbeb3d22fc37210/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baseline_optimizer.py
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7dac5cba044e8882732a727db22c2d578d693dec

commit 7dac5cba044e8882732a727db22c2d578d693dec
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Feb 08 00:36:44 2017

Remove unused methods in webkitpy/layout_tests/.

BUG= 677561 

Review-Url: https://codereview.chromium.org/2678273004
Cr-Commit-Position: refs/heads/master@{#448820}

[modify] https://crrev.com/7dac5cba044e8882732a727db22c2d578d693dec/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py
[modify] https://crrev.com/7dac5cba044e8882732a727db22c2d578d693dec/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
[modify] https://crrev.com/7dac5cba044e8882732a727db22c2d578d693dec/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
[modify] https://crrev.com/7dac5cba044e8882732a727db22c2d578d693dec/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
[modify] https://crrev.com/7dac5cba044e8882732a727db22c2d578d693dec/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux.py
[modify] https://crrev.com/7dac5cba044e8882732a727db22c2d578d693dec/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py
[modify] https://crrev.com/7dac5cba044e8882732a727db22c2d578d693dec/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process_unittest.py
[modify] https://crrev.com/7dac5cba044e8882732a727db22c2d578d693dec/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py
[modify] https://crrev.com/7dac5cba044e8882732a727db22c2d578d693dec/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py
[modify] https://crrev.com/7dac5cba044e8882732a727db22c2d578d693dec/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py
[modify] https://crrev.com/7dac5cba044e8882732a727db22c2d578d693dec/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14f257efb0042f30b14172077d0cb815eea05ebc

commit 14f257efb0042f30b14172077d0cb815eea05ebc
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Feb 08 01:31:28 2017

Remove unused class MockBrowser in webkitpy/common/net/web_mock.py.

BUG= 677561 

Review-Url: https://codereview.chromium.org/2682833002
Cr-Commit-Position: refs/heads/master@{#448837}

[modify] https://crrev.com/14f257efb0042f30b14172077d0cb815eea05ebc/third_party/WebKit/Tools/Scripts/webkitpy/common/net/web_mock.py

Comment 5 by qyears...@chromium.org, Mar 2 2017

Owner: qyears...@chromium.org
Status: Started (was: Available)
Project Member

Comment 11 by bugdroid1@chromium.org, May 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/078204ebbd6e30ba2ed6078cedeb0574e524d4fd

commit 078204ebbd6e30ba2ed6078cedeb0574e524d4fd
Author: qyearsley <qyearsley@chromium.org>
Date: Thu May 25 19:01:34 2017

Remove unused methods from common.system.User.

Specifically:
 prompt_password
 prompt_with_multiple_lists
 edit
 page

There are other fixes that could be made in the user module,
but those can be done in other CLs.

BUG= 677561 

Review-Url: https://codereview.chromium.org/2901963002
Cr-Commit-Position: refs/heads/master@{#474738}

[modify] https://crrev.com/078204ebbd6e30ba2ed6078cedeb0574e524d4fd/third_party/WebKit/Tools/Scripts/webkitpy/common/system/user.py
[modify] https://crrev.com/078204ebbd6e30ba2ed6078cedeb0574e524d4fd/third_party/WebKit/Tools/Scripts/webkitpy/common/system/user_mock.py
[modify] https://crrev.com/078204ebbd6e30ba2ed6078cedeb0574e524d4fd/third_party/WebKit/Tools/Scripts/webkitpy/common/system/user_unittest.py
Project Member

Comment 12 by bugdroid1@chromium.org, May 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21b92c516789ee9b22578cb7b6bdad9790499110

commit 21b92c516789ee9b22578cb7b6bdad9790499110
Author: Quinten Yearsley <qyearsley@google.com>
Date: Fri May 26 16:04:58 2017

Remove the rest of the unused methods listed in  bug 677561 .

Bug:  677561 
Change-Id: Ibf351801752750b5f8bff35457ebe5fe5b3a39ac
Reviewed-on: https://chromium-review.googlesource.com/516343
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475020}
[modify] https://crrev.com/21b92c516789ee9b22578cb7b6bdad9790499110/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py
[modify] https://crrev.com/21b92c516789ee9b22578cb7b6bdad9790499110/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py
[modify] https://crrev.com/21b92c516789ee9b22578cb7b6bdad9790499110/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py
[modify] https://crrev.com/21b92c516789ee9b22578cb7b6bdad9790499110/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/test_expectations.py
[modify] https://crrev.com/21b92c516789ee9b22578cb7b6bdad9790499110/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
[modify] https://crrev.com/21b92c516789ee9b22578cb7b6bdad9790499110/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/reflection_handler.py

Comment 13 by qyears...@chromium.org, May 26 2017

Status: Fixed (was: Started)
►

Sign in to add a comment