New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 677555 link

Starred by 1 user
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Jan 2017
Cc:
dbeam@chromium.org
mmenke@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

The i18n source stream accumulates input before processing

Project Member Reported by dschuyler@chromium.org, Dec 29 2016 
The initial I18n source stream implementation accumulates the whole input file before processing the i18n replacements and sending the results to the output (downstream). This means that the whole html file may be buffered more than once in memory.

Since we control which html files are processed by this code and none of them  are larger than 100's of KB that implementation is okay.

It would be better though, if the i18n source streaming could handle streams of arbitrary size without running the process out of memory.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ba7a97bb01f0838d0d994f768a8af2f931afa16

commit 3ba7a97bb01f0838d0d994f768a8af2f931afa16
Author: dschuyler <dschuyler@chromium.org>
Date: Tue Jan 03 23:11:42 2017

[MD settings] stream i18n replacement without large accumulation buffer

This CL processes the i18n source stream data in smaller pieces so that
the data is not accumulated (buffered). This avoids the potential for
the i18n streaming use too much memory.

BUG= 677555 

Review-Url: https://codereview.chromium.org/2601313002
Cr-Commit-Position: refs/heads/master@{#441241}

[modify] https://crrev.com/3ba7a97bb01f0838d0d994f768a8af2f931afa16/content/browser/webui/i18n_source_stream.cc
[modify] https://crrev.com/3ba7a97bb01f0838d0d994f768a8af2f931afa16/content/browser/webui/i18n_source_stream.h
[modify] https://crrev.com/3ba7a97bb01f0838d0d994f768a8af2f931afa16/content/browser/webui/i18n_source_stream_unittest.cc

Comment 2 by dschuyler@chromium.org, Jan 3 2017

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ead12efed77ced7980c10c557dd390e288def6ed

commit ead12efed77ced7980c10c557dd390e288def6ed
Author: dschuyler <dschuyler@chromium.org>
Date: Tue Jan 10 02:36:13 2017

[i18n streaming] improve unit tests

This CL adds and improves the unit tests for the i18n streaming. It does
not add features or other changes (test case changes only).

(Not a fix for  bug 677555 , but related test cases).
BUG= 677555 

Review-Url: https://codereview.chromium.org/2610063003
Cr-Commit-Position: refs/heads/master@{#442450}

[modify] https://crrev.com/ead12efed77ced7980c10c557dd390e288def6ed/content/browser/webui/i18n_source_stream_unittest.cc
►

Sign in to add a comment