New issue
Advanced search Search tips

Issue 677552 link

Starred by 1 user
Status: Fixed
Owner:
eugene...@chromium.org
Closed: Feb 2017
Cc:
ios-bugs@chromium.org
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Remove WebController.StartProvisionalNavigationExitedWithEmptyNavigationManager logging

Project Member Reported by eugene...@chromium.org, Dec 29 2016 
Chrome for iOS crashes in |didCommitNavigation:| if Navigation Manager is empty. It's unclear how app can get into this state and one assumption is that didStartProvisionalNavigation: does not add a pending navigation. This UMA action is logged when didStartProvisionalNavigation: fails to add a pending item.

This action is added only to verify the assumption and should be removed after M46 is released.

Comment 1 Deleted

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ae5bc01814c3239ee064df73481a25b1cbb2587

commit 9ae5bc01814c3239ee064df73481a25b1cbb2587
Author: eugenebut <eugenebut@chromium.org>
Date: Thu Feb 23 01:55:00 2017

Removed StartProvisionalNavigationExitedWithEmptyNavigationManager metric.

BUG= 677552 

Review-Url: https://codereview.chromium.org/2709633008
Cr-Commit-Position: refs/heads/master@{#452342}

[modify] https://crrev.com/9ae5bc01814c3239ee064df73481a25b1cbb2587/ios/web/web_state/ui/crw_web_controller.mm
[modify] https://crrev.com/9ae5bc01814c3239ee064df73481a25b1cbb2587/tools/metrics/histograms/histograms.xml

Comment 3 by eugene...@chromium.org, Feb 23 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment