New issue
Advanced search Search tips

Issue 677519 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Credit card upload should check that the CVC has a valid length

Project Member Reported by jdonnelly@chromium.org, Dec 29 2016

Issue description

We're sometimes misclassifying zip codes as CVCs and the 5-digit codes are causing server-side errors. Plus, since we know this will fail, we shouldn't be offering upload to the user anyway.

This can be fixed by verifying the length here[1] using the same logic that the card unmask controller uses[2].


[1] https://cs.chromium.org/chromium/src/components/autofill/core/browser/autofill_manager.cc?l=1169
[2] https://cs.chromium.org/chromium/src/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc?l=282
 
I'm having difficulty saving a card to the server. I'm trying saving a new credit card using https://rsolomakhin.github.io/autofill/ but the SyncService returned here [1] is always NULL so the logic falls back to saving the card locally. Any hints on how to reproduce this?

[1] https://cs.chromium.org/chromium/src/components/autofill/core/browser/autofill_manager.cc?l=1092
Are you logged in? I don't know why you wouldn't have a sync service at all unless you weren't logged in or were using the command-line that disables sync.

In general, it's also worth being aware of go/testing-autofill-cc which lists various prerequisites and troubleshooting steps for upload, though most are downstream of sync actually working at all.
Status: Started (was: Assigned)
As usual, your docs are super useful and comprehensive. I was trying to upload a credit card in iOS! 
Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment