Which flows is this about?

I need to revisit it, but I guess there could be situation when authpolicyd generate machine keytab, but enrollment aborts for some reason. Thus we need to delete the file.

Also situation when callback from DBUS comes after user click close on waiting screen.

To clarify: Is this about Chrome side or authpolicy side?

I guess both: Chrome would have to send a signal to clean the state.

Could you please add a list of cases that need to be handled to make this issue actionable?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8c46c166645ad80352881e692745cd2c30aa24f

commit d8c46c166645ad80352881e692745cd2c30aa24f
Author: rsorokin <rsorokin@chromium.org>
Date: Tue Apr 11 08:43:19 2017

Add AuthPolicyLoginHelper

Allows cancel all pending calls and restart AuthPolicy service. Used
for enrollment and login UI to proper cancel the flows.

Also
Add RestartAuthPolicyService into UpstartClient.
Make UI flows properly cancel pending authpolicy operations.
Add delays in the FakeAuthPolicy clients in JoinAdDomain and
Authenticate user calls.
Move writing password piping into the AuthPolicyLoginHelper.

BUG= 677487 , 662400 , 676337 , 675597 
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2794493002
Cr-Commit-Position: refs/heads/master@{#463578}

[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chrome/browser/chromeos/login/helper.cc
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chrome/browser/chromeos/login/helper.h
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chrome/browser/chromeos/login/login_browsertest.cc
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.h
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/BUILD.gn
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/dbus/auth_policy_client.cc
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/dbus/auth_policy_client.h
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/dbus/fake_auth_policy_client.cc
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/dbus/fake_auth_policy_client.h
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/dbus/fake_auth_policy_client_unittest.cc
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/dbus/fake_upstart_client.cc
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/dbus/fake_upstart_client.h
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/dbus/upstart_client.cc
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/dbus/upstart_client.h
[add] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/login/auth/authpolicy_login_helper.cc
[add] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/login/auth/authpolicy_login_helper.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/e31bbbb1142cf1c5bb00a9cd39c5e383ddefb8c7

commit e31bbbb1142cf1c5bb00a9cd39c5e383ddefb8c7
Author: Roman Sorokin <rsorokin@chromium.org>
Date: Fri Apr 21 09:34:50 2017

authpolicy: Allow Chrome to restart authpolicyd

During the login flow if user cancelled it restart would be used to
clean the state.

BUG= chromium:677487 
TEST=manual

Change-Id: Ie3bd55009662a99eb72bc4c0ba45593e34aebb4d
Reviewed-on: https://chromium-review.googlesource.com/473306
Commit-Ready: Roman Sorokin <rsorokin@chromium.org>
Tested-by: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>

[modify] https://crrev.com/e31bbbb1142cf1c5bb00a9cd39c5e383ddefb8c7/authpolicy/etc/dbus-1/org.chromium.AuthPolicy.conf