New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 677452 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

11%-11.4% regression in blink_perf.bindings at 440409:440457

Project Member Reported by alexclarke@chromium.org, Dec 29 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=677452

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgn6XPuAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgn8WHpgoM


Bot(s) for this bug's original alert(s):

android-nexus5
android-nexus9
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Dec 30 2016

Cc: tebbi@chromium.org
Owner: tebbi@chromium.org

=== PERF REGRESSION ===


=== Auto-CCing suspected CL author tebbi@chromium.org ===

Hi tebbi@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert of [turbofan] reenable escape analysis to further investigate crashes (patchset #1 id:1 of https://codereview.chromium.org/2589163002/ )
Author  : tebbi
Commit description:
  
Reason for revert:
still crashing with the known issues

Original issue's description:
> [turbofan] reenable escape analysis to further investigate crashes
>
> R=jarin@chromium.org
>
> BUG=chromium:669242
>
> Review-Url: https://codereview.chromium.org/2589163002
> Cr-Commit-Position: refs/heads/master@{#41857}
> Committed: https://chromium.googlesource.com/v8/v8/+/fd4812323f8c90662be1d0961fbeaabe52565478

TBR=jarin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:669242

Review-Url: https://codereview.chromium.org/2601463002
Cr-Commit-Position: refs/heads/master@{#41918}
Commit  : 8dad4feec9e45c1ba910808a388274f375584b5d
Date    : Thu Dec 22 10:56:39 2016


===== TESTED REVISIONS =====
Revision                       Mean     Std Dev  N   Good?
chromium@440411                16.0726  2.7797   30  good
chromium@440416                15.6046  2.11411  30  good
chromium@440416,v8@86e2a19991  15.6772  2.49215  25  good
chromium@440416,v8@aa8a208a47  15.599   1.91875  30  good
chromium@440416,v8@8dad4feec9  14.015   2.20771  30  bad    <--
chromium@440416,v8@132b7bf9e0  14.2053  2.93487  25  bad
chromium@440417                13.9599  1.52012  30  bad
chromium@440418                14.187   2.0951   30  bad
chromium@440419                14.2166  1.80391  25  bad
chromium@440421                14.6369  2.33602  30  bad
chromium@440430                14.6881  1.99666  30  bad
chromium@440448                14.4313  1.91864  30  bad

Bisect job ran on: android_nexus9_perf_bisect
Bug ID: 677452

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.bindings
Test Metric: typed-array-construct-from-array/typed-array-construct-from-array
Relative Change: 10.21%

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus9_perf_bisect/builds/2344
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8991947735537091584


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6384509350576128

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 4 by gab@chromium.org, Jan 11 2017

Status: Assigned (was: Untriaged)
Perf sheriff checking in, any update here?

Comment 6 by tebbi@chromium.org, Jan 19 2017

Status: WontFix (was: Assigned)
Escape analysis has been disabled meanwhile. When it was activated again with https://codereview.chromium.org/2626013002/, the graphs linked with this bug don't show any regression. So I don't think that escape analysis currently affects this metric.

What is odd, though, is the earlier regression https://codereview.chromium.org/2626013002/, which is an order of magnitude more severe. But I don't know how to analyze this.

Sign in to add a comment