=== PERF REGRESSION ===
=== Auto-CCing suspected CL author tkent@chromium.org ===
Hi tkent@chromium.org, the bisect results pointed to your CL, please take a look at the
results.
===== BISECT JOB RESULTS =====
Status: completed
===== SUSPECTED CL(s) =====
Subject : Blur immediately if an attribute change made an element unfocusable.
Author : tkent
Commit description:
tabindex, hidden, contenteditable, disabled, href attributes affect element
focusability, however we didn't remove focus from the element immediately after
an attribute change made the element unfocusable because dispatching events in
parseAttribute() looks dangerous. Actually, dispatching events for update of
some specific attributes in parseAttribute() can cause bugs.
With this CL, we remove focus in Element::attributeChanged().
* Element::AttributeModificationReason
Add kByParser, and update existing item names.
We don't check focusability for kByParser and kByCloning because the element
can't be focused in these cases.
* Element::attributeChanged()
Stop using a default argument.
Move focus check for tabindex change from parseAttribute().
* HTMLAnchorElement
Move focus check for href change from parseAttribute() to attributeChanged().
* HTMLElement
Move focus check for hidden and contenteditable change from parseAttribute()
to attributeChanged().
* HTMLFormControlElement
Move focus check for disabled change from parseAttribute() to
attributeChanged().
* HTMLFieldSetElement
Check focusability of descendant form controls when the fieldset element is
disabled, or a legend element is inserted.
BUG= 660999
Review-Url: https://codereview.chromium.org/2586143004
Cr-Commit-Position: refs/heads/master@{#440063}
Commit : 40ccb2581137efc2fc7d2a1041073fa00caed75a
Date : Wed Dec 21 09:48:37 2016
===== TESTED REVISIONS =====
Revision Mean Std Dev N Good?
chromium@440061 65.7032 1.10223 6 good
chromium@440062 65.2265 2.03535 6 good
chromium@440063 60.2393 1.31495 6 bad <--
chromium@440065 60.0923 0.660675 6 bad
chromium@440069 60.1996 1.91669 6 bad
chromium@440077 61.0857 1.2149 6 bad
chromium@440092 60.2627 0.58258 6 bad
chromium@440122 61.3961 0.869769 6 bad
Bisect job ran on: android_one_perf_bisect
Bug ID: 677446
Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests dromaeo.domcoreattr
Test Metric: dom/dom
Relative Change: 6.56%
Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_one_perf_bisect/builds/1899
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8991947869919142976
Not what you expected? We'll investigate and get back to you!
https://chromeperf.appspot.com/bad_bisect?try_job_id=5856745111420928
| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
| X | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect. Thank you!
Comment 1 by alexclarke@chromium.org
, Dec 29 2016