New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 677385 link

Starred by 1 user
Status: Fixed
Owner:
█ kjellander@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Cc:
ios-bugs@chromium.org
oprypin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Feature



Sign in to add a comment

Setup iOS simulator bots testing on iOS 9.0 simulator

Project Member Reported by kjellander@chromium.org, Dec 29 2016 
Tracking bug for setting up bots that runs our tests on the iOS 9.0 simulator (the ones we have today run on iOS 10.0 simulator).
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/12166898d93f53274333f549b54c857bf68238fc

commit 12166898d93f53274333f549b54c857bf68238fc
Author: Henrik Kjellander <kjellander@webrtc.org>
Date: Thu Dec 29 13:00:23 2016

Rename iOS JSON file.

The currently checked in file from
https://codereview.webrtc.org/2604153002/ contained a
whitespace in the filename.

BUG= chromium:677385 
TBR=ehmaldonado@webrtc.org

Review-Url: https://codereview.webrtc.org/2602053002 .
Cr-Commit-Position: refs/heads/master@{#15833}

[rename] https://crrev.com/12166898d93f53274333f549b54c857bf68238fc/webrtc/build/ios/client.webrtc.fyi/iOS64_Sim_Debug_(iOS_9.0).json
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/81fa52ff44775924214e4765d9b7ec70a71b5437

commit 81fa52ff44775924214e4765d9b7ec70a71b5437
Author: Henrik Kjellander <kjellander@webrtc.org>
Date: Thu Dec 29 20:01:38 2016

Change iOS Simulator bot to 32-bit and iPhone 5.

Before promoting it to the main waterfall I thought it made
sense to ensure it works for a phone that actually is 32-bit
(iPhone 6s isn't). It also makes more sense to run the older
iOS version (9) on the older phone.

BUG= chromium:677385 
TBR=ehmaldonado@webrtc.org

Review-Url: https://codereview.webrtc.org/2604203002 .
Cr-Commit-Position: refs/heads/master@{#15837}

[modify] https://crrev.com/81fa52ff44775924214e4765d9b7ec70a71b5437/tools-webrtc/mb/mb_config.pyl
[rename] https://crrev.com/81fa52ff44775924214e4765d9b7ec70a71b5437/webrtc/build/ios/client.webrtc.fyi/iOS32_Sim_Debug_(iOS_9.0).json
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/64bc2179ba6df47a1b624c7fc13910e1b64a951f

commit 64bc2179ba6df47a1b624c7fc13910e1b64a951f
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Thu Dec 29 20:00:52 2016

WebRTC: Change staging iOS simulator bot to 32-bit

The bot that runs the older iOS version should be the 32-bit
one, so the plan is to run one 32-bit, iOS 9.0 and then one
32-bit and one 64-bit for iOS 10.0.
Deploy this to ensure 32-bit iOS 9.0 is green before promoting
it to the main waterfall.

BUG= chromium:677385 
TBR=ehmaldonado@chromium.org

Change-Id: I3ffc2e9825bcd0f0422055f9073cafee6eaa6dc2
Reviewed-on: https://chromium-review.googlesource.com/423054
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

[modify] https://crrev.com/64bc2179ba6df47a1b624c7fc13910e1b64a951f/masters/master.client.webrtc.fyi/master_mac_cfg.py
[modify] https://crrev.com/64bc2179ba6df47a1b624c7fc13910e1b64a951f/masters/master.client.webrtc.fyi/slaves.cfg
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/569dafdce6d6ed87ebd21a54b2c993c206fe62f8

commit 569dafdce6d6ed87ebd21a54b2c993c206fe62f8
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Fri Dec 30 06:50:21 2016

WebRTC: Promote iOS simulator bot using iOS 9 to main waterfall.

This bot has proven to run green in the client.webrtc.fyi waterfall.
Rename the other bots to match the new one.

MB and JSON changes in the src repo: https://codereview.webrtc.org/2601353003/

BUG= chromium:677385 
TBR=ehmaldonado@webrtc.org

Change-Id: I808ea4157fad9797a1d61f70e41203dfe836842b
Reviewed-on: https://chromium-review.googlesource.com/423055
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

[modify] https://crrev.com/569dafdce6d6ed87ebd21a54b2c993c206fe62f8/masters/master.client.webrtc.fyi/master_mac_cfg.py
[modify] https://crrev.com/569dafdce6d6ed87ebd21a54b2c993c206fe62f8/masters/master.client.webrtc.fyi/slaves.cfg
[modify] https://crrev.com/569dafdce6d6ed87ebd21a54b2c993c206fe62f8/masters/master.client.webrtc/master_mac_cfg.py
[modify] https://crrev.com/569dafdce6d6ed87ebd21a54b2c993c206fe62f8/masters/master.client.webrtc/slaves.cfg
[modify] https://crrev.com/569dafdce6d6ed87ebd21a54b2c993c206fe62f8/masters/master.tryserver.webrtc/master.cfg
[modify] https://crrev.com/569dafdce6d6ed87ebd21a54b2c993c206fe62f8/masters/master.tryserver.webrtc/slaves.cfg

Comment 8 by kjellander@chromium.org, Dec 30 2016

Status: Fixed (was: Assigned)
This work is now completed and we have iOS 9.0 covered on the simulators as well as renamed the old ones to make it obvious which one builds what.

Notice we also get coverage on iPhone 5, since I picked that devices for the 32-bit iOS 9.0 bot config.

Comment 9 by ehmaldonado@chromium.org, Jan 2 2017 

lgtm :)
►

Sign in to add a comment