New issue
Advanced search Search tips

Issue 677380 link

Starred by 2 users
Status: Fixed
Owner:
ehmaldonado@chromium.org
Closed: Sep 2017
Cc:
oprypin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Feature

Blocked on:
issue webrtc:7565
Blocking:
issue 497757



Sign in to add a comment

Replace Windows SyzyASan with Clang ASan

Project Member Reported by kjellander@chromium.org, Dec 29 2016 
Our Win SyzyASan bot have rarely (never?) caught any Windows-specific bugs. After doing some research I've found that Chromium doesn't have a single bot that runs tests with this tool anymore, there's only Chrome builds with it enabled (I assume for gathering data from Chrome instances running in the wild).

Since it's the last bot to be migrated to Swarming, let's stop using SyzyASan and explore using Clang ASan on Windows instead.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/7a7da3c6c1cc6856d8b21c72f21c99ac01232521

commit 7a7da3c6c1cc6856d8b21c72f21c99ac01232521
Author: Henrik Kjellander <kjellander@webrtc.org>
Date: Thu Dec 29 06:54:55 2016

MB: Replace Win SyzyASan bot with a Clang ASan bot in client.webrtc.fyi

BUG= chromium:677380 
TBR=ehmaldonado@webrtc.org

Review-Url: https://codereview.webrtc.org/2609513002 .
Cr-Commit-Position: refs/heads/master@{#15827}

[modify] https://crrev.com/7a7da3c6c1cc6856d8b21c72f21c99ac01232521/tools-webrtc/mb/mb_config.pyl
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/31044e7db37484187e47db36cbaff5e99bb7b4e5

commit 31044e7db37484187e47db36cbaff5e99bb7b4e5
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Thu Dec 29 06:57:03 2016

WebRTC: Change SyzyASan to Clang ASan in client.webrtc.fyi

Hopefully we can bring this up to green and replace SyzyASan
in the main waterfall.

BUG= 677380 
TBR=ehmaldonado@chromium.org

Change-Id: Iab9c6f7162f75347a01a40768d16c9c67fe09ccd
Reviewed-on: https://chromium-review.googlesource.com/423031
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

[modify] https://crrev.com/31044e7db37484187e47db36cbaff5e99bb7b4e5/scripts/slave/recipe_modules/webrtc/builders.py
[rename] https://crrev.com/31044e7db37484187e47db36cbaff5e99bb7b4e5/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win32_asan__swarming_.json
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/20b3fa7491036d4b9dc85d3f89ca81e5e4ce0ba8

commit 20b3fa7491036d4b9dc85d3f89ca81e5e4ce0ba8
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Thu Dec 29 07:08:19 2016

WebRTC: Rename Win SyzyASan bot in client.webrtc.fyi

This is the master config changes for
https://chromium-review.googlesource.com/c/423031/

BUG= 677380 
TBR=ehmaldonado@chromium.org

Change-Id: I91e14c1c53b7cce1f6f120d8144d3c89b86cf871
Reviewed-on: https://chromium-review.googlesource.com/424392
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

[modify] https://crrev.com/20b3fa7491036d4b9dc85d3f89ca81e5e4ce0ba8/masters/master.client.webrtc.fyi/master_win_cfg.py
[modify] https://crrev.com/20b3fa7491036d4b9dc85d3f89ca81e5e4ce0ba8/masters/master.client.webrtc.fyi/slaves.cfg
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/34203b4255757c87fc3586f3a18412f8adf4bc35

commit 34203b4255757c87fc3586f3a18412f8adf4bc35
Author: Henrik Kjellander <kjellander@webrtc.org>
Date: Thu Dec 29 09:45:08 2016

MB: Add symbol_level=2 to new Win ASan bot.

Hopefully that will give better error traces than just a memory
address upon failure.

BUG= chromium:677380 
TBR=ehmaldonado@webrtc.org

Review-Url: https://codereview.webrtc.org/2604163002 .
Cr-Commit-Position: refs/heads/master@{#15830}

[modify] https://crrev.com/34203b4255757c87fc3586f3a18412f8adf4bc35/tools-webrtc/mb/mb_config.pyl

Comment 5 by kjellander@chromium.org, May 3 2017

Labels: -Pri-3 Pri-2
Owner: ehmaldonado@chromium.org
Edward, would you mind taking a stab at this? It would be since to phase out that old SyzyASan that doesn't provide any value and has a few special cases in the recipes.
I also think we'll be able to benefit from Clang ASan finding undiscovered bugs.

Comment 6 by ehmaldonado@chromium.org, May 3 2017 

Will do.

Comment 8 by ehmaldonado@webrtc.org, May 3 2017

Blockedon: webrtc:7565
Project Member

Comment 9 by bugdroid1@chromium.org, May 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/642b0f8ffd269065c1f638d3c116b14e18a2eb82

commit 642b0f8ffd269065c1f638d3c116b14e18a2eb82
Author: ehmaldonado <ehmaldonado@webrtc.org>
Date: Wed May 03 20:05:57 2017

Fix GN errors for Win ASan bots.

BUG= chromium:677380 
NOTRY=True
TBR=kjellander@webrtc.org

Review-Url: https://codereview.webrtc.org/2858923002
Cr-Commit-Position: refs/heads/master@{#18003}

[modify] https://crrev.com/642b0f8ffd269065c1f638d3c116b14e18a2eb82/tools-webrtc/mb/mb_config.pyl
Project Member

Comment 10 by bugdroid1@chromium.org, May 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/fa6566763ff505e21cb7a012ae31b363dc08aad6

commit fa6566763ff505e21cb7a012ae31b363dc08aad6
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Mon May 08 18:34:42 2017

Promote Win32 ASan to the main waterfall and remove Win SyzyASan.

Bug: chromium:677380 
Change-Id: If2e3df56375f20adeb0267456234fb8edcdf8b96
Reviewed-on: https://chromium-review.googlesource.com/498907
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/fa6566763ff505e21cb7a012ae31b363dc08aad6/masters/master.client.webrtc/master_win_cfg.py
[rename] https://crrev.com/fa6566763ff505e21cb7a012ae31b363dc08aad6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_asan.json
[modify] https://crrev.com/fa6566763ff505e21cb7a012ae31b363dc08aad6/masters/master.client.webrtc.fyi/slaves.cfg
[modify] https://crrev.com/fa6566763ff505e21cb7a012ae31b363dc08aad6/scripts/slave/recipe_modules/webrtc/builders.py
[modify] https://crrev.com/fa6566763ff505e21cb7a012ae31b363dc08aad6/masters/master.client.webrtc.fyi/master_win_cfg.py
[modify] https://crrev.com/fa6566763ff505e21cb7a012ae31b363dc08aad6/scripts/slave/recipes/webrtc/standalone.py
[delete] https://crrev.com/577ed8c48dcad41653d0559a119abbb84f461afe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win_syzyasan.json
[modify] https://crrev.com/fa6566763ff505e21cb7a012ae31b363dc08aad6/masters/master.client.webrtc/slaves.cfg
Project Member

Comment 11 by bugdroid1@chromium.org, May 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/fa6566763ff505e21cb7a012ae31b363dc08aad6

commit fa6566763ff505e21cb7a012ae31b363dc08aad6
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Mon May 08 18:34:42 2017

Promote Win32 ASan to the main waterfall and remove Win SyzyASan.

Bug: chromium:677380 
Change-Id: If2e3df56375f20adeb0267456234fb8edcdf8b96
Reviewed-on: https://chromium-review.googlesource.com/498907
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/fa6566763ff505e21cb7a012ae31b363dc08aad6/masters/master.client.webrtc/master_win_cfg.py
[rename] https://crrev.com/fa6566763ff505e21cb7a012ae31b363dc08aad6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_asan.json
[modify] https://crrev.com/fa6566763ff505e21cb7a012ae31b363dc08aad6/masters/master.client.webrtc.fyi/slaves.cfg
[modify] https://crrev.com/fa6566763ff505e21cb7a012ae31b363dc08aad6/scripts/slave/recipe_modules/webrtc/builders.py
[modify] https://crrev.com/fa6566763ff505e21cb7a012ae31b363dc08aad6/masters/master.client.webrtc.fyi/master_win_cfg.py
[modify] https://crrev.com/fa6566763ff505e21cb7a012ae31b363dc08aad6/scripts/slave/recipes/webrtc/standalone.py
[delete] https://crrev.com/577ed8c48dcad41653d0559a119abbb84f461afe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win_syzyasan.json
[modify] https://crrev.com/fa6566763ff505e21cb7a012ae31b363dc08aad6/masters/master.client.webrtc/slaves.cfg
Project Member

Comment 12 by bugdroid1@chromium.org, May 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/9ec47b1e9264d6d95921cd96cc72f87e5f29144e

commit 9ec47b1e9264d6d95921cd96cc72f87e5f29144e
Author: Henrik Kjellander <kjellander@webrtc.org>
Date: Tue May 09 09:09:04 2017

MB: Add Win32 ASan bot and remove download of SyzyASan binaries.

BUG= chromium:677380 
TBR=ehmaldonado@webrtc.org

Review-Url: https://codereview.webrtc.org/2870883002 .
Cr-Commit-Position: refs/heads/master@{#18062}

[modify] https://crrev.com/9ec47b1e9264d6d95921cd96cc72f87e5f29144e/DEPS
[modify] https://crrev.com/9ec47b1e9264d6d95921cd96cc72f87e5f29144e/tools_webrtc/mb/mb_config.pyl
Project Member

Comment 13 by bugdroid1@chromium.org, May 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/55dad1b9d00c626fd68fad7f45d685c96519c7af

commit 55dad1b9d00c626fd68fad7f45d685c96519c7af
Author: Henrik Kjellander <kjellander@webrtc.org>
Date: Thu May 11 10:00:54 2017

Restore Syzygy binaries in DEPS.

This is probably what causes failures on the new Win32 ASan bot.
It was removed in https://codereview.webrtc.org/2870883002/
based on the assumption it was no longer needed.

BUG= chromium:677380 
TBR=ehmaldonado@webrtc.org

Review-Url: https://codereview.webrtc.org/2872373003 .
Cr-Commit-Position: refs/heads/master@{#18095}

[modify] https://crrev.com/55dad1b9d00c626fd68fad7f45d685c96519c7af/DEPS

Comment 14 by kjellander@chromium.org, Sep 21 2017 

What shall we do with this?

Comment 15 by ehmaldonado@chromium.org, Sep 22 2017

Status: Fixed (was: Assigned)
This is fixed, right?
►

Sign in to add a comment