New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 677370 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"SubresourceFilterWithPerformanceMeasurementBrowserTest.ExpectHistogramsAreRecorded" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Dec 29 2016

Issue description

"SubresourceFilterWithPerformanceMeasurementBrowserTest.ExpectHistogramsAreRecorded" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyXQsSBUZsYWtlIlJTdWJyZXNvdXJjZUZpbHRlcldpdGhQZXJmb3JtYW5jZU1lYXN1cmVtZW50QnJvd3NlclRlc3QuRXhwZWN0SGlzdG9ncmFtc0FyZVJlY29yZGVkDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Cc: engedy@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/311f7c0a14700bd54a1ee50c3f530334579ea99d

commit 311f7c0a14700bd54a1ee50c3f530334579ea99d
Author: engedy <engedy@chromium.org>
Date: Thu Dec 29 14:46:14 2016

Prevent racey favicon loads in subresource filter browsertests.

The favicon load was at race with the page load event, which caused flakiness
in tests that verified, at page load completion time, the number of evaluated
loads recorded into histograms.

BUG= 677370 

Review-Url: https://codereview.chromium.org/2604173002
Cr-Commit-Position: refs/heads/master@{#440956}

[modify] https://crrev.com/311f7c0a14700bd54a1ee50c3f530334579ea99d/chrome/browser/subresource_filter/subresource_filter_browsertest.cc
[modify] https://crrev.com/311f7c0a14700bd54a1ee50c3f530334579ea99d/chrome/test/data/subresource_filter/frame_set.html

Comment 3 by engedy@chromium.org, Dec 29 2016

Cc: -engedy@chromium.org pkalinnikov@chromium.org
Owner: engedy@chromium.org
Status: Fixed (was: Untriaged)

Sign in to add a comment