New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 677368 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

factory: Drop autotest support

Project Member Reported by hungte@chromium.org, Dec 29 2016

Issue description

After the migration in  issue 577601 , the factory is now no longer depending on chromeos-base/autotest-factory-install and no more autotest code in toolkit / test images.

We are now ready to deprecate autotest.
 

Comment 1 by hungte@chromium.org, Jan 25 2017

Owner: yllin@chromium.org
Status: Assigned (was: Untriaged)
Temporarily assign to Nooger. yllin, you can try to see if there's something can be improved here.

Comment 2 by yllin@chromium.org, Feb 21 2017

Cc: hungte@chromium.org
Status: Started (was: Assigned)
Start to study  issue 577601 .
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/f9811615f9feb32522cf1dec6196097db0491f48

commit f9811615f9feb32522cf1dec6196097db0491f48
Author: Yilun Lin <yllin@google.com>
Date: Fri Feb 24 05:25:16 2017

goofy: Move from autotest to pytest in test_list_iterator_unittest.

BUG= chromium:677368 
TEST=make test

Change-Id: Ica7e42b4ccf783b11a735fc82ff5092ddd0d00eb
Reviewed-on: https://chromium-review.googlesource.com/446180
Commit-Ready: Yilun Lin <yllin@chromium.org>
Tested-by: Yilun Lin <yllin@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>

[modify] https://crrev.com/f9811615f9feb32522cf1dec6196097db0491f48/py/goofy/test_list_iterator_unittest.py

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/6ae5006ed230ed3162ad4a6bca0b9ef9790945dd

commit 6ae5006ed230ed3162ad4a6bca0b9ef9790945dd
Author: Yilun Lin <yllin@google.com>
Date: Wed Mar 01 06:33:47 2017

goofy: Move from autotest to pytest in goofy_unitest

BUG= chromium:677368 
TEST=make test

Change-Id: I841cf0e3df35ad40c16557eb10ff7483b0df3ad3
Reviewed-on: https://chromium-review.googlesource.com/446263
Commit-Ready: Yilun Lin <yllin@chromium.org>
Tested-by: Yilun Lin <yllin@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>

[modify] https://crrev.com/6ae5006ed230ed3162ad4a6bca0b9ef9790945dd/py/goofy/goofy_unittest.py

During the fixing of goofy_unittest running time issue (b/32721371), I found there is many unnecessary complicated dependency between invocation.py and goofy.py (both of them use properties of each other), possibly due to original support of autotest.

Currently the calling path for a test is something like:
goofy -> invocation -> goofy -> autotest_prespawner/pytest_prespawner

When it is pytest_prespawner, the call is actually back to invocation again: (pytest_prespawner is invocation itself)
goofy -> invocation -> goofy -> pytest_prespawner -> invocation (spawn)

If we remove autotest_prespawner, I think we can just drop the layer of prespawner here, so it becomes:
goofy -> invocation -> invocation (spawn)

By doing this, we can define the role more clearly:
goofy: scheduling tests, and run invocation.
invocation: handle the spawn of pytest.

Then we can finally have unittest for invocation. This will further reduce the testing time for goofy_unittest. (Currently goofy_unittest takes about 45s on non-SSD machine, still pretty slow compared to other unittests in our repo), and make the code clear.

What do you think?
Cc: shunhsingou@chromium.org

Comment 7 by hungte@chromium.org, Mar 16 2017

Totally fine. Just drop it.
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/b45b3c8e4e788d7d505935d6d897ea84820080f0

commit b45b3c8e4e788d7d505935d6d897ea84820080f0
Author: Yilun Lin <yllin@google.com>
Date: Mon Mar 20 07:44:58 2017

test_list: Replace autotest hardware_SAT with pytest stressapptest.

Deprecate autotest.
Set StressAppTest free_memory_only default to true.

BUG= chromium:677368 
TEST=make overlay-chell; check `overlay-chell/bin/factory dump-test-list`

Change-Id: Icaf13b3c40d37f8fc3ee6f6969f5be1ab70707b8
Reviewed-on: https://chromium-review.googlesource.com/456977
Commit-Ready: Yilun Lin <yllin@chromium.org>
Tested-by: Yilun Lin <yllin@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Shun-Hsing Ou <shunhsingou@chromium.org>

[modify] https://crrev.com/b45b3c8e4e788d7d505935d6d897ea84820080f0/py/test/pytests/stressapptest.py
[modify] https://crrev.com/b45b3c8e4e788d7d505935d6d897ea84820080f0/py/test/test_lists/generic_rrt.py
[modify] https://crrev.com/b45b3c8e4e788d7d505935d6d897ea84820080f0/py/test/test_lists/firmware_stress_generic.py
[modify] https://crrev.com/b45b3c8e4e788d7d505935d6d897ea84820080f0/py/test/test_lists/generic_run_in.py
[modify] https://crrev.com/b45b3c8e4e788d7d505935d6d897ea84820080f0/py/test/test_lists/generic_smt.py

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/3348598ee6be78df2c8524b509f9f0bee37d8faf

commit 3348598ee6be78df2c8524b509f9f0bee37d8faf
Author: Yilun Lin <yllin@google.com>
Date: Tue Mar 21 08:17:22 2017

test: Deprecate autotest.

CQ-DEPEND=CL:456724
BUG= chromium:677368 
TEST=make test

Change-Id: Ic4ee6c313b2b5714fd5651408075b0440ebfd29c
Reviewed-on: https://chromium-review.googlesource.com/456665
Commit-Ready: Yilun Lin <yllin@chromium.org>
Tested-by: Yilun Lin <yllin@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>

[modify] https://crrev.com/3348598ee6be78df2c8524b509f9f0bee37d8faf/py/test/factory.py
[modify] https://crrev.com/3348598ee6be78df2c8524b509f9f0bee37d8faf/py/test/test_lists/test_lists.py
[delete] https://crrev.com/b10e8cfe0742f5b6634df1919b319aa73cd5f0c5/py/test/autotest_common.py

Status: Fixed (was: Started)
Labels: VerifyIn-61

Comment 14 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment