New issue
Advanced search Search tips

Issue 677364 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Feature



Sign in to add a comment

Implement NavigationManager::Reload() without requiring a web delegate.

Project Member Reported by kkhorimoto@chromium.org, Dec 29 2016

Issue description

The current implementation of NavigationManager::Reload() goes through WebStateImpl::OpenURL(), which in turn calls the web delegate's |-openURLWithParams:|.  The web layer should handle reloads internally, as the web::WebState::OpenURLParams::disposition logic in [Tab openURLWithParams:| is not necessary for reloads since it will always occur in the same Tab.
 
Additionally, the |check_for_repost| parameter is unused and should be removed.
I would add that NavigationManager::Reload should call [WKWebView reload] to avoid messing up with WKBackForwardNavigationList. This can be piped as follows: NavigationManagerDelegate -> WebStateImpl -> CRWWebController.
Components: -Mobile>WebView>Glue UI>Browser>Navigation
Labels: -Type-Bug Type-Feature
Status: Fixed (was: Assigned)
This is already done

Sign in to add a comment