ffmpeg omits stack pointers even on debug + profiling builds |
|||||
Issue descriptionhttps://cs.chromium.org/chromium/src/third_party/ffmpeg/BUILD.gn?q=omit-frame-pointer+file:gn$&sq=package:chromium&l=232&dr=C For verification see out/gn/obj/third_party/ffmpeg/ffmpeg_internal.ninja. This probably breaks heap profiling?
,
Jan 4 2017
,
Feb 15 2017
+ OWNERs for ffmpeg - is ffmpeg non-functional with -fno-emit-frame-pointers, or is this code just a performance optimization? The only time "default_stack_frames" throws in "-fno-omit-frame-pointer" is using_sanitizer || enable_profiling || is_debug || current_cpu == "arm64" We care about the enable-profiling case, where we really, really want frame pointers to have fast stack walks.
,
Feb 15 2017
,
Feb 15 2017
This has been this way for as long as I've been on the team > 5 years. https://cs.chromium.org/chromium/src/third_party/ffmpeg/BUILD.gn?l=204 explains why; and I have verified that statement in the past; though not recently (~3 years). In the past playback has been unacceptably slow for software decoded video. Linux has no hardware decode so would be most affected, other platforms would probably be fine since we'd either be using the hardware decoder for h264 decoding or libvpx (which may have similar exclusions to ffmpeg). Some of the code may not even compile without this flag due to register pressure, but feel free to experiment and see what happens.
,
Mar 9 2017
as per c#5, give to erikchen@ to experiment. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by primiano@chromium.org
, Jan 4 2017Labels: Hotlist-MemoryInfra Hotlist-GoodFirstBug OS-Linux