Also: We need to validate proxy input values and not pass bad data (e.g. incorrectly formatted urls) and/or handle bad data gracefully in the C++ code.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6acab6d4d28021d0da0a1f849bb798e5a8930662

commit 6acab6d4d28021d0da0a1f849bb798e5a8930662
Author: stevenjb <stevenjb@chromium.org>
Date: Wed Jan 04 01:18:56 2017

MD Settings: Internet: Fix Proxy UI

This CL:
* Cleans up the network-proxy HTML and JS files
* Adds a 'Save' button for configuring manual proxy configurations
  since a partial configuration might be invalid.
* Prevents updates from overwriting in-progress manual config changes.
* Fixes the mechanism for saving other proxy configurations also.
* Fixes logic determining when fields are editable.

BUG= 677357 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2605373002
Cr-Commit-Position: refs/heads/master@{#441276}

[modify] https://crrev.com/6acab6d4d28021d0da0a1f849bb798e5a8930662/chrome/browser/resources/settings/internet_page/compiled_resources2.gyp
[modify] https://crrev.com/6acab6d4d28021d0da0a1f849bb798e5a8930662/chrome/browser/resources/settings/internet_page/network_proxy.html
[modify] https://crrev.com/6acab6d4d28021d0da0a1f849bb798e5a8930662/chrome/browser/resources/settings/internet_page/network_proxy.js
[modify] https://crrev.com/6acab6d4d28021d0da0a1f849bb798e5a8930662/chrome/browser/resources/settings/internet_page/network_proxy_input.html

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8a349eb13605f30e1aa6c096f4c4ea28ba11bc9

commit a8a349eb13605f30e1aa6c096f4c4ea28ba11bc9
Author: stevenjb <stevenjb@chromium.org>
Date: Mon Jan 09 22:38:55 2017

ONC: Fix handling of invalid proxy scheme.

It is common for a proxy configuration URL to be added as 'foo.com'
instead of 'http://foo.com'. Rather than relying on all UI to
validate the input, we should do so in the ONC conversion.

BUG= 677357 

Review-Url: https://codereview.chromium.org/2608803002
Cr-Commit-Position: refs/heads/master@{#442378}

[modify] https://crrev.com/a8a349eb13605f30e1aa6c096f4c4ea28ba11bc9/chromeos/BUILD.gn
[modify] https://crrev.com/a8a349eb13605f30e1aa6c096f4c4ea28ba11bc9/chromeos/network/DEPS
[modify] https://crrev.com/a8a349eb13605f30e1aa6c096f4c4ea28ba11bc9/chromeos/network/onc/onc_utils.cc
[modify] https://crrev.com/a8a349eb13605f30e1aa6c096f4c4ea28ba11bc9/chromeos/network/onc/onc_utils_unittest.cc
[add] https://crrev.com/a8a349eb13605f30e1aa6c096f4c4ea28ba11bc9/chromeos/test/data/network/proxy_config_from_onc.json

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23a69173a82474bd2981f5f75766e37f75ebbfb0

commit 23a69173a82474bd2981f5f75766e37f75ebbfb0
Author: timloh <timloh@chromium.org>
Date: Tue Jan 10 03:00:25 2017

Revert of ONC: Fix handling of invalid proxy scheme. (patchset #4 id:60001 of https://codereview.chromium.org/2608803002/ )

Reason for revert:
The modified test is failing on Linux ChromiumOS Tests (dbg)(1)

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29

An example failure:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/21284/steps/chromeos_unittests/logs/stdio

Original issue's description:
> ONC: Fix handling of invalid proxy scheme.
>
> It is common for a proxy configuration URL to be added as 'foo.com'
> instead of 'http://foo.com'. Rather than relying on all UI to
> validate the input, we should do so in the ONC conversion.
>
> BUG= 677357 
>
> Review-Url: https://codereview.chromium.org/2608803002
> Cr-Commit-Position: refs/heads/master@{#442378}
> Committed: https://chromium.googlesource.com/chromium/src/+/a8a349eb13605f30e1aa6c096f4c4ea28ba11bc9

TBR=emaxx@chromium.org,mnissler@chromium.org,pkasting@chromium.org,stevenjb@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 677357 

Review-Url: https://codereview.chromium.org/2619803003
Cr-Commit-Position: refs/heads/master@{#442458}

[modify] https://crrev.com/23a69173a82474bd2981f5f75766e37f75ebbfb0/chromeos/BUILD.gn
[modify] https://crrev.com/23a69173a82474bd2981f5f75766e37f75ebbfb0/chromeos/network/DEPS
[modify] https://crrev.com/23a69173a82474bd2981f5f75766e37f75ebbfb0/chromeos/network/onc/onc_utils.cc
[modify] https://crrev.com/23a69173a82474bd2981f5f75766e37f75ebbfb0/chromeos/network/onc/onc_utils_unittest.cc
[delete] https://crrev.com/1297046888300e6524fd1aab198e78bf67481674/chromeos/test/data/network/proxy_config_from_onc.json

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffe695ceccba7953f426334c81915cc9eb5484ee

commit ffe695ceccba7953f426334c81915cc9eb5484ee
Author: stevenjb <stevenjb@chromium.org>
Date: Tue Jan 10 21:35:51 2017

RELAND: ONC: Fix handling of invalid proxy scheme.

Original CL: https://codereview.chromium.org/2608803002/
PS 2 fixes chromeos_unittests.

It is common for a proxy configuration URL to be added as 'foo.com'
instead of 'http://foo.com'. Rather than relying on all UI to
validate the input, we should do so in the ONC conversion.

BUG= 677357 
TBR=emaxx@chromium.org,pkasting@chromium.org

Review-Url: https://codereview.chromium.org/2619363004
Cr-Commit-Position: refs/heads/master@{#442697}

[modify] https://crrev.com/ffe695ceccba7953f426334c81915cc9eb5484ee/chromeos/BUILD.gn
[modify] https://crrev.com/ffe695ceccba7953f426334c81915cc9eb5484ee/chromeos/network/DEPS
[modify] https://crrev.com/ffe695ceccba7953f426334c81915cc9eb5484ee/chromeos/network/onc/onc_utils.cc
[modify] https://crrev.com/ffe695ceccba7953f426334c81915cc9eb5484ee/chromeos/network/onc/onc_utils_unittest.cc
[add] https://crrev.com/ffe695ceccba7953f426334c81915cc9eb5484ee/chromeos/test/data/network/proxy_config_from_onc.json