Issue metadata
Sign in to add a comment
|
analyze did not compile anything after changing src\net\cert\x509_certificate_known_roots_win.h |
||||||||||||||||||||||||
Issue descriptionIn crrev.com/2608643002 the file x509_certificate_known_roots_win.h was modified. This file is compiled into chrome.dll but the analyze step decided that it was not important so it declined to compile anything, saying "No compile necessary" This is obviously dangerous. I'm not clear on how mb.py analyze figures out what header files matter but it is a fairly straightforward trip from src\net\cert\x509_certificate_known_roots_win.h to src\net\cert\cert_verify_proc_win.cc to net_non_nacl_sources in net.gypi to component("net"). Any ideas on why mb.py didn't notice this?
,
Dec 29 2016
Yup. And, unfortunately, there appear to be a lot of missing headers at the moment. See bug 661774.
,
Dec 29 2016
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by brucedaw...@chromium.org
, Dec 29 2016