New issue
Advanced search Search tips

Issue 677355 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 661774
Owner: ----
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

analyze did not compile anything after changing src\net\cert\x509_certificate_known_roots_win.h

Project Member Reported by brucedaw...@chromium.org, Dec 29 2016

Issue description

In crrev.com/2608643002 the file x509_certificate_known_roots_win.h was modified. This file is compiled into chrome.dll but the analyze step decided that it was not important so it declined to compile anything, saying "No compile necessary"

This is obviously dangerous.

I'm not clear on how mb.py analyze figures out what header files matter but it is a fairly straightforward trip from src\net\cert\x509_certificate_known_roots_win.h to src\net\cert\cert_verify_proc_win.cc to net_non_nacl_sources in net.gypi to component("net").

Any ideas on why mb.py didn't notice this?

 
cert/x509_certificate_known_roots_win.h is missing from net_non_nacl_sources in net.gypi. I can add. I hadn't realized that analyze depended on having a complete list of header files.
Yup. And, unfortunately, there appear to be a lot of missing headers at the moment. See bug 661774.
Mergedinto: 661774
Status: Duplicate (was: Untriaged)

Sign in to add a comment