New issue
Advanced search Search tips

Issue 677347 link

Starred by 1 user
Status: Fixed
Owner:
m...@chromium.org
Closed: Jan 2017
Cc:
guidou@chromium.org
niklase@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Tab Capture video freezes if tab crashes, does not restore on navigation

Project Member Reported by m...@chromium.org, Dec 28 2016 
Repro steps:

1. Launch tab capture.
2. On the target tab, navigate to chrome://crash (to crash the renderer intentionally).
3. Navigate to a new URL.

Observed:

Tab captures content before the crash. Then, no additional video frames are emmitted.

Expected:

After navigation, tab content capture should resume. Ideally, tab capture would also capture the crash screen's content.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/418dd6327b1241f4b667c54051ab2894c64c07a9

commit 418dd6327b1241f4b667c54051ab2894c64c07a9
Author: miu <miu@chromium.org>
Date: Tue Jan 03 22:16:45 2017

Tab capture: Tracking continues after renderer crash.

Fixes a bug where tab capture would freeze whenever the renderer
crashes, and would not resume capturing after navigating to a new page.
There were a number of causes, all of which amounted to:

1. Having WebContentsTracker observe an extra event, RenderFrameCreated.
2. Having WebContentsTracker report on changes to RenderWidgetHostView
   instead of just RenderWidgetHost.
3. Correcting an incorrect assumption: Tracking should not halt just
   because a RenderWidgetHost lacks a view. Intsead, it is the
   destruction of the WebContents that should cause tracking to halt.

BUG= 677347 

Review-Url: https://codereview.chromium.org/2602923002
Cr-Commit-Position: refs/heads/master@{#441221}

[modify] https://crrev.com/418dd6327b1241f4b667c54051ab2894c64c07a9/content/browser/media/capture/web_contents_tracker.cc
[modify] https://crrev.com/418dd6327b1241f4b667c54051ab2894c64c07a9/content/browser/media/capture/web_contents_tracker.h
[modify] https://crrev.com/418dd6327b1241f4b667c54051ab2894c64c07a9/content/browser/media/capture/web_contents_video_capture_device.cc

Comment 2 by m...@chromium.org, Jan 10 2017

Status: Fixed (was: Started)
►

Sign in to add a comment