New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 677338 link

Starred by 4 users
Status: Available
Owner: ----
Cc:
lucmult@chromium.org
█ groby@chromium.org
dbeam@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocked on:
issue 923206


Sign in to add a comment

Replace i18n-content and i18n-values with $i18n{}

Project Member Reported by dschuyler@chromium.org, Dec 28 2016 
The JavaScript i18n parser uses i18n-content and i18n-values to perform i18n. We are using a newer template replacement system that uses $i18n{} to replace values in C++ (which is much faster). The plan is to phase out the old i18n-* replacement.

These changes only affect webui and shared resources, such as chrome://settings, chrome://downloads, the new tab page and similar 'build-in' pages. (Not pages downloaded in the normal way).
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe6f5905169ab6f89e7a84a69358269686a8274b

commit fe6f5905169ab6f89e7a84a69358269686a8274b
Author: dschuyler <dschuyler@chromium.org>
Date: Thu Jan 05 01:10:08 2017

[MD settings] i18n template replacements in shared HTML resources

This CL unifies the DictionaryValue to TemplateReplacements and provides
for $i18n{} replacements in shared resources. This CL doesn't include
the html changes to convert i18n-* to $i18n{} replacements. This is so
that those changes (which may be large) can be mechanical replacements
only (without these code changs).

BUG=677338

Review-Url: https://codereview.chromium.org/2607843002
Cr-Commit-Position: refs/heads/master@{#441540}

[modify] https://crrev.com/fe6f5905169ab6f89e7a84a69358269686a8274b/chrome/browser/ui/webui/options/options_ui.cc
[modify] https://crrev.com/fe6f5905169ab6f89e7a84a69358269686a8274b/content/browser/webui/web_ui_data_source_impl.cc
[modify] https://crrev.com/fe6f5905169ab6f89e7a84a69358269686a8274b/ui/base/template_expressions.cc
[modify] https://crrev.com/fe6f5905169ab6f89e7a84a69358269686a8274b/ui/base/template_expressions.h
[modify] https://crrev.com/fe6f5905169ab6f89e7a84a69358269686a8274b/ui/base/webui/jstemplate_builder.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73fbd9b3b88c3f8b73230861924e6e680231fcbf

commit 73fbd9b3b88c3f8b73230861924e6e680231fcbf
Author: dschuyler <dschuyler@chromium.org>
Date: Thu Jan 12 03:51:52 2017

[i18n] browser help, i18n-content to $i18n{}

This is a mechanical change to convert i18n-content to $i18n{} tags.

BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2626083005
Cr-Commit-Position: refs/heads/master@{#443140}

[modify] https://crrev.com/73fbd9b3b88c3f8b73230861924e6e680231fcbf/chrome/browser/resources/help/channel_change_page.html
[modify] https://crrev.com/73fbd9b3b88c3f8b73230861924e6e680231fcbf/chrome/browser/resources/help/help.html
[modify] https://crrev.com/73fbd9b3b88c3f8b73230861924e6e680231fcbf/chrome/browser/resources/help/help_content.html
[modify] https://crrev.com/73fbd9b3b88c3f8b73230861924e6e680231fcbf/chrome/browser/resources/help/help_page.html
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9dfcececdc896dd4be4d516de61d7f8bceebea99

commit 9dfcececdc896dd4be4d516de61d7f8bceebea99
Author: dschuyler <dschuyler@chromium.org>
Date: Thu Jan 12 19:40:58 2017

[i18n] chromeos login i18n-content to $i18n{}

This is a semi-mechanical change to convert i18n-content to $i18n{}. The
Non-mechancal changes are some formatting adjustments.

BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2626123002
Cr-Commit-Position: refs/heads/master@{#443327}

[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/accessibility_menu.css
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/accessibility_menu.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/api_keys_notice.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/controller-pairing-screen.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/controller-pairing-screen.js
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/controller_pairing_page.css
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/demo_user_login.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/gaia_buttons.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/gaia_buttons.js
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/gaia_card.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/gaia_header.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/gaia_input.css
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/gaia_input.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/gaia_input.js
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/gaia_input_form.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/gaia_password_changed.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/header_bar.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/host-pairing-screen.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/html-echo.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/lock.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/login.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/offline_gaia.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/oobe.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/oobe_buttons.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/oobe_eula.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/oobe_hid_detection.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/oobe_screen_auto_enrollment_check.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/oobe_screen_autolaunch.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/oobe_screen_enable_debugging.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/oobe_screen_enable_kiosk.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/oobe_screen_eula.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/oobe_screen_eula_installation_settings_overlay.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/oobe_screen_network.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/oobe_screen_reset.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/oobe_screen_reset_confirmation_overlay.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/oobe_screen_terms_of_service.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/oobe_screen_update.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/oobe_screen_user_image.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/oobe_update.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/oobe_welcome.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/saml_confirm_password.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/saml_interstitial.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/screen_app_launch_splash.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/screen_device_disabled.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/screen_error_message.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/screen_tpm_error.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/screen_wrong_hwid.html
[modify] https://crrev.com/9dfcececdc896dd4be4d516de61d7f8bceebea99/chrome/browser/resources/chromeos/login/unrecoverable_cryptohome_error_card.html

Comment 6 by dbeam@chromium.org, Jan 13 2017

Cc: groby@chromium.org dbeam@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/900b07d425120a680d173ee841d0c7dcc75180a2

commit 900b07d425120a680d173ee841d0c7dcc75180a2
Author: dschuyler <dschuyler@chromium.org>
Date: Wed Jan 25 03:51:26 2017

Revert of [i18n] chromeos first run, i18n-content to $i18n{} (patchset #1 id:1 of https://codereview.chromium.org/2625873006/ )

Reason for revert:
This CL appears to have brought about this issue:
https://bugs.chromium.org/p/chromium/issues/detail?id=684654&q=owner%3Ame&colspec=ID%20Pri%20M%20Stars%20ReleaseBlock%20Component%20Status%20Owner%20Summary%20OS%20Modified

I'd like to revert this as a quick fix and then look into the issue further at a later time.

Original issue's description:
> [i18n] chromeos first run, i18n-content to $i18n{}
>
> This is a mechanical change to convert i18n-content to $i18n{} tags.
>
> BUG=677338
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2625873006
> Cr-Commit-Position: refs/heads/master@{#443108}
> Committed: https://chromium.googlesource.com/chromium/src/+/2b7b8dafe5412ef81b6c4755bdbf700bd55d138a

TBR=tommycli@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=677338

Review-Url: https://codereview.chromium.org/2653123003
Cr-Commit-Position: refs/heads/master@{#445935}

[modify] https://crrev.com/900b07d425120a680d173ee841d0c7dcc75180a2/chrome/browser/resources/chromeos/first_run/app/main.html
[modify] https://crrev.com/900b07d425120a680d173ee841d0c7dcc75180a2/chrome/browser/resources/chromeos/first_run/app_list_step.html
[modify] https://crrev.com/900b07d425120a680d173ee841d0c7dcc75180a2/chrome/browser/resources/chromeos/first_run/help_step.html
[modify] https://crrev.com/900b07d425120a680d173ee841d0c7dcc75180a2/chrome/browser/resources/chromeos/first_run/tray_step.html
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 9 2017

Labels: merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eaa2be3f1602ee488a796d9d55522d2b690f1500

commit eaa2be3f1602ee488a796d9d55522d2b690f1500
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Thu Feb 09 20:44:03 2017

Revert of [i18n] chromeos first run, i18n-content to $i18n{} (patchset #1 id:1 of https://codereview.chromium.org/2625873006/ )

Reason for revert:
This CL appears to have brought about this issue:
https://bugs.chromium.org/p/chromium/issues/detail?id=684654&q=owner%3Ame&colspec=ID%20Pri%20M%20Stars%20ReleaseBlock%20Component%20Status%20Owner%20Summary%20OS%20Modified

I'd like to revert this as a quick fix and then look into the issue further at a later time.

Original issue's description:
> [i18n] chromeos first run, i18n-content to $i18n{}
>
> This is a mechanical change to convert i18n-content to $i18n{} tags.
>
> BUG=677338
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2625873006
> Cr-Commit-Position: refs/heads/master@{#443108}
> Committed: https://chromium.googlesource.com/chromium/src/+/2b7b8dafe5412ef81b6c4755bdbf700bd55d138a

TBR=tommycli@chromium.org
BUG=677338

Review-Url: https://codereview.chromium.org/2653123003
Cr-Commit-Position: refs/heads/master@{#445935}
(cherry picked from commit 900b07d425120a680d173ee841d0c7dcc75180a2)

Review-Url: https://codereview.chromium.org/2681863006 .
Cr-Commit-Position: refs/branch-heads/2987@{#416}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/eaa2be3f1602ee488a796d9d55522d2b690f1500/chrome/browser/resources/chromeos/first_run/app/main.html
[modify] https://crrev.com/eaa2be3f1602ee488a796d9d55522d2b690f1500/chrome/browser/resources/chromeos/first_run/app_list_step.html
[modify] https://crrev.com/eaa2be3f1602ee488a796d9d55522d2b690f1500/chrome/browser/resources/chromeos/first_run/help_step.html
[modify] https://crrev.com/eaa2be3f1602ee488a796d9d55522d2b690f1500/chrome/browser/resources/chromeos/first_run/tray_step.html
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f21fb41278cc936a74fa33148ca01d394dd54a9

commit 8f21fb41278cc936a74fa33148ca01d394dd54a9
Author: dschuyler <dschuyler@chromium.org>
Date: Wed Feb 15 19:18:12 2017

Revert of [i18n] chromeos login i18n-content to $i18n{} (patchset #4 id:80001 of https://codereview.chromium.org/2626123002/ )

Reason for revert:
crbug/691904 reports that when changing the language, the pages are not redrawn in the newly selected language. This CL is not critical to get into M-57 so I'm reverting it to get a M-57 working asap. I can look into it further for a later milestone.

Original issue's description:
> [i18n] chromeos login i18n-content to $i18n{}
>
> This is a semi-mechanical change to convert i18n-content to $i18n{}. The
> Non-mechancal changes are some formatting adjustments.
>
> BUG=677338
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2626123002
> Cr-Commit-Position: refs/heads/master@{#443327}
> Committed: https://chromium.googlesource.com/chromium/src/+/9dfcececdc896dd4be4d516de61d7f8bceebea99

TBR=tommycli@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 691904 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2694353002
Cr-Commit-Position: refs/heads/master@{#450762}

[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/accessibility_menu.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/api_keys_notice.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/arc_terms_of_service.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/controller-pairing-screen.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/demo_user_login.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/gaia_password_changed.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/header_bar.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/host-pairing-screen.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/lock.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/login.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/offline_gaia.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_buttons.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_eula.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_hid_detection.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_screen_auto_enrollment_check.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_screen_autolaunch.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_screen_enable_debugging.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_screen_enable_kiosk.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_screen_eula.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_screen_eula_installation_settings_overlay.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_screen_network.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_screen_reset.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_screen_reset_confirmation_overlay.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_screen_terms_of_service.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_screen_update.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_screen_user_image.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_update.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_welcome.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/saml_confirm_password.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/saml_interstitial.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/screen_app_launch_splash.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/screen_device_disabled.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/screen_error_message.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/screen_tpm_error.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/screen_wrong_hwid.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/unrecoverable_cryptohome_error_card.html
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c44008f48f84975c104f58b54765a3b687c74b22

commit c44008f48f84975c104f58b54765a3b687c74b22
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Fri Feb 24 01:14:12 2017

Revert of [i18n] chromeos login i18n-content to $i18n{} (patchset #4 id:80001 of https://codereview.chromium.org/2626123002/ )

Reason for revert:
crbug/691904 reports that when changing the language, the pages are not redrawn in the newly selected language. This CL is not critical to get into M-57 so I'm reverting it to get a M-57 working asap. I can look into it further for a later milestone.

Original issue's description:
> [i18n] chromeos login i18n-content to $i18n{}
>
> This is a semi-mechanical change to convert i18n-content to $i18n{}. The
> Non-mechancal changes are some formatting adjustments.
>
> BUG=677338
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2626123002
> Cr-Commit-Position: refs/heads/master@{#443327}
> Committed: https://chromium.googlesource.com/chromium/src/+/9dfcececdc896dd4be4d516de61d7f8bceebea99

TBR=tommycli@chromium.org
BUG= 691904 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2694353002
Cr-Commit-Position: refs/heads/master@{#450762}
(cherry picked from commit 8f21fb41278cc936a74fa33148ca01d394dd54a9)

Review-Url: https://codereview.chromium.org/2718563003 .
Cr-Commit-Position: refs/branch-heads/2987@{#673}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/accessibility_menu.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/api_keys_notice.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/controller-pairing-screen.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/demo_user_login.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/gaia_password_changed.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/header_bar.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/host-pairing-screen.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/lock.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/login.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/offline_gaia.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_buttons.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_eula.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_hid_detection.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_screen_auto_enrollment_check.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_screen_autolaunch.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_screen_enable_debugging.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_screen_enable_kiosk.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_screen_eula.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_screen_eula_installation_settings_overlay.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_screen_network.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_screen_reset.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_screen_reset_confirmation_overlay.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_screen_terms_of_service.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_screen_update.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_screen_user_image.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_update.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_welcome.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/saml_confirm_password.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/saml_interstitial.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/screen_app_launch_splash.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/screen_device_disabled.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/screen_error_message.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/screen_tpm_error.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/screen_wrong_hwid.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/unrecoverable_cryptohome_error_card.html

Comment 11 by dbeam@chromium.org, Apr 18 2017

Cc: dpa...@chromium.org
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4945caaf823ee78599bf3936bc31963373edc36e

commit 4945caaf823ee78599bf3936bc31963373edc36e
Author: dbeam <dbeam@chromium.org>
Date: Tue Apr 18 19:06:46 2017

Convert Guest New Tab page from i18n-* (JS) to use $i18n{} (C++)

R=dschuyler@chromium.org
BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2823843006
Cr-Commit-Position: refs/heads/master@{#465315}

[modify] https://crrev.com/4945caaf823ee78599bf3936bc31963373edc36e/chrome/browser/resources/ntp4/guest_tab.html
[modify] https://crrev.com/4945caaf823ee78599bf3936bc31963373edc36e/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
Project Member

Comment 14 by bugdroid1@chromium.org, May 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adacb0cb737686f68282011b4a77f50a21f9d6dd

commit adacb0cb737686f68282011b4a77f50a21f9d6dd
Author: dschuyler <dschuyler@chromium.org>
Date: Wed May 10 21:08:20 2017

[i18n] convert media-internals page to $i18n

This CL changes the internal chrome://media-internals page from using
the older i18n-content/values to $i18n. Note that much of this internal
page is not localized (I believe that it is not intended for common use).

BUG=677338

Review-Url: https://codereview.chromium.org/2866203002
Cr-Commit-Position: refs/heads/master@{#470705}

[modify] https://crrev.com/adacb0cb737686f68282011b4a77f50a21f9d6dd/content/browser/resources/media/media_internals.html
Project Member

Comment 15 by bugdroid1@chromium.org, May 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c714b929856634f69e66588db294ccb8b785ad25

commit c714b929856634f69e66588db294ccb8b785ad25
Author: dschuyler <dschuyler@chromium.org>
Date: Thu May 11 00:07:18 2017

[i18n] dir header i18n-content/values to $i18n

This CL changes the directory listing header from using the older
i18n-content and i18n-values to the faster $i18n localization code. The
resulting UI looks the same.

BUG=677338

Review-Url: https://codereview.chromium.org/2867683003
Cr-Commit-Position: refs/heads/master@{#470759}

[modify] https://crrev.com/c714b929856634f69e66588db294ccb8b785ad25/net/base/dir_header.html
Project Member

Comment 16 by bugdroid1@chromium.org, May 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd1fe22c153c500c60ffd85cb32eb6576e8ea1ad

commit fd1fe22c153c500c60ffd85cb32eb6576e8ea1ad
Author: dschuyler <dschuyler@chromium.org>
Date: Tue May 16 01:14:07 2017

[MD settings] update docs to refer to $i18n

This CL updates the docs to describe how to use $i18n{} rather than
using i18n-content.

BUG=722505, 677338

Review-Url: https://codereview.chromium.org/2887503002
Cr-Commit-Position: refs/heads/master@{#471967}

[modify] https://crrev.com/fd1fe22c153c500c60ffd85cb32eb6576e8ea1ad/docs/chrome_settings.md
Project Member

Comment 17 by bugdroid1@chromium.org, May 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa4fdf26a8bb80fc51e06a3f7f8ce281fee23f35

commit aa4fdf26a8bb80fc51e06a3f7f8ce281fee23f35
Author: dschuyler <dschuyler@chromium.org>
Date: Fri May 26 18:15:20 2017

[i18n] domain reliability internals to $i18n

This Cl removes the i18n-content and i18n-values replacing them with
$i18n{} replacements. The <h1> title was removed because afaict it was
not being set and therefore empty. Side note: There is English in the
page and it appears to be an internal-only developer page, so it's
reasonable think that the i18n title wasn't being set.

BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2901383005
Cr-Commit-Position: refs/heads/master@{#475060}

[modify] https://crrev.com/aa4fdf26a8bb80fc51e06a3f7f8ce281fee23f35/chrome/browser/resources/domain_reliability_internals.html
Project Member

Comment 18 by bugdroid1@chromium.org, May 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c6d330b4952c018fd8a59df156bc3dba612a1dc

commit 6c6d330b4952c018fd8a59df156bc3dba612a1dc
Author: dschuyler <dschuyler@chromium.org>
Date: Fri May 26 19:50:53 2017

[i18n] device-log to $i18n{}

This CL removes the i18n-content and i18n-values, replacing them with
$i18n{}.

BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2907723002
Cr-Commit-Position: refs/heads/master@{#475091}

[modify] https://crrev.com/6c6d330b4952c018fd8a59df156bc3dba612a1dc/chrome/browser/resources/device_log_ui/device_log_ui.html
Project Member

Comment 19 by bugdroid1@chromium.org, Jun 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f990567a85ba8196589a67de581fa2a5b16fae3e

commit f990567a85ba8196589a67de581fa2a5b16fae3e
Author: dschuyler <dschuyler@chromium.org>
Date: Thu Jun 01 00:19:32 2017

[i18n] about-sys to $i18n{}

This CL changes i18n-content and i18n-values (the old way) to
$i18n{} (the new way).

BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2906993002
Cr-Commit-Position: refs/heads/master@{#476106}

[modify] https://crrev.com/f990567a85ba8196589a67de581fa2a5b16fae3e/chrome/browser/resources/about_sys/about_sys.html
Project Member

Comment 20 by bugdroid1@chromium.org, Jun 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ab6f1801d197cda79b2f1dbf8f81d4f8d5f4884

commit 9ab6f1801d197cda79b2f1dbf8f81d4f8d5f4884
Author: dschuyler <dschuyler@chromium.org>
Date: Fri Jun 16 01:48:57 2017

[i18n] components directory to $i18n{}

This CL changes i18n-content and i18n-value (the old way) to
$i18n{} (the new way). There should be no functionality or UI
changes apparent to the user.

TBR=stanisc@chromium.org,dbeam@chromium.org,fgorski@chromium.org,thestig@chromium.org,hirono@chromium.org,mattreynolds@chromium.org,juliatuttle@chromium.org,bengr@chromium.org,treib@chromium.org
BUG=677338

Review-Url: https://codereview.chromium.org/2908353003
Cr-Commit-Position: refs/heads/master@{#479896}

[modify] https://crrev.com/9ab6f1801d197cda79b2f1dbf8f81d4f8d5f4884/chrome/browser/ui/webui/version_ui.cc
[modify] https://crrev.com/9ab6f1801d197cda79b2f1dbf8f81d4f8d5f4884/components/chrome_apps/webstore_widget/app/main.html
[modify] https://crrev.com/9ab6f1801d197cda79b2f1dbf8f81d4f8d5f4884/components/crash/core/browser/resources/crashes.html
[modify] https://crrev.com/9ab6f1801d197cda79b2f1dbf8f81d4f8d5f4884/components/dom_distiller/webui/resources/about_dom_distiller.html
[modify] https://crrev.com/9ab6f1801d197cda79b2f1dbf8f81d4f8d5f4884/components/flags_ui/resources/apple_flags.html
[modify] https://crrev.com/9ab6f1801d197cda79b2f1dbf8f81d4f8d5f4884/components/flags_ui/resources/flags.html
[modify] https://crrev.com/9ab6f1801d197cda79b2f1dbf8f81d4f8d5f4884/components/gcm_driver/resources/gcm_internals.html
[modify] https://crrev.com/9ab6f1801d197cda79b2f1dbf8f81d4f8d5f4884/components/neterror/resources/neterror.html
[modify] https://crrev.com/9ab6f1801d197cda79b2f1dbf8f81d4f8d5f4884/components/physical_web/webui/resources/physical_web.html
[modify] https://crrev.com/9ab6f1801d197cda79b2f1dbf8f81d4f8d5f4884/components/signin/core/browser/resources/signin_index.html
[modify] https://crrev.com/9ab6f1801d197cda79b2f1dbf8f81d4f8d5f4884/components/supervised_user_error_page/resources/supervised_user_block_interstitial.html
[modify] https://crrev.com/9ab6f1801d197cda79b2f1dbf8f81d4f8d5f4884/components/supervised_user_error_page/supervised_user_error_page_unittest.cc
[modify] https://crrev.com/9ab6f1801d197cda79b2f1dbf8f81d4f8d5f4884/components/sync/driver/resources/index.html
[modify] https://crrev.com/9ab6f1801d197cda79b2f1dbf8f81d4f8d5f4884/components/version_ui/resources/about_version.html
[modify] https://crrev.com/9ab6f1801d197cda79b2f1dbf8f81d4f8d5f4884/ui/base/webui/jstemplate_builder.cc

Comment 21 by edwardjung@chromium.org, Jun 16 2017 

@dschuyler your CL  https://codereview.chromium.org/2908353003 broke the network error font styling. 

There is a problem with this line: 
<body id="t" style="fontFamily:$i18n{fontfamily};fontSize:$i18n{fontsize}">

It should be:
<body id="t" style="font-family:$i18n{fontfamily};font-size:$i18n{fontsize}">

fontFamily and fontSize is not valid CSS but the way you set them with JS, which this is no longer doing.

I've attached screenshots of what it looks like now versus what it should look like (sans-serif fonts and smaller font size)

Could you take a look. I'm not sure if any of the other files you modified also declare fonts this way.

Thanks.
Screen Shot 2017-06-16 at 15.05.13.png
95.9 KB View Download
Screen Shot 2017-06-16 at 15.08.49.png
73.8 KB View Download

Comment 22 by dbeam@chromium.org, Jun 16 2017 

dschuyler@: can you update your script to handle these cases?

Comment 23 by dschuyler@chromium.org, Jun 16 2017 

Thanks edwardjung@ for pointing it out and dbeam@ for changing it already. The script does appear to have an error. I'll address it.

Comment 24 by elawrence@chromium.org, Jun 16 2017 

Re #21: This got filed as  Issue 733946
Project Member

Comment 26 by bugdroid1@chromium.org, Jun 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ef8b851e96d0b42897db2c9540caedb4afdc6f0

commit 3ef8b851e96d0b42897db2c9540caedb4afdc6f0
Author: dschuyler <dschuyler@chromium.org>
Date: Tue Jun 20 20:22:40 2017

[i18n] remove i18n_template.js and load_time_data.js from flags

This CL removes some js includes that don't appear to be in use any longer.

BUG=677338

Review-Url: https://codereview.chromium.org/2944743002
Cr-Commit-Position: refs/heads/master@{#480930}

[modify] https://crrev.com/3ef8b851e96d0b42897db2c9540caedb4afdc6f0/components/flags_ui/resources/apple_flags.html
[modify] https://crrev.com/3ef8b851e96d0b42897db2c9540caedb4afdc6f0/components/flags_ui/resources/flags.html
Project Member

Comment 27 by bugdroid1@chromium.org, Jun 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a405f45d2e776c340f47b6733d35e7b5d7338980

commit a405f45d2e776c340f47b6733d35e7b5d7338980
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Fri Jun 30 18:21:23 2017

[i18n] Use $i18n{} in new tab page

This CL changes the new_tab.html to use the new $i18n{} replacements.

Bug: 677338
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4fd3f45d5c7a5970e9ce715f464f946bad7e039c
Reviewed-on: https://chromium-review.googlesource.com/557060
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483763}
[modify] https://crrev.com/a405f45d2e776c340f47b6733d35e7b5d7338980/chrome/browser/resources/ntp4/new_tab.html
Project Member

Comment 28 by bugdroid1@chromium.org, Jun 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2880c226c082056a6459f4b7d5eb22cb47a84bf0

commit 2880c226c082056a6459f4b7d5eb22cb47a84bf0
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Fri Jun 30 21:18:59 2017

[i18n] remove strings.js

Follow-up for CL https://codereview.chromium.org/2944743002 to stop
sending the strings.js (which is no longer used).

Bug: 677338
Change-Id: I3edcabcf01db9ad7dc794bd4bc8fa05f6146d4ac
Reviewed-on: https://chromium-review.googlesource.com/557966
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483816}
[modify] https://crrev.com/2880c226c082056a6459f4b7d5eb22cb47a84bf0/chrome/browser/ui/webui/flags_ui.cc
[modify] https://crrev.com/2880c226c082056a6459f4b7d5eb22cb47a84bf0/components/flags_ui/resources/flags.html
Project Member

Comment 29 by bugdroid1@chromium.org, Jul 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eaccceea6f528287e0ba532767709bcc967f7899

commit eaccceea6f528287e0ba532767709bcc967f7899
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Sat Jul 01 00:21:36 2017

[i18n] Use $i18n{} in ChromeOs guest NTP

This CL changes the i18n-content/values usage to the faster $i18n{}
localization.

Bug: 677338
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I91a4adf779ab6d5adbf93a3b4abeefb35c55f4f6
Reviewed-on: https://chromium-review.googlesource.com/556899
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483872}
[modify] https://crrev.com/eaccceea6f528287e0ba532767709bcc967f7899/chrome/browser/resources/chromeos/guest_session_tab.html
[modify] https://crrev.com/eaccceea6f528287e0ba532767709bcc967f7899/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
Project Member

Comment 30 by bugdroid1@chromium.org, Jul 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3206fa07f1a2e31d2deff64c7061a042c148b186

commit 3206fa07f1a2e31d2deff64c7061a042c148b186
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Sat Jul 08 00:25:00 2017

[i18n] options chromeos to $i18n{}

This CL updates the options/chromeos html from the old i18n-content and
values to $i18n{} replacements.

TBR=stevenjb@chromium.org

Bug: 677338
Change-Id: I24685ac591b8116baa52fe059f5076d7c1674232
Reviewed-on: https://chromium-review.googlesource.com/563608
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485111}
[modify] https://crrev.com/3206fa07f1a2e31d2deff64c7061a042c148b186/chrome/browser/resources/options/chromeos/accounts_options.html
[modify] https://crrev.com/3206fa07f1a2e31d2deff64c7061a042c148b186/chrome/browser/resources/options/chromeos/arc_opt_out_confirm_overlay.html
[modify] https://crrev.com/3206fa07f1a2e31d2deff64c7061a042c148b186/chrome/browser/resources/options/chromeos/bluetooth_add_device_overlay.html
[modify] https://crrev.com/3206fa07f1a2e31d2deff64c7061a042c148b186/chrome/browser/resources/options/chromeos/bluetooth_pair_device_overlay.html
[modify] https://crrev.com/3206fa07f1a2e31d2deff64c7061a042c148b186/chrome/browser/resources/options/chromeos/change_picture_options.html
[modify] https://crrev.com/3206fa07f1a2e31d2deff64c7061a042c148b186/chrome/browser/resources/options/chromeos/display_options.html
[modify] https://crrev.com/3206fa07f1a2e31d2deff64c7061a042c148b186/chrome/browser/resources/options/chromeos/display_overscan.html
[modify] https://crrev.com/3206fa07f1a2e31d2deff64c7061a042c148b186/chrome/browser/resources/options/chromeos/internet_detail.html
[modify] https://crrev.com/3206fa07f1a2e31d2deff64c7061a042c148b186/chrome/browser/resources/options/chromeos/keyboard_overlay.html
[modify] https://crrev.com/3206fa07f1a2e31d2deff64c7061a042c148b186/chrome/browser/resources/options/chromeos/pointer_overlay.html
[modify] https://crrev.com/3206fa07f1a2e31d2deff64c7061a042c148b186/chrome/browser/resources/options/chromeos/power_overlay.html
[modify] https://crrev.com/3206fa07f1a2e31d2deff64c7061a042c148b186/chrome/browser/resources/options/chromeos/preferred_networks.html
[modify] https://crrev.com/3206fa07f1a2e31d2deff64c7061a042c148b186/chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.html
[modify] https://crrev.com/3206fa07f1a2e31d2deff64c7061a042c148b186/chrome/browser/resources/options/chromeos/storage_clear_drive_cache_overlay.html
[modify] https://crrev.com/3206fa07f1a2e31d2deff64c7061a042c148b186/chrome/browser/resources/options/chromeos/storage_manager.html
[modify] https://crrev.com/3206fa07f1a2e31d2deff64c7061a042c148b186/chrome/browser/resources/options/chromeos/stylus_overlay.html
[modify] https://crrev.com/3206fa07f1a2e31d2deff64c7061a042c148b186/chrome/browser/resources/options/chromeos/third_party_ime_confirm_overlay.html
Project Member

Comment 31 by bugdroid1@chromium.org, Jul 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5aee1f7187049a7881472d6e4a1aa91a7631c439

commit 5aee1f7187049a7881472d6e4a1aa91a7631c439
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Sat Jul 08 00:45:12 2017

[i18n] change options to use $i18n{}

This CL updates the options html from the old i18n-content to $i18n{}
replacements.

TBR=stevenjb@chromium.org

Bug: 677338
Change-Id: I7c129d792910a2196cf2701a750258d49fe0b33b
Reviewed-on: https://chromium-review.googlesource.com/564137
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485118}
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/autofill_edit_address_overlay.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/autofill_edit_creditcard_overlay.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/autofill_options.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/automatic_settings_reset_banner.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/browser_options.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/certificate_backup_overlay.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/certificate_edit_ca_trust_overlay.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/certificate_import_error_overlay.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/certificate_manager.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/certificate_restore_overlay.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/clear_browser_data_history_notice_overlay.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/clear_browser_data_overlay.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/content_settings.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/content_settings_exceptions_area.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/cookies_view.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/do_not_track_confirm_overlay.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/easy_unlock_turn_off_overlay.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/factory_reset_overlay.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/font_settings.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/handler_options.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/home_page_overlay.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/hotword_confirm_overlay.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/import_data_overlay.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/language_add_language_overlay.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/language_dictionary_overlay.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/language_options.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/manage_profile_overlay.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/options.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/password_manager.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/reset_profile_settings_overlay.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/search_box.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/search_engine_manager.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/search_page.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/secondary_user_banner.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/spelling_confirm_overlay.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/startup_overlay.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/startup_section.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/supervised_user_create_confirm.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/supervised_user_import.html
[modify] https://crrev.com/5aee1f7187049a7881472d6e4a1aa91a7631c439/chrome/browser/resources/options/sync_section.html
Project Member

Comment 32 by bugdroid1@chromium.org, Jul 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc3d1661a5fa2191e6d23a70bdc1b62471353144

commit bc3d1661a5fa2191e6d23a70bdc1b62471353144
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Thu Jul 13 19:28:18 2017

[i18n] convert appcache internal UI to $i18n{}

This CL replaces use of i18n-content/values with $i18n{} in the internal
appcache page. This page was and is only partially localized.

TBR=michaeln@chromium.org

Bug: 677338
Change-Id: I3113d51ab80381291807f298e3885d9128464144
Reviewed-on: https://chromium-review.googlesource.com/569314
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486453}
[modify] https://crrev.com/bc3d1661a5fa2191e6d23a70bdc1b62471353144/content/browser/resources/appcache/appcache_internals.html
Project Member

Comment 33 by bugdroid1@chromium.org, Aug 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59ec01bdce1e2024333d1e956078978cc63fdc28

commit 59ec01bdce1e2024333d1e956078978cc63fdc28
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Tue Aug 01 23:00:30 2017

[i18n] remove i18n-content from domain-reliability-internals

This CL removes the i18n-content on the <title> (afaik it was not being
set so I removed it rather than converting to $i18n{title}). Also removes
strings.js and i18n_template.js which should be unneeded at this point.

Bug: 677338
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iab29f07c23d200ed824f4207199853d982eefff2
Reviewed-on: https://chromium-review.googlesource.com/585769
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491143}
[modify] https://crrev.com/59ec01bdce1e2024333d1e956078978cc63fdc28/chrome/browser/resources/domain_reliability_internals.html
[modify] https://crrev.com/59ec01bdce1e2024333d1e956078978cc63fdc28/chrome/browser/ui/webui/domain_reliability_internals_ui.cc
Project Member

Comment 34 by bugdroid1@chromium.org, Aug 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b96f2cbbfd81ad1354f9b72b72630d94d1aa8383

commit b96f2cbbfd81ad1354f9b72b72630d94d1aa8383
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Wed Aug 02 23:07:50 2017

[i18n] migrate chromeos login welcome i18n

This CL changes the chromeos login welcome page (and welcome dialog) to
use i18nDynamic rather than i18n-content and i18n-values.

Bug: 677338
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4c871e9b9e9f8dce8aa5c5da05972936e73e2a48
Reviewed-on: https://chromium-review.googlesource.com/596778
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491543}
[modify] https://crrev.com/b96f2cbbfd81ad1354f9b72b72630d94d1aa8383/chrome/browser/resources/chromeos/login/oobe_welcome.html
[modify] https://crrev.com/b96f2cbbfd81ad1354f9b72b72630d94d1aa8383/chrome/browser/resources/chromeos/login/oobe_welcome.js
[modify] https://crrev.com/b96f2cbbfd81ad1354f9b72b72630d94d1aa8383/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html
[modify] https://crrev.com/b96f2cbbfd81ad1354f9b72b72630d94d1aa8383/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.js
Project Member

Comment 35 by bugdroid1@chromium.org, Oct 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2db606e0a6bc4b6ddb41b911ba353ffed8d50cf

commit a2db606e0a6bc4b6ddb41b911ba353ffed8d50cf
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Tue Oct 03 21:05:29 2017

[MD settings] use i18n in site_data

This CL removes a dom property and call to loadTimeData.getString that's
unnecessary because the work can be done by $i18n{}. (This relates to the
bug in the sense that the bug covers moving to $i18n{} in general).

Bug: 677338
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie149d9b2dfc5e27921ca8cdfab01ec402d1910af
Reviewed-on: https://chromium-review.googlesource.com/693574
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506173}
[modify] https://crrev.com/a2db606e0a6bc4b6ddb41b911ba353ffed8d50cf/chrome/browser/resources/settings/site_settings/site_data.html
[modify] https://crrev.com/a2db606e0a6bc4b6ddb41b911ba353ffed8d50cf/chrome/browser/resources/settings/site_settings/site_data.js
Project Member

Comment 36 by bugdroid1@chromium.org, Dec 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf71398217bd071a235ab4ed9ba97d2b26730039

commit bf71398217bd071a235ab4ed9ba97d2b26730039
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Mon Dec 11 21:30:40 2017

[MD extensions] replace i18n() use with $i18nPolymer.

This CL replaces the slower i18n() code with $i18nPolymer replacements
and reduces usage if I18nBehavior.

Bug: 677338
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I324e5d148e71cd4abc0cfa028d5b48fbc1cefaf2
Reviewed-on: https://chromium-review.googlesource.com/812571
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523215}
[modify] https://crrev.com/bf71398217bd071a235ab4ed9ba97d2b26730039/chrome/browser/resources/md_extensions/compiled_resources2.gyp
[modify] https://crrev.com/bf71398217bd071a235ab4ed9ba97d2b26730039/chrome/browser/resources/md_extensions/detail_view.html
[modify] https://crrev.com/bf71398217bd071a235ab4ed9ba97d2b26730039/chrome/browser/resources/md_extensions/detail_view.js
Project Member

Comment 37 by bugdroid1@chromium.org, Dec 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a131ab14c01ecd74169e2209c03f2ba188614b5f

commit a131ab14c01ecd74169e2209c03f2ba188614b5f
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Tue Dec 12 20:03:58 2017

[docs] replace i18n-content examples with $i18n{}

This CL replaces some examples of using old i18n with new $i18n{}
replacements.

Bug: 677338
Change-Id: Ibdd8b98bd067262879ea11842b5b20c2c4ac34e7
Reviewed-on: https://chromium-review.googlesource.com/820550
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523525}
[modify] https://crrev.com/a131ab14c01ecd74169e2209c03f2ba188614b5f/docs/webui_in_components.md
Project Member

Comment 38 by bugdroid1@chromium.org, Dec 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49edf658458303d6ee1b3bbbe275f9a55532661c

commit 49edf658458303d6ee1b3bbbe275f9a55532661c
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Fri Dec 22 00:54:13 2017

[i18n] Move inner html string sanitization into load time data.

This CL moves the sanitization feature from I18nBehavior to lower level
code so that it will be more broadly available.

Bug: 677338
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id0a1a9761796d953a3d517f9ea9cf34430ce2f9b
Reviewed-on: https://chromium-review.googlesource.com/841243
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525877}
[modify] https://crrev.com/49edf658458303d6ee1b3bbbe275f9a55532661c/chrome/browser/resources/bookmark_manager/js/compiled_resources2.gyp
[modify] https://crrev.com/49edf658458303d6ee1b3bbbe275f9a55532661c/chrome/browser/resources/extensions/compiled_resources2.gyp
[modify] https://crrev.com/49edf658458303d6ee1b3bbbe275f9a55532661c/ui/webui/resources/html/load_time_data.html
[modify] https://crrev.com/49edf658458303d6ee1b3bbbe275f9a55532661c/ui/webui/resources/js/compiled_resources2.gyp
[modify] https://crrev.com/49edf658458303d6ee1b3bbbe275f9a55532661c/ui/webui/resources/js/i18n_behavior.js
[modify] https://crrev.com/49edf658458303d6ee1b3bbbe275f9a55532661c/ui/webui/resources/js/load_time_data.js
Project Member

Comment 39 by bugdroid1@chromium.org, Dec 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed06b93000c86b85c098703b0763862e0ff9a699

commit ed06b93000c86b85c098703b0763862e0ff9a699
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Sat Dec 23 00:33:26 2017

[i18n] convert some of chrome/browser/resources to $i18n{}

This CL is a mechanical replacement of i18n-content and i18n-values in
some chrome/browser/resources files. These are the files that I was able
to test easily (and I don't want the CL to be huge).

Bug: 677338
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I26267d78f44adab8e520a561fa5b30b951f284f9
Reviewed-on: https://chromium-review.googlesource.com/841753
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526108}
[modify] https://crrev.com/ed06b93000c86b85c098703b0763862e0ff9a699/chrome/browser/resources/about_flash.html
[modify] https://crrev.com/ed06b93000c86b85c098703b0763862e0ff9a699/chrome/browser/resources/certificate_viewer.html
[modify] https://crrev.com/ed06b93000c86b85c098703b0763862e0ff9a699/chrome/browser/resources/chromeos/network_ui/network_ui.html
[modify] https://crrev.com/ed06b93000c86b85c098703b0763862e0ff9a699/chrome/browser/resources/components.html
[modify] https://crrev.com/ed06b93000c86b85c098703b0763862e0ff9a699/chrome/browser/resources/inline_login/inline_login.html
[modify] https://crrev.com/ed06b93000c86b85c098703b0763862e0ff9a699/chrome/browser/resources/local_discovery/local_discovery.html
[modify] https://crrev.com/ed06b93000c86b85c098703b0763862e0ff9a699/chrome/browser/resources/media/webrtc_logs.html
[modify] https://crrev.com/ed06b93000c86b85c098703b0763862e0ff9a699/chrome/browser/resources/policy.html
[modify] https://crrev.com/ed06b93000c86b85c098703b0763862e0ff9a699/chrome/browser/resources/translate_internals/prefs.html
Project Member

Comment 40 by bugdroid1@chromium.org, Jan 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ceb8bd753109c7d8948c7bf912a401be7998b229

commit ceb8bd753109c7d8948c7bf912a401be7998b229
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Wed Jan 03 02:39:27 2018

[i18n] convert power display page to $i18n{}

This Cl converts the internal page to display power usage information
from the old i18n-content to the new $i18n{} localization.

Bug: 677338
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7983c7d01d993b81cf2dd4111712425f63db7ca5
Reviewed-on: https://chromium-review.googlesource.com/846424
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526598}
[modify] https://crrev.com/ceb8bd753109c7d8948c7bf912a401be7998b229/chrome/browser/resources/chromeos/power.html
Project Member

Comment 41 by bugdroid1@chromium.org, Jan 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1484d925a32ee075e63f224a01145295ac697071

commit 1484d925a32ee075e63f224a01145295ac697071
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Wed Jan 17 21:51:33 2018

[i18n] remove I18nBehavior from about page

This CL removes the I18nBehavior from the about page by using an iron-
selector to show warning information.

Bug: 677338
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie9025c451ba14a66be50fe0ce696032d30818829
Reviewed-on: https://chromium-review.googlesource.com/862884
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529901}
[modify] https://crrev.com/1484d925a32ee075e63f224a01145295ac697071/chrome/browser/resources/settings/about_page/channel_switcher_dialog.html
[modify] https://crrev.com/1484d925a32ee075e63f224a01145295ac697071/chrome/browser/resources/settings/about_page/channel_switcher_dialog.js
[modify] https://crrev.com/1484d925a32ee075e63f224a01145295ac697071/chrome/browser/resources/settings/about_page/compiled_resources2.gyp
[modify] https://crrev.com/1484d925a32ee075e63f224a01145295ac697071/chrome/test/data/webui/settings/about_page_tests.js
Project Member

Comment 42 by bugdroid1@chromium.org, Jan 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7b84196685a5ae5a824813e9f0fd192b85cef32

commit d7b84196685a5ae5a824813e9f0fd192b85cef32
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Fri Jan 19 23:04:40 2018

[i18n] change identity internals to use $i18n{}

This CL changes the identity internals from using the old i18n-content
to the new $i18n{} replacement.

Bug: 677338
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia603e5463eaff981a6bf7902d8eff36642602f5d
Reviewed-on: https://chromium-review.googlesource.com/872431
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530648}
[modify] https://crrev.com/d7b84196685a5ae5a824813e9f0fd192b85cef32/chrome/browser/resources/identity_internals.html
Project Member

Comment 43 by bugdroid1@chromium.org, Apr 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1efce97c7fe982be34d1a622699fa80b5744df2f

commit 1efce97c7fe982be34d1a622699fa80b5744df2f
Author: Igor Kobylin <ikobylin@yandex-team.ru>
Date: Tue Apr 17 03:08:26 2018

[i18n] Change conflicts page to use $i18n{}

R=dschuyler@chromium.org

Bug: 677338
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I84fa57c20af482de22ff31dd09c223b4f4331770
Reviewed-on: https://chromium-review.googlesource.com/1007443
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551225}
[modify] https://crrev.com/1efce97c7fe982be34d1a622699fa80b5744df2f/chrome/browser/resources/about_conflicts.html

Comment 44 by dschuyler@chromium.org, Jun 23 2018

Labels: Hotlist-GoodFirstBug OS-Chrome OS-Linux OS-Mac OS-Windows
Owner: ----
Status: Available (was: Started)
This is much closer than it was, but there are still some i18n-content and i18n-values floating around.

Feel free to contact me if you'd like to pick up this available bug and have questions.

Comment 45 by dpa...@chromium.org, Jun 25 2018

Components: UI>Browser>WebUI

Comment 46 by dpa...@chromium.org, Sep 25 

FYI, one additional reason to move away from i18n-content is that it still relies on /deep/ query selectors, which no longer work in Shadow DOM v1.

Example failures with Polymer 2 because of the usage of i18n-content/i18n-values can be seen at issue 875507.
Project Member

Comment 47 by bugdroid1@chromium.org, Dec 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8429ba21d7729921d1c025762ed6fb2c28d81de1

commit 8429ba21d7729921d1c025762ed6fb2c28d81de1
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Wed Dec 05 01:45:21 2018

Media Router WebUI: replace i18n-content and i18n-values with $i18n{}

Bug: 677338
Change-Id: Icedc14f661e154dda6fc23f6ffd645c2eb3fa2c6
Reviewed-on: https://chromium-review.googlesource.com/c/1362283
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613806}
[modify] https://crrev.com/8429ba21d7729921d1c025762ed6fb2c28d81de1/chrome/browser/resources/media_router/media_router.html

Comment 48 by lucmult@chromium.org, Dec 11

Cc: lucmult@chromium.org
Files app quick-view element has a few broken values due to this bug.

Comment 49 by dbeam@chromium.org, Dec 11 

lucmult@: can you expand on what you mean here?

Comment 50 by lucmult@chromium.org, Dec 11 

Sorry for my brevity there. :-)

In Files app quick view is a Polymer element [1] which uses some i18n-content and i18n-values. When running with Polymer2 these elements have their content or attributes blank, since they aren't really replaced with their translations.

sammc@ detected this problem when writing a test [2] that checks some of the affected elements attribute but the test failed when running with polymer2. We tried to use $i18n{} but since our Polymer elements/templates are only processed in JS it doesn't work.

[1] - https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/elements/files_quick_view.html
[2] - https://cs.chromium.org/chromium/src/ui/file_manager/integration_tests/file_manager/quick_view.js?l=114-121

Comment 51 by dpa...@chromium.org, Dec 11 

> In Files app quick view is a Polymer element [1] which uses some i18n-content and i18n-values. When running with Polymer2 these elements have their content or attributes blank, since they aren't really replaced with their translations.

This happens because the i18n-values, i18n-content mechanism relies on /deep/ querySelector, which does not work with ShadowDOMv1/Polymer2. This is tracked by issue 842602.

Moving away from i18n-values, i18n-content is the right approach.

Comment 52 by dpa...@chromium.org, Dec 11 

> We tried to use $i18n{} but since our Polymer elements/templates are only processed in JS it doesn't work

Hm, I am wondering if this is something we could fix. For other WebUI pages, the C++ preprocessing is triggered at https://cs.chromium.org/chromium/src/content/browser/webui/web_ui_url_loader_factory.cc?dr&g=0&l=93.

The alternative would be to fix issue 842602 by writing recursive JS equivalent to /deep/, which most likely will have not so great performance.
Project Member

Comment 53 by bugdroid1@chromium.org, Jan 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63b08a1d371956e64e081d386f2552c72332b2a2

commit 63b08a1d371956e64e081d386f2552c72332b2a2
Author: dpapad <dpapad@chromium.org>
Date: Tue Jan 15 23:56:26 2019

WebUI cleanup: Remove some obsolete dependencies to i18n_template.js.

The corresponding files have been migrated to the C++ $i18n{} mechanism
in previous CLs, for example:

https://chromium-review.googlesource.com/c/chromium/src/+/841753/
https://chromium-review.googlesource.com/c/chromium/src/+/872431/

but these dependencies were left behind, and they don't seem needed anymore.
Removing such obsolete dependencies will make it easier to spot the places
that still depend on the previous i18n-values/i18n-content mechanism.

Bug: 677338
Change-Id: I6b55b83f9b247b08f02bac7684054343485cf3c6
Reviewed-on: https://chromium-review.googlesource.com/c/1410362
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622881}
[modify] https://crrev.com/63b08a1d371956e64e081d386f2552c72332b2a2/chrome/browser/resources/about_flash.html
[modify] https://crrev.com/63b08a1d371956e64e081d386f2552c72332b2a2/chrome/browser/resources/certificate_viewer.html
[modify] https://crrev.com/63b08a1d371956e64e081d386f2552c72332b2a2/chrome/browser/resources/chromeos/network_ui/network_ui.html
[modify] https://crrev.com/63b08a1d371956e64e081d386f2552c72332b2a2/chrome/browser/resources/components.html
[modify] https://crrev.com/63b08a1d371956e64e081d386f2552c72332b2a2/chrome/browser/resources/conflicts/about_conflicts.html
[modify] https://crrev.com/63b08a1d371956e64e081d386f2552c72332b2a2/chrome/browser/resources/download_internals/download_internals.html
[modify] https://crrev.com/63b08a1d371956e64e081d386f2552c72332b2a2/chrome/browser/resources/identity_internals.html
[modify] https://crrev.com/63b08a1d371956e64e081d386f2552c72332b2a2/chrome/browser/resources/inline_login/inline_login.html
[modify] https://crrev.com/63b08a1d371956e64e081d386f2552c72332b2a2/chrome/browser/resources/local_discovery/local_discovery.html
[modify] https://crrev.com/63b08a1d371956e64e081d386f2552c72332b2a2/chrome/browser/resources/media/webrtc_logs.html
[modify] https://crrev.com/63b08a1d371956e64e081d386f2552c72332b2a2/chrome/browser/resources/policy.html
Project Member

Comment 54 by bugdroid1@chromium.org, Jan 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63b08a1d371956e64e081d386f2552c72332b2a2

commit 63b08a1d371956e64e081d386f2552c72332b2a2
Author: dpapad <dpapad@chromium.org>
Date: Tue Jan 15 23:56:26 2019

WebUI cleanup: Remove some obsolete dependencies to i18n_template.js.

The corresponding files have been migrated to the C++ $i18n{} mechanism
in previous CLs, for example:

https://chromium-review.googlesource.com/c/chromium/src/+/841753/
https://chromium-review.googlesource.com/c/chromium/src/+/872431/

but these dependencies were left behind, and they don't seem needed anymore.
Removing such obsolete dependencies will make it easier to spot the places
that still depend on the previous i18n-values/i18n-content mechanism.

Bug: 677338
Change-Id: I6b55b83f9b247b08f02bac7684054343485cf3c6
Reviewed-on: https://chromium-review.googlesource.com/c/1410362
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622881}
[modify] https://crrev.com/63b08a1d371956e64e081d386f2552c72332b2a2/chrome/browser/resources/about_flash.html
[modify] https://crrev.com/63b08a1d371956e64e081d386f2552c72332b2a2/chrome/browser/resources/certificate_viewer.html
[modify] https://crrev.com/63b08a1d371956e64e081d386f2552c72332b2a2/chrome/browser/resources/chromeos/network_ui/network_ui.html
[modify] https://crrev.com/63b08a1d371956e64e081d386f2552c72332b2a2/chrome/browser/resources/components.html
[modify] https://crrev.com/63b08a1d371956e64e081d386f2552c72332b2a2/chrome/browser/resources/conflicts/about_conflicts.html
[modify] https://crrev.com/63b08a1d371956e64e081d386f2552c72332b2a2/chrome/browser/resources/download_internals/download_internals.html
[modify] https://crrev.com/63b08a1d371956e64e081d386f2552c72332b2a2/chrome/browser/resources/identity_internals.html
[modify] https://crrev.com/63b08a1d371956e64e081d386f2552c72332b2a2/chrome/browser/resources/inline_login/inline_login.html
[modify] https://crrev.com/63b08a1d371956e64e081d386f2552c72332b2a2/chrome/browser/resources/local_discovery/local_discovery.html
[modify] https://crrev.com/63b08a1d371956e64e081d386f2552c72332b2a2/chrome/browser/resources/media/webrtc_logs.html
[modify] https://crrev.com/63b08a1d371956e64e081d386f2552c72332b2a2/chrome/browser/resources/policy.html
Project Member

Comment 55 by bugdroid1@chromium.org, Jan 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4587a2b16f13908391be5c397e951a2220d4b582

commit 4587a2b16f13908391be5c397e951a2220d4b582
Author: dpapad <dpapad@chromium.org>
Date: Wed Jan 16 02:49:17 2019

WebUI cleanup: Migrate various WebUI pages from i18n-content to $i18n{}

Specifically:
 chrome://nacl
 chrome://syncfs-internals
 chrome://translate-internals

Also removing the i18n_template.js dependency from chrome://device-log and
chrome://power which have already been migrated.

Bug: 677338
Change-Id: I044ee3934a0d944941983ec80f31533b6a285887
Reviewed-on: https://chromium-review.googlesource.com/c/1413373
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623067}
[modify] https://crrev.com/4587a2b16f13908391be5c397e951a2220d4b582/chrome/browser/resources/about_nacl.html
[modify] https://crrev.com/4587a2b16f13908391be5c397e951a2220d4b582/chrome/browser/resources/chromeos/power.html
[modify] https://crrev.com/4587a2b16f13908391be5c397e951a2220d4b582/chrome/browser/resources/device_log_ui/device_log_ui.html
[modify] https://crrev.com/4587a2b16f13908391be5c397e951a2220d4b582/chrome/browser/resources/sync_file_system_internals/main.html
[modify] https://crrev.com/4587a2b16f13908391be5c397e951a2220d4b582/chrome/browser/resources/translate_internals/translate_internals.html
Project Member

Comment 56 by bugdroid1@chromium.org, Jan 17 (6 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac62991c88917c8c3f438437c2ac42ba6d880e81

commit ac62991c88917c8c3f438437c2ac42ba6d880e81
Author: Igor Kobylin <ikobylin@yandex-team.ru>
Date: Thu Jan 17 23:12:45 2019

[i18n] Convert some of chrome/browser/resources to $i18n{}

This converts following pages:
* chrome://cast
* chrome://make-metro
* chrome://predictors
* chrome://signin-error

R=dpapad@chromium.org

Bug: 677338
Change-Id: I67576bca582cbffd9a2caf80070156116aa20c8e
Reviewed-on: https://chromium-review.googlesource.com/c/1412358
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623897}
[modify] https://crrev.com/ac62991c88917c8c3f438437c2ac42ba6d880e81/chrome/browser/resources/cast/cast.html
[modify] https://crrev.com/ac62991c88917c8c3f438437c2ac42ba6d880e81/chrome/browser/resources/predictors/predictors.html
[modify] https://crrev.com/ac62991c88917c8c3f438437c2ac42ba6d880e81/chrome/browser/resources/set_as_default_browser.html
[modify] https://crrev.com/ac62991c88917c8c3f438437c2ac42ba6d880e81/chrome/browser/resources/signin/signin_error/signin_error.html
[modify] https://crrev.com/ac62991c88917c8c3f438437c2ac42ba6d880e81/chrome/browser/ui/webui/set_as_default_browser_ui_win.cc

Comment 57 by sa...@chromium.org, Jan 18 (6 days ago)

Blockedon: 923206
►

Sign in to add a comment