New issue
Advanced search Search tips

Issue 677337 link

Starred by 1 user
Status: Started
Owner:
mahmadi@chromium.org
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug


Show other hotlists

Hotlists containing this issue:
Payment-Conversion


Sign in to add a comment

Payment Request UI doesn't close after touching the pay button

Project Member Reported by jdonnelly@chromium.org, Dec 28 2016 
In the Payment Request flow, the client page is expected to at some point call the PaymentResponse.complete() method  which should trigger the PR UI to close.

This succeeds normally. But if the page calls setTimeout and puts the call to complete() inside the timeout, then the timeout doesn't fire and thus the UI doesn't close. Unless you subsequently switch the device to landscape orientation, then the timeout code runs, the complete() method is called, and the PR UI closes.

Note: this issue only occurs on a real device, not in the simulator.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2b04f241c4d84d52c9c01c8044007c92cbb7ae4

commit c2b04f241c4d84d52c9c01c8044007c92cbb7ae4
Author: jdonnelly <jdonnelly@chromium.org>
Date: Wed Jan 18 21:14:30 2017

Add a timeout if the page doesn't call complete() in a timely fashion.

Also:
- Periodically execute a JS noop to work around an issue where the JS event queue is blocked when presenting the Payment Request UI.
- Remove handling for rejecting PaymentResponse, since the spec doesn't actually call for ever doing this. (See https://www.w3.org/TR/payment-request/#complete-method.)

BUG= 679399 ,677337

Review-Url: https://codereview.chromium.org/2632463003
Cr-Commit-Position: refs/heads/master@{#444480}

[modify] https://crrev.com/c2b04f241c4d84d52c9c01c8044007c92cbb7ae4/ios/chrome/browser/payments/js_payment_request_manager.h
[modify] https://crrev.com/c2b04f241c4d84d52c9c01c8044007c92cbb7ae4/ios/chrome/browser/payments/js_payment_request_manager.mm
[modify] https://crrev.com/c2b04f241c4d84d52c9c01c8044007c92cbb7ae4/ios/chrome/browser/payments/payment_request_manager.mm
[modify] https://crrev.com/c2b04f241c4d84d52c9c01c8044007c92cbb7ae4/ios/chrome/browser/payments/resources/payment_request_manager.js

Comment 2 by pinkerton@chromium.org, Feb 16 2017

Owner: mahmadi@chromium.org
Bulk transfer of autofill bugs from jdonnelly@ to mahmadi@.

Comment 3 by lafo...@chromium.org, Jun 27 2017

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
►

Sign in to add a comment