All CLs in the transaction have to be at least CR+2 or TR+1.

If that wasn't the case here, then this is WAI.

ah, all righty, closing out as wontfix.  It would be nice if the launcher wouldn't die but instead just ignore the CL or emit a clear message for the waterfall to consume.

The launcher should not die, if that's the case then that is indeed a bug.

Agree, the launcher shouldn't die from uncaught exception even if the pre-cq run cannot start.

This should be a small fix. Since it happened again, upping to P2.

nxia@ can you try to squash this?

The recent pre-cq-launcher failure looks to be a separate issue:


https://uberchromegw.corp.google.com/i/chromeos/builders/pre-cq-launcher/builds/8675/steps/PreCQLauncher/logs/stdio


  File "/b/cbuild/internal_master/chromite/lib/gerrit.py", line 109, in GetChangeDetail
    self.host, change_num, o_params=('CURRENT_REVISION', 'CURRENT_COMMIT'))
  File "/b/cbuild/internal_master/chromite/lib/gob_util.py", line 375, in GetChangeDetail
    return FetchUrlJson(host, path)
  File "/b/cbuild/internal_master/chromite/lib/gob_util.py", line 260, in FetchUrlJson
    fh = FetchUrl(*args, **kwargs)
  File "/b/cbuild/internal_master/chromite/lib/gob_util.py", line 252, in FetchUrl
    _FetchUrlHelper, sleep=SLEEP)
  File "/b/cbuild/internal_master/chromite/lib/retry_util.py", line 171, in RetryException
    return GenericRetry(exc_retry, max_retry, functor, *args, **kwargs)
  File "/b/cbuild/internal_master/chromite/lib/retry_util.py", line 122, in GenericRetry
    ret = functor(*args, **kwargs)
  File "/b/cbuild/internal_master/chromite/lib/gob_util.py", line 183, in _FetchUrlHelper
    response = conn.getresponse()
  File "/usr/lib/python2.7/httplib.py", line 1089, in getresponse
    response.begin()
  File "/usr/lib/python2.7/httplib.py", line 444, in begin
    version, status, reason = self._read_status()
  File "/usr/lib/python2.7/httplib.py", line 400, in _read_status
    line = self.fp.readline(_MAXLINE + 1)
  File "/usr/lib/python2.7/socket.py", line 476, in readline
    data = self._sock.recv(self._rbufsize)
  File "/usr/lib/python2.7/ssl.py", line 341, in recv
    return self.read(buflen)
  File "/usr/lib/python2.7/ssl.py", line 260, in read
    return self._sslobj.read(len)


Deputy can file a separate bug for the recent pre-cq-launcher failure.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a4e0b251e3955411a716d3e9ca6342ebb05f0ed0

commit a4e0b251e3955411a716d3e9ca6342ebb05f0ed0
Author: Ningning Xia <nxia@chromium.org>
Date: Fri Feb 24 13:42:54 2017

PatchSeries: fix possible KeyError in CreateDisjointTransactions.

It's possible a change was filtered for creating a disjoint transaction
while the other changes it depends on were not picked up in the same
changes set. This can cause a KeyError Exception.
With out the fix, the new unit test TestCreateDisjointTransactions will
fail with KeyError.

BUG= chromium:677335 
TEST=unit_tests

Change-Id: I2860c26cc9c4d15453325efc5b2558e568d63635
Reviewed-on: https://chromium-review.googlesource.com/446019
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/a4e0b251e3955411a716d3e9ca6342ebb05f0ed0/cbuildbot/patch_series.py
[modify] https://crrev.com/a4e0b251e3955411a716d3e9ca6342ebb05f0ed0/cbuildbot/patch_series_unittest.py