New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 677306 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 15 days ago
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android , Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Add libmojo from AOSP

Project Member Reported by ejcaruso@chromium.org, Dec 28 2016

Issue description

This will make it easier to use mojo in new projects and move old projects to mojo in the future.
 
Summary: Add libmojo from AOSP (was: Add libmojo from AOSP to manifest)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 29 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/4b1054f379385165cab832a9623c0e60a754c88a

commit 4b1054f379385165cab832a9623c0e60a754c88a
Author: Eric Caruso <ejcaruso@google.com>
Date: Wed Dec 28 19:12:07 2016

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/manifest/+/a8bf23816387fdbbe89fe831c3393c081989deda

commit a8bf23816387fdbbe89fe831c3393c081989deda
Author: Eric Caruso <ejcaruso@chromium.org>
Date: Wed Dec 28 19:00:23 2016

manifest: add libmojo from aosp

We want to start using libmojo in places other than ARC, so it's
useful to pull in the most recent libmojo from AOSP.

BUG= chromium:677306 
TEST=repo sync

Change-Id: I652b210b8f8716eba3eb97b33f1fc9aff70ade31
Reviewed-on: https://chromium-review.googlesource.com/424167
Commit-Ready: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/a8bf23816387fdbbe89fe831c3393c081989deda/full.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/6f9927757df66bac7317bb5d52f00cefe63605dd

commit 6f9927757df66bac7317bb5d52f00cefe63605dd
Author: Eric Caruso <ejcaruso@chromium.org>
Date: Wed Dec 28 21:11:00 2016

dev-util/gn: uprev gn to the latest build

We need a new version of gn to build the latest libmojo.

BUG= chromium:677306 
TEST=sudo emerge gn, gn --version

Change-Id: I536fb784bc79a3cb9bebbd23532a645ef85229d9
Reviewed-on: https://chromium-review.googlesource.com/424199
Commit-Ready: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/6f9927757df66bac7317bb5d52f00cefe63605dd/dev-util/gn/Manifest
[rename] https://crrev.com/6f9927757df66bac7317bb5d52f00cefe63605dd/dev-util/gn/gn-439377-r1.ebuild

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3c7f643844d183cc5278f36c3e3356379ddbf0a2

commit 3c7f643844d183cc5278f36c3e3356379ddbf0a2
Author: Eric Caruso <ejcaruso@chromium.org>
Date: Wed Dec 28 22:46:35 2016

chromeos-base: add libmojo-395517

There's no reason this shouldn't be in the public overlay,
so add it there in preparation for public packages being able
to use it.

CQ-DEPEND=CL:*313947
BUG= chromium:677306 
TEST=emerge-{samus,veyron_minnie,cave} libmojo

Change-Id: I057662abbb077682c49c1dc1b07aeacd28d11677
Reviewed-on: https://chromium-review.googlesource.com/424170
Commit-Ready: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/3c7f643844d183cc5278f36c3e3356379ddbf0a2/chromeos-base/libmojo/libmojo-395517.ebuild
[add] https://crrev.com/3c7f643844d183cc5278f36c3e3356379ddbf0a2/chromeos-base/libmojo/libmojo-395517-r1.ebuild
[add] https://crrev.com/3c7f643844d183cc5278f36c3e3356379ddbf0a2/chromeos-base/libmojo/Manifest

Status: Fixed (was: Assigned)
We should be able to build libmojo in the public repo now, so I'm closing this.
Cc: henryhsu@chromium.org
Currently libmojo on chromeos is built from localmirror instead of aosp/external/libmojo.

See third_party/chromiumos-overlay/chromeos-base/libmojo/libmojo-395517-r1.ebuild
Should we change it?

Sign in to add a comment