New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 677286 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

User switching with a dark theme presents unreadable text

Reported by lfpg....@gmail.com, Dec 28 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36

Steps to reproduce the problem:
1. Set a dark GTK theme (tested with Arc Dark and KDE's Breeze Dark)
2. Have more than one user connected on Chrome
3. Click the user switching menu

What is the expected behavior?
It should either show the menu items with light background and dark text (preferred) or the other way around

What went wrong?
Both the highlighted item background and the text are light, rendering the text unreadable. The attached file shows this (names / pictures have been blurred)

Did this work before? Yes 

Chrome version: 55.0.2883.87  Channel: stable
OS Version: Arch Linux
Flash Version: Shockwave Flash 24.0 r0

Previously the user switching was different - left clicking would show a popup and right clicking would show a simple menu, but it didn't have the light-on-light issue (as far as I remember)
 
chromium-user-switching.png
22.3 KB View Download
Cc: brajkumar@chromium.org
Labels: Needs-Feedback
Unable to reproduce the issue on Ubuntu 14.04 using chrome latest stable M55-55.0.2883.87 by following steps mentioned below.

1. Created multiple user on different profile
2. Installed dark theme 
https://chrome.google.com/webstore/detail/material-dark-mkbhd/iiplegjeipnjdpgkeccfccnahofbckad
3. Clicked on profile switch menu
4. Observed the profile names are displayed in light background and dark text as expected.

Repoerter@ Could you please confirm is the above steps is the right way to reproduce this issue? If not please let us know on which theme you are actually facing this issue.

Thanks!
Screenshot from 2016-12-29 11:51:07.png
19.3 KB View Download

Comment 3 by lfpg....@gmail.com, Dec 29 2016

That theme indeed works, maybe because of 2 things:
- It is a Chrome theme (in my example the dark theme is GTK itself)
- On that theme, the user switching menu has a light background

In fact, I've tried to install several dark themes from Chrome Web Store and they all show the user switching menu with light background.

Try installing Arc theme from http://www.noobslab.com/2016/06/arc-theme-light-dark-versions-and-icons.html and pick the Arc Dark theme. Also, make sure that Chrome is set to use the GTK theme.
Cc: thomasanderson@chromium.org est...@chromium.org e...@chromium.org
Project Member

Comment 5 by sheriffbot@chromium.org, Jan 6 2017

Labels: -Needs-Feedback Needs-Review
Owner: brajkumar@chromium.org
Thank you for providing more feedback. Adding requester "brajkumar@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: thomasanderson@chromium.org
Status: Started (was: Unconfirmed)
X-reffing images for https://codereview.chromium.org/2624683002/
dark_adwaita_no_patch.png
18.1 KB View Download
dark_adwaita.png
18.2 KB View Download
ambiance.png
18.0 KB View Download
chrome_classic.png
16.9 KB View Download
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8af777bf6b7bdd749632cfa5c2fde7a3f98038c0

commit 8af777bf6b7bdd749632cfa5c2fde7a3f98038c0
Author: thomasanderson <thomasanderson@google.com>
Date: Tue Feb 07 01:12:49 2017

Add old_state parameter to CustomButton::StateChanged

This change is necessary for
https://codereview.chromium.org/2624683002/

BUG= 677286 
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2680643002
Cr-Commit-Position: refs/heads/master@{#448486}

[modify] https://crrev.com/8af777bf6b7bdd749632cfa5c2fde7a3f98038c0/ash/common/system/chromeos/audio/volume_view.cc
[modify] https://crrev.com/8af777bf6b7bdd749632cfa5c2fde7a3f98038c0/ash/common/system/chromeos/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/8af777bf6b7bdd749632cfa5c2fde7a3f98038c0/ash/common/system/tray/tray_popup_header_button.cc
[modify] https://crrev.com/8af777bf6b7bdd749632cfa5c2fde7a3f98038c0/ash/common/system/tray/tray_popup_header_button.h
[modify] https://crrev.com/8af777bf6b7bdd749632cfa5c2fde7a3f98038c0/chrome/browser/ui/views/payments/payment_request_row_view.cc
[modify] https://crrev.com/8af777bf6b7bdd749632cfa5c2fde7a3f98038c0/chrome/browser/ui/views/payments/payment_request_row_view.h
[modify] https://crrev.com/8af777bf6b7bdd749632cfa5c2fde7a3f98038c0/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/8af777bf6b7bdd749632cfa5c2fde7a3f98038c0/ui/app_list/views/app_list_item_view.cc
[modify] https://crrev.com/8af777bf6b7bdd749632cfa5c2fde7a3f98038c0/ui/app_list/views/app_list_item_view.h
[modify] https://crrev.com/8af777bf6b7bdd749632cfa5c2fde7a3f98038c0/ui/app_list/views/tile_item_view.cc
[modify] https://crrev.com/8af777bf6b7bdd749632cfa5c2fde7a3f98038c0/ui/app_list/views/tile_item_view.h
[modify] https://crrev.com/8af777bf6b7bdd749632cfa5c2fde7a3f98038c0/ui/chromeos/ime/candidate_view.cc
[modify] https://crrev.com/8af777bf6b7bdd749632cfa5c2fde7a3f98038c0/ui/chromeos/ime/candidate_view.h
[modify] https://crrev.com/8af777bf6b7bdd749632cfa5c2fde7a3f98038c0/ui/message_center/views/notification_button.cc
[modify] https://crrev.com/8af777bf6b7bdd749632cfa5c2fde7a3f98038c0/ui/message_center/views/notification_button.h
[modify] https://crrev.com/8af777bf6b7bdd749632cfa5c2fde7a3f98038c0/ui/views/controls/button/custom_button.cc
[modify] https://crrev.com/8af777bf6b7bdd749632cfa5c2fde7a3f98038c0/ui/views/controls/button/custom_button.h
[modify] https://crrev.com/8af777bf6b7bdd749632cfa5c2fde7a3f98038c0/ui/views/controls/button/label_button.cc
[modify] https://crrev.com/8af777bf6b7bdd749632cfa5c2fde7a3f98038c0/ui/views/controls/button/label_button.h
[modify] https://crrev.com/8af777bf6b7bdd749632cfa5c2fde7a3f98038c0/ui/views/controls/button/md_text_button.cc
[modify] https://crrev.com/8af777bf6b7bdd749632cfa5c2fde7a3f98038c0/ui/views/controls/button/md_text_button.h
[modify] https://crrev.com/8af777bf6b7bdd749632cfa5c2fde7a3f98038c0/ui/views/controls/button/menu_button.cc
[modify] https://crrev.com/8af777bf6b7bdd749632cfa5c2fde7a3f98038c0/ui/views/controls/button/menu_button.h

Project Member

Comment 9 by bugdroid1@chromium.org, Feb 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0de79a0e44c878b66df8012e77ff38896fe8faf

commit f0de79a0e44c878b66df8012e77ff38896fe8faf
Author: thomasanderson <thomasanderson@google.com>
Date: Tue Feb 07 04:29:26 2017

Linux UI: Fix profile chooser button background color

Previously, the profile chooser hovered background color was hardcoded to
0xEAEAEA.  This is about the same color as dark themes will use for their label
text, making the hovered text unreadable.  This CL changes the color to use the
menu item hovered color instead.  Images of the change at:
https://bugs.chromium.org/p/chromium/issues/detail?id=677286#c7

BUG= 677286 
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2624683002
Cr-Commit-Position: refs/heads/master@{#448542}

[modify] https://crrev.com/f0de79a0e44c878b66df8012e77ff38896fe8faf/chrome/browser/ui/libgtkui/native_theme_gtk3.cc
[modify] https://crrev.com/f0de79a0e44c878b66df8012e77ff38896fe8faf/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/f0de79a0e44c878b66df8012e77ff38896fe8faf/chrome/browser/ui/views/profiles/profile_chooser_view.h
[modify] https://crrev.com/f0de79a0e44c878b66df8012e77ff38896fe8faf/ui/views/controls/label.h

Status: Fixed (was: Started)

Sign in to add a comment