New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 677259 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Share extension and invalid URLs

Project Member Reported by olivierrobin@chromium.org, Dec 28 2016

Issue description

What is the expected behavior if the URL received in the share extension in invalid?

 
Components: UI>Browser>ReaderMode
Labels: M-57 Hotlist-ReadingList
For reference, here is the error in Firefox

https://screenshot.googleplex.com/O8Fab0WaTzz
Labels: ReleaseBlock-Stable
Another proposition is to have the same UI and disable the buttons.

https://screenshot.googleplex.com/xBsPqBDT9Ut
I prefer the alert view as it is easier to parse (or inversely to dismiss) and is the correct and expected type of UI for displaying a message to the user.

As for the strings:

Title: Chrome cannot handle this link.
Message: <invalid URL>
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 2 2017

Status: Fixed (was: Assigned)
olivier@, Do you have any websites or web pages examples I could use for testing this fix?
mmm
This is a good question indeed as you need a permissive application and a page presening bad URL.

You can test it by
1. installing firefox-ios
2. in firefox, visit http://browsingtest.appspot.com/external_url_links.html
3. long press on "Calendar URL"
4. Share link
5. Chrome

Note: in Chrome, the context menu for this link should be only "Copy".


Status: Verified (was: Fixed)
Verified in 57.0.2978.0 canary, iPhone 6 plus 10.2, iPad mini 10.1

Error dialog is shown for for urls that are not HTTP or HTTPS.

Sign in to add a comment