New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 677256 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocked on:
issue 767857



Sign in to add a comment

WebRtcAudioQualityBrowserTest seems flaky on Windows

Project Member Reported by henrika@chromium.org, Dec 28 2016

Issue description

In the Chromium waterfall and on Builder: Win7 Tester (stats), these
tests seem to fail without any changes in either WebRTC och Chrome that
can cause the issues.

All WebRtcAudioQualityBrowserTest tests now fail on Windows and they all fail with
this error message:

e:\b\c\b\win_builder\src\chrome\browser\media\webrtc\webrtc_audio_quality_browsertest.cc(574): error: Value of: actual_segments.size()
  Actual: 1
Expected: ref_segments.size()
Which is: 6
The recording did not result in the same number of audio segments after on splitting on silence; WebRTC must have deformed the audio too much.

See e.g. https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/32279/steps/browser_tests/logs/stdio for more details.


 
I have compared with rounds where the tests worked and can't find any other clues
to why they now fail. Might have to disable all tests on Windows.
Components: Infra>Client>WebRTC
Owner: ----
Status: Untriaged (was: Assigned)
I logged in to build97-b1 and checked the configuration. It seems to be as it should according to the instructions except the volume output level was at 85 instead of 50 (as mentioned in the instructions). I set it to 60 to see if that helps.

https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/32280 is the first build with the new setting.

Unassigning from phoglund since he's on parental leave for 8 months.
The attempt in #2 didn't help. I'll have a look taking the bot offline for a while.
I changed the default recording device from Wave to Stereo Mix and set the output level back to 85. I also updated the ASUS audio config to be 44.1MHz instead of 96MHz, in hope that setting may have any effect. 

https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/32281 will be the first build with this new try.
https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/32281 had fewer failed tests but the raw_mos and mos_lqo scores went down to <2 (and aren't uploaded to the perf dashboard since the test still fails).

I restored the Wave device again, hoping the change in the ASUS Xonar ASIO control panel will have any effect.
I did this in the middle of build https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/32282
so https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/32283 is probably safer to look at before drawing new conclusions.
It's back at the old behavior. I dunno what can be wrong with it. 
henrika: Can you disable it on Win7 only?
FYI, tried locally on my Win10 (don't have access to Win7):

.\out\Release\browser_tests.exe --gtest_filter=WebRtcAudioQuality* --run-manual --ui-test-action-max-timeout=350000 --gtest_repeat=10

No issues locally.

Disabling tests for Win7 here: https://codereview.chromium.org/2602873002/
Status: WontFix (was: Untriaged)
Before the CL in #8 was submitted the bot went mysteriously back to a green state again [1] and the test is performing as it did. I'm suspecting some other change actually affected our test that was reverted (although I cannot see anything in the blame list unfortunately).

[1]: https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/32294
Really strange. The CL in #8 can still be used if the issue pops up again.
Cc: mbonadei@chromium.org
Owner: phoglund@chromium.org
Status: Unconfirmed (was: WontFix)
Still see issues on this bot. Started happening again here:

https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/37896


[2448:2528:0921/014146.349:ERROR:webrtc_audio_quality_browsertest.cc(474)] PESQ was not able to compute a score; we probably recorded only silence. Please check the output/input volume levels.
../../chrome/browser/media/webrtc/webrtc_audio_quality_browsertest.cc(603): error: Value of: succeeded
  Actual: false
Expected: true
Failed to run PESQ.
Cc: henrika@chromium.org
Owner: charujain@chromium.org
Status: Assigned (was: Unconfirmed)
Assigning to Charu who is this week's trooper.

It would be nice to pull some recordings off the bot, e.g.

Test failed; keeping recording(s) at
	C:\Users\chrome-bot.LABS\AppData\Local\Temp\dc7bd222-e1ab-48f3-98fb-f8f6169b69e9.tmp.wav.

lines, so we can hear what the test hears. The test should be disabled until we can figure out what's going on.
Owner: henrika@chromium.org
Actually, Henrik A, since you're the sheriff you should disable the test. Assign the bug back to Charu later so she can pull recordings off the bot, and investigate what's wrong with the test.
In total 16 tests fail. I can't manually disable all these. Will instead disable all on Windows until we understand
why they all fail on this particular bot.

[  FAILED  ] WebRtcAudioQualityBrowserTest.MANUAL_TestCallQualityWithAudioFromFakeDevice, where TypeParam =  and GetParam() =  (35026 ms)
[  FAILED  ] WebRtcAudioQualityBrowserTest.MANUAL_TestCallQualityWithAudioFromWebAudio, where TypeParam =  and GetParam() =  (29771 ms)
[  FAILED  ] WebRtcAudioQualityBrowserTest.MANUAL_TestAutoGainControlOnLowAudio, where TypeParam =  and GetParam() =  (35013 ms)
[  FAILED  ] WebRtcAudioQualityBrowserTest.MANUAL_TestAutoGainIsOffWithAudioProcessingOff, where TypeParam =  and GetParam() =  (34461 ms)
[  FAILED  ] WebRtcAudioQualityBrowserTest.MANUAL_TestAutoGainControlOnLowAudio, where TypeParam =  and GetParam() =  (34732 ms)
[  FAILED  ] WebRtcAudioQualityBrowserTest.MANUAL_TestAutoGainIsOffWithAudioProcessingOff, where TypeParam =  and GetParam() =  (34645 ms)
[  FAILED  ] WebRtcAudioQualityBrowserTest.MANUAL_TestCallQualityWithAudioFromFakeDevice, where TypeParam =  and GetParam() =  (34190 ms)
[  FAILED  ] WebRtcAudioQualityBrowserTest.MANUAL_TestCallQualityWithAudioFromWebAudio, where TypeParam =  and GetParam() =  (30014 ms)
[  FAILED  ] WebRtcAudioQualityBrowserTest.MANUAL_TestAutoGainControlOnLowAudio, where TypeParam =  and GetParam() =  (34553 ms)
[  FAILED  ] WebRtcAudioQualityBrowserTest.MANUAL_TestAutoGainIsOffWithAudioProcessingOff, where TypeParam =  and GetParam() =  (34272 ms)
[  FAILED  ] WebRtcAudioQualityBrowserTest.MANUAL_TestCallQualityWithAudioFromFakeDevice, where TypeParam =  and GetParam() =  (34275 ms)
[  FAILED  ] WebRtcAudioQualityBrowserTest.MANUAL_TestCallQualityWithAudioFromWebAudio, where TypeParam =  and GetParam() =  (29490 ms)
[  FAILED  ] WebRtcAudioQualityBrowserTest.MANUAL_TestAutoGainControlOnLowAudio, where TypeParam =  and GetParam() =  (34414 ms)
[  FAILED  ] WebRtcAudioQualityBrowserTest.MANUAL_TestAutoGainIsOffWithAudioProcessingOff, where TypeParam =  and GetParam() =  (34483 ms)
[  FAILED  ] WebRtcAudioQualityBrowserTest.MANUAL_TestCallQualityWithAudioFromFakeDevice, where TypeParam =  and GetParam() =  (34318 ms)
[  FAILED  ] WebRtcAudioQualityBrowserTest.MANUAL_TestCallQualityWithAudioFromWebAudio, where TypeParam =  and GetParam() =  (30213 ms)

Patch uploaded here: https://chromium-review.googlesource.com/c/chromium/src/+/677458

Not sure if I can land it using TBR.
Cc: phoglund@chromium.org
Owner: charujain@chromium.org
TBR would have been fine in a case like this. We need to green up bots fast.

Comment 19 by henrika@webrtc.org, Sep 22 2017

We are now green.
On debugging we found following solutions: 

1) The temporary audio files are probably wiped off after each test which means the recorded files is no more available. 

2) We could bring the slave offline and run the test to get the recorded audio files and debug from there. 

3) The best would be to upload the recorded file which can be easily accessed from UI. 


Owner: phoglund@chromium.org
Blockedon: 767857
[Re-triage] The bug this depends on is a P2. Should this also be a P2? Or both P1?
Labels: -Pri-1 Pri-2
I believe P2, this is annoying but hardly critical.
Project Member

Comment 25 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32b5eb6e2dee07a0f1da2335dd9a0533c46779b1

commit 32b5eb6e2dee07a0f1da2335dd9a0533c46779b1
Author: Patrik Höglund <phoglund@chromium.org>
Date: Thu Oct 19 09:04:43 2017

Revert "Disables WebRtcAudioQualityBrowserTest on Windows"

This reverts commit 885d259d95260d44c1dcbe602f4afbeaa1c74c70.

Reason for revert: Need to test new sound card config on win bots.

Original change's description:
> Disables WebRtcAudioQualityBrowserTest on Windows
> 
> TBR=phoglund
> 
> Bug: webrtc:677256
> Change-Id: I84a0fdf08a25204231ee1869918ecbffc8bdca9d
> Reviewed-on: https://chromium-review.googlesource.com/677458
> Reviewed-by: Henrik Andreasson <henrika@chromium.org>
> Commit-Queue: Henrik Andreasson <henrika@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#503516}

TBR=phoglund@chromium.org,henrika@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  677256 , 737090 
Change-Id: Ie41beeec00b3e3fbc7702ba6c7fd8a754c567e18
Reviewed-on: https://chromium-review.googlesource.com/727919
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510041}
[modify] https://crrev.com/32b5eb6e2dee07a0f1da2335dd9a0533c46779b1/chrome/browser/media/webrtc/webrtc_audio_quality_browsertest.cc

Project Member

Comment 26 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/794407a995dfb2b199cad445890d68de84c7edeb

commit 794407a995dfb2b199cad445890d68de84c7edeb
Author: Patrik Höglund <phoglund@chromium.org>
Date: Fri Oct 20 07:59:45 2017

"Enable WebRtcAudioQualityBrowserTest on Windows"

This reverts commit 32b5eb6e2dee07a0f1da2335dd9a0533c46779b1.

Reason for revert: The test is broken, either through cruft accumulating or that the new sound cards don't work on the bot.

Original change's description:
> Revert "Disables WebRtcAudioQualityBrowserTest on Windows"
> 
> This reverts commit 885d259d95260d44c1dcbe602f4afbeaa1c74c70.
> 
> Reason for revert: Need to test new sound card config on win bots.
> 
> Original change's description:
> > Disables WebRtcAudioQualityBrowserTest on Windows
> > 
> > TBR=phoglund
> > 
> > Bug: webrtc:677256
> > Change-Id: I84a0fdf08a25204231ee1869918ecbffc8bdca9d
> > Reviewed-on: https://chromium-review.googlesource.com/677458
> > Reviewed-by: Henrik Andreasson <henrika@chromium.org>
> > Commit-Queue: Henrik Andreasson <henrika@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#503516}
> 
> TBR=phoglund@chromium.org,henrika@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug:  677256 , 737090 
> Change-Id: Ie41beeec00b3e3fbc7702ba6c7fd8a754c567e18
> Reviewed-on: https://chromium-review.googlesource.com/727919
> Reviewed-by: Patrik Höglund <phoglund@chromium.org>
> Reviewed-by: Henrik Andreasson <henrika@chromium.org>
> Commit-Queue: Patrik Höglund <phoglund@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#510041}

TBR=phoglund@chromium.org,henrika@chromium.org

Change-Id: I58c29571bf4fd298d733edaed5da741a4902d8e0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  677256 ,  737090 
Reviewed-on: https://chromium-review.googlesource.com/728259
Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510373}
[modify] https://crrev.com/794407a995dfb2b199cad445890d68de84c7edeb/chrome/browser/media/webrtc/webrtc_audio_quality_browsertest.cc

Project Member

Comment 27 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6a88e104401147b84cd7724c2856b463a5cedb4

commit f6a88e104401147b84cd7724c2856b463a5cedb4
Author: Patrik Höglund <phoglund@chromium.org>
Date: Tue Nov 14 11:06:11 2017

Re-enable WebRtcAudioQualityBrowserTest on Windows.

The sound card has been re-installed on all win bots so this should
work now.

Bug:  chromium:677256 
Change-Id: I993f14dc8e6c4bb1ace09d1a793b1e79214209fe
Reviewed-on: https://chromium-review.googlesource.com/768379
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516262}
[modify] https://crrev.com/f6a88e104401147b84cd7724c2856b463a5cedb4/chrome/browser/media/webrtc/webrtc_audio_quality_browsertest.cc

Project Member

Comment 28 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53ccc526cac98cfe2e16d8c3d2c99b386a155381

commit 53ccc526cac98cfe2e16d8c3d2c99b386a155381
Author: Niklas Enbom <niklase@chromium.org>
Date: Tue Nov 14 20:02:40 2017

Revert "Re-enable WebRtcAudioQualityBrowserTest on Windows."

This reverts commit f6a88e104401147b84cd7724c2856b463a5cedb4.

Reason for revert: Started failing on Win FYI bots immediately

Original change's description:
> Re-enable WebRtcAudioQualityBrowserTest on Windows.
> 
> The sound card has been re-installed on all win bots so this should
> work now.
> 
> Bug:  chromium:677256 
> Change-Id: I993f14dc8e6c4bb1ace09d1a793b1e79214209fe
> Reviewed-on: https://chromium-review.googlesource.com/768379
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Commit-Queue: Patrik Höglund <phoglund@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#516262}

TBR=phoglund@chromium.org,guidou@chromium.org

Change-Id: I671a5c1e15ddeae3fa86d120747cc9649ee8326a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:677256 
Reviewed-on: https://chromium-review.googlesource.com/769527
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Niklas Enbom <niklase@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516399}
[modify] https://crrev.com/53ccc526cac98cfe2e16d8c3d2c99b386a155381/chrome/browser/media/webrtc/webrtc_audio_quality_browsertest.cc

Project Member

Comment 29 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/480f0595d59ed5fc14196d7ec7603156ae1d1476

commit 480f0595d59ed5fc14196d7ec7603156ae1d1476
Author: Patrik Höglund <phoglund@chromium.org>
Date: Thu Dec 14 12:08:30 2017

Reland "Re-enable WebRtcAudioQualityBrowserTest on Windows."

This reverts commit 53ccc526cac98cfe2e16d8c3d2c99b386a155381.

Reason for revert: Now has diagnostic uploading, so we'll at least be able
to tell why it fails if it's still failing. I've also tried tweaking
the sound config on the machine.

Bug:  chromium:677256 
Change-Id: I96cdf15eff0b9d1e09053560ac5e4c518abc5caa
Reviewed-on: https://chromium-review.googlesource.com/826942
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524044}
[modify] https://crrev.com/480f0595d59ed5fc14196d7ec7603156ae1d1476/chrome/browser/media/webrtc/webrtc_audio_quality_browsertest.cc

Status: Fixed (was: Assigned)
I listened to the recordings from the bot using the new recording upload, and I could hear a strong echo in the recordings. I found that the secondary loopback device had "listen to this device" set, which I know produces echo. It should be fixed now, therefore.

Sign in to add a comment