New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 677241 link

Starred by 1 user
Status: Fixed
Owner:
chrishtr@chromium.org
Closed: Dec 2016
Cc:
█ trchen@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 645667



Sign in to add a comment

Paint property under-invalidation in css3/blending/svg-isolation-add-masking.html

Project Member Reported by wangxianzhu@chromium.org, Dec 28 2016 
The test fails with --enable-slimming-paint-invalidation.

Will disable effect feature in https://codereview.chromium.org/2600333002/ for SlimmingPaintInvalidation to unblock this bug from  bug 646176 .

Comment 1 by wangxianzhu@chromium.org, Dec 28 2016

Cc: trchen@chromium.org
Owner: wangxianzhu@chromium.org

Comment 2 by wangxianzhu@chromium.org, Dec 28 2016 

Now prefer fixing this to landing the workaround https://codereview.chromium.org/2600333002/.

Comment 3 by chrishtr@chromium.org, Dec 28 2016

Owner: chrishtr@chromium.org
I have a fix.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f622c97dff9a1df040b5faf60a0948ce9c4df0e1

commit f622c97dff9a1df040b5faf60a0948ce9c4df0e1
Author: chrishtr <chrishtr@chromium.org>
Date: Thu Dec 29 00:48:10 2016

Set needs paint property update for changes of SVG isolation and blending.

BUG= 677241 
TEST=css3/blending/svg-isolation-*
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2607003002
Cr-Commit-Position: refs/heads/master@{#440913}

[modify] https://crrev.com/f622c97dff9a1df040b5faf60a0948ce9c4df0e1/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp
[modify] https://crrev.com/f622c97dff9a1df040b5faf60a0948ce9c4df0e1/third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.cpp
[modify] https://crrev.com/f622c97dff9a1df040b5faf60a0948ce9c4df0e1/third_party/WebKit/Source/core/paint/FindPropertiesNeedingUpdate.h

Comment 5 by chrishtr@chromium.org, Dec 29 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment