When `text-underline-position: under` is applied to a mixed font size, Blink renders at too low.
It was only when mixed-size, sorry for the false alarm.
WebKit fix: https://bugs.webkit.org/show_bug.cgi?id=141528
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ac0bb3d271e109b6f71929eecc1e44442f9576b commit 2ac0bb3d271e109b6f71929eecc1e44442f9576b Author: kojii <kojii@chromium.org> Date: Tue Jan 24 02:07:58 2017 Fix positioning of "text-underline-position:under" for multi-elements This patch fixes following issues in text-underline-position: under 1. Doesn't work with vertical-lr 2. Is always including replaced elements in the "under" check 3. Doesn't limit the "under" check to the containing element with the text-decoration specified 4. Computes incorrect position for mixed sizes This patch is a port of wkb.ug/141528. BUG= 677240 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2602793004 Cr-Commit-Position: refs/heads/master@{#445597} [add] https://crrev.com/2ac0bb3d271e109b6f71929eecc1e44442f9576b/third_party/WebKit/LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-first-line-decoration-expected.html [add] https://crrev.com/2ac0bb3d271e109b6f71929eecc1e44442f9576b/third_party/WebKit/LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-first-line-decoration-vertical-expected.html [add] https://crrev.com/2ac0bb3d271e109b6f71929eecc1e44442f9576b/third_party/WebKit/LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-first-line-decoration-vertical.html [add] https://crrev.com/2ac0bb3d271e109b6f71929eecc1e44442f9576b/third_party/WebKit/LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-first-line-decoration.html [add] https://crrev.com/2ac0bb3d271e109b6f71929eecc1e44442f9576b/third_party/WebKit/LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-mixed-fonts-expected.html [add] https://crrev.com/2ac0bb3d271e109b6f71929eecc1e44442f9576b/third_party/WebKit/LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-mixed-fonts.html [add] https://crrev.com/2ac0bb3d271e109b6f71929eecc1e44442f9576b/third_party/WebKit/LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-subscript-expected.html [add] https://crrev.com/2ac0bb3d271e109b6f71929eecc1e44442f9576b/third_party/WebKit/LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-subscript.html [add] https://crrev.com/2ac0bb3d271e109b6f71929eecc1e44442f9576b/third_party/WebKit/LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-vertical-expected.html [add] https://crrev.com/2ac0bb3d271e109b6f71929eecc1e44442f9576b/third_party/WebKit/LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-vertical.html [modify] https://crrev.com/2ac0bb3d271e109b6f71929eecc1e44442f9576b/third_party/WebKit/Source/core/layout/line/InlineBox.h [modify] https://crrev.com/2ac0bb3d271e109b6f71929eecc1e44442f9576b/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp [modify] https://crrev.com/2ac0bb3d271e109b6f71929eecc1e44442f9576b/third_party/WebKit/Source/core/layout/line/InlineFlowBox.h [modify] https://crrev.com/2ac0bb3d271e109b6f71929eecc1e44442f9576b/third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp [modify] https://crrev.com/2ac0bb3d271e109b6f71929eecc1e44442f9576b/third_party/WebKit/Source/core/layout/line/RootInlineBox.h [modify] https://crrev.com/2ac0bb3d271e109b6f71929eecc1e44442f9576b/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7affa3729f4c422d9db4076e4806fddc49008560 commit 7affa3729f4c422d9db4076e4806fddc49008560 Author: kojii <kojii@chromium.org> Date: Thu Feb 09 01:16:04 2017 Support language-appropriate position for "text-underline-position:under" This patch supports language-appropriate position[1], and matches Blink behavior to Edge and Gecko. [1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet BUG= 677240 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2647923002 Cr-Commit-Position: refs/heads/master@{#449174} [modify] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip-expected.png [add] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-cjk.html [modify] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/linux/fast/block/positioning/auto/vertical-lr/007-expected.png [modify] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/linux/fast/block/positioning/auto/vertical-rl/007-expected.png [modify] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/linux/fast/block/positioning/vertical-lr/001-expected.png [modify] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/linux/fast/block/positioning/vertical-rl/001-expected.png [add] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/linux/fast/css3-text/css3-text-decoration/text-decoration-skip-expected.png [add] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-cjk-expected.png [add] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-cjk-expected.txt [modify] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/linux/fast/lists/002-vertical-expected.png [modify] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/linux/fast/lists/006-vertical-expected.png [modify] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/linux/fast/table/border-collapsing/003-vertical-expected.png [modify] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/linux/fast/text/decorations-with-text-combine-expected.png [modify] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/decorations-with-text-combine-expected.png [modify] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/mac/fast/block/positioning/auto/vertical-lr/007-expected.png [modify] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/mac/fast/block/positioning/auto/vertical-rl/007-expected.png [modify] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/mac/fast/block/positioning/vertical-lr/001-expected.png [modify] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/mac/fast/block/positioning/vertical-rl/001-expected.png [add] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/mac/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-cjk-expected.png [add] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/mac/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-cjk-expected.txt [modify] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/mac/fast/lists/002-vertical-expected.png [modify] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/mac/fast/lists/006-vertical-expected.png [modify] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/mac/fast/table/border-collapsing/003-vertical-expected.png [modify] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/mac/fast/text/decorations-with-text-combine-expected.png [modify] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/win/fast/block/positioning/auto/vertical-lr/007-expected.png [modify] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/win/fast/block/positioning/auto/vertical-rl/007-expected.png [modify] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/win/fast/block/positioning/vertical-lr/001-expected.png [modify] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/win/fast/block/positioning/vertical-rl/001-expected.png [add] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/win/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-cjk-expected.png [add] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/win/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-cjk-expected.txt [modify] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/win/fast/lists/002-vertical-expected.png [modify] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/win/fast/lists/006-vertical-expected.png [modify] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/win/fast/table/border-collapsing/003-vertical-expected.png [modify] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/win/fast/text/decorations-with-text-combine-expected.png [modify] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/LayoutTests/platform/win7/fast/text/decorations-with-text-combine-expected.png [modify] https://crrev.com/7affa3729f4c422d9db4076e4806fddc49008560/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9a92a3d7f22facba57d806d634727d8b704622d commit e9a92a3d7f22facba57d806d634727d8b704622d Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org> Date: Thu Feb 09 02:35:58 2017 Auto-rebaseline for r449174 Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/599421 https://chromium.googlesource.com/chromium/src/+/7affa3729f4c4 BUG= 677240 TBR=kojii@chromium.org Review-Url: https://codereview.chromium.org/2680383003 . Cr-Commit-Position: refs/heads/master@{#449194} [modify] https://crrev.com/e9a92a3d7f22facba57d806d634727d8b704622d/third_party/WebKit/LayoutTests/TestExpectations
Comment 1 by kojii@chromium.org
, Dec 28 201652.4 KB
52.4 KB View Download
53.6 KB
53.6 KB View Download