Paint property under-invalidation when some transform properties change |
|||
Issue descriptionThe following tests fail with --enable-slimming-paint-invalidation: Layout tests: animations/responsive/scale-responsive.html animations/responsive/translate-responsive.html compositing/animation/hidden-composited.html inspector/tracing/timeline-paint/layer-tree.html virtual/threaded/animations/composited-animations-rotate-zero-degrees.html virtual/threaded/fast/compositorworker/basic-plumbing-worker-to-main.html webkit_unit_tests: All/CompositorWorkerTest.applyingMutationsMultipleElements/1 All/CompositorWorkerTest.applyingMutationsMultipleElements/0 because of paint property under-invalidation when directCompositingReasons change. We might have other under-invalidations when perserve-3d changes (unconfirmed). Will disable the feature in https://codereview.chromium.org/2600333002/ for SlimmingPaintInvalidation to unblock this bug from bug 646176 .
,
Dec 28 2016
I'm investigating the same thing for another test, will be involved in a patch I'm sending soon.
,
Dec 28 2016
,
Dec 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3345559e794bd83da5726b4568a73339e0a01aa4 commit 3345559e794bd83da5726b4568a73339e0a01aa4 Author: chrishtr <chrishtr@chromium.org> Date: Wed Dec 28 20:39:34 2016 Set needs paint property update when dirtying descendant-dependent properties. BUG= 677239 TEST=See failing tests in 677239 without this change. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2601963002 Cr-Commit-Position: refs/heads/master@{#440889} [modify] https://crrev.com/3345559e794bd83da5726b4568a73339e0a01aa4/third_party/WebKit/Source/core/paint/PaintLayer.cpp
,
Dec 28 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by wangxianzhu@chromium.org
, Dec 28 2016