New issue
Advanced search Search tips

Issue 677211 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

ffmpeg_regression_tests 449958 fails

Project Member Reported by liber...@chromium.org, Dec 27 2016

Issue description

seems to be unrelated to ffmpeg.  test fails with:

../../media/test/pipeline_integration_test_base.cc:154: Failure
Mock function called more times than expected - returning directly.
    Function call: OnVideoOpacityChange(true)
         Expected: to be called at most once
           Actual: called twice - over-saturated and active

format is changing from YV12A (from ffmpeg_common) to YV12 (from vpx_video_decoder) during decoding, causing VRI to send a second OnVideoOpacityChange.

not sure why this tests only expects one of them.  seems fine to me.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acc729512852c66d25b86ebf3533c1531d331983

commit acc729512852c66d25b86ebf3533c1531d331983
Author: liberato <liberato@chromium.org>
Date: Wed Jan 18 18:54:29 2017

Test fixes for M57 ffmpeg roll.

Fixed Cr449958/FFmpegRegressionTest.BasicPlayback/0 .  Now OnOpacityChanged may
be called any number of times.  449958 does really switch opacity twice.

ffmpeg regression tests MP4_17 now fails (correctly) with
DEMUXER_ERROR_COULD_NOT_OPEN, rather than PIPELINE_OK

BUG= 677211 , 677214 

Review-Url: https://codereview.chromium.org/2639333002
Cr-Commit-Position: refs/heads/master@{#444428}

[modify] https://crrev.com/acc729512852c66d25b86ebf3533c1531d331983/media/ffmpeg/ffmpeg_regression_tests.cc
[modify] https://crrev.com/acc729512852c66d25b86ebf3533c1531d331983/media/test/pipeline_integration_test_base.cc

Status: Fixed (was: Assigned)

Sign in to add a comment