TODO presubmit script is not running to ios/ |
|||||
Issue descriptionI was able to land TODO with . instead of / https://codereview.chromium.org/2605713002/patch/20001/30001
,
Mar 22 2017
,
Jun 2 2017
Returning to the pool.
,
Jun 16 2017
,
Jun 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fcda19fd7ac9920c8f37c8d3aef74bcfb49af9b3 commit fcda19fd7ac9920c8f37c8d3aef74bcfb49af9b3 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Jun 27 10:26:23 2017 [ios] Add a PRESUBMIT check for TODO. All TODOs in src/ios/ should follow the format TODO(crbug.com/######) so add a PRESUBMIT.py check (and corresponding unit tests) for that. BUG= 677203 Change-Id: I360ad75c786f292d3a8ada8df519cb451c1c2828 Reviewed-on: https://chromium-review.googlesource.com/538613 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#482589} [add] https://crrev.com/fcda19fd7ac9920c8f37c8d3aef74bcfb49af9b3/ios/PRESUBMIT.py [add] https://crrev.com/fcda19fd7ac9920c8f37c8d3aef74bcfb49af9b3/ios/PRESUBMIT_test.py
,
Jun 27 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by justincohen@chromium.org
, Dec 29 2016Status: Assigned (was: Untriaged)