self-destructed Commit Queue |
|||||
Issue descriptiongo/self-destructed-commit-queue Master-paladin stops waiting for slaves if the failed slaves are relevant to all CLs and retry doesn’t apply anymore.
,
Jan 10 2017
,
Jan 10 2017
,
Feb 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/e2aa01a695a1fd8e3c015205875163740c82ddf1 commit e2aa01a695a1fd8e3c015205875163740c82ddf1 Author: Ningning Xia <nxia@chromium.org> Date: Tue Feb 07 00:40:59 2017 validation_pool: generate dependency map for changes Given the a set of changes, generate and return a dependency dict mapping each change to all the changes depending on it. BUG= chromium:677178 TEST=unit_tests Change-Id: I162775c3b0d40e6e39f73a5edda5e5c14c2836f6 Reviewed-on: https://chromium-review.googlesource.com/430319 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/e2aa01a695a1fd8e3c015205875163740c82ddf1/cbuildbot/validation_pool.py [modify] https://crrev.com/e2aa01a695a1fd8e3c015205875163740c82ddf1/cbuildbot/validation_pool_unittest.py
,
Feb 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/e8c77fd48ee08b4581bf6d4bce1096dcb869f487 commit e8c77fd48ee08b4581bf6d4bce1096dcb869f487 Author: Ningning Xia <nxia@chromium.org> Date: Wed Feb 08 04:14:32 2017 Get BuildbucketInfo for all scheduled slaves in SlaveBuild We need to access buildbucket status and result for all slaves in every checking loop in order to implement stateless TriageRelevantChanges. Add _GetAllSlaveBuildbucketInfo in SlaveStatus and let _GetNewlyCompletedSlaveBuildbucketInfo get BuildbucketInfo from all_buildbucket_info_dict. BUG= chromium:677178 TEST=unit_tests Change-Id: I2c7e361ff7ad80766ce8471d1ed581940324190a Reviewed-on: https://chromium-review.googlesource.com/430819 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/e8c77fd48ee08b4581bf6d4bce1096dcb869f487/cbuildbot/build_status_unittest.py [modify] https://crrev.com/e8c77fd48ee08b4581bf6d4bce1096dcb869f487/cbuildbot/build_status.py [modify] https://crrev.com/e8c77fd48ee08b4581bf6d4bce1096dcb869f487/cbuildbot/manifest_version_unittest.py
,
Feb 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/92da29e420fee89482bcedab1cf2d42c6d71433e commit 92da29e420fee89482bcedab1cf2d42c6d71433e Author: Ningning Xia <nxia@chromium.org> Date: Thu Feb 09 20:47:32 2017 build_status.SlaveStatus: Get all slave statues from CIDB. 1) Self-destructed CQ will need to access cidb status for all slaves. Support GetAllSlaveCIDBStatusInfo. 2) Clean up SlaveStatus unit tests. BUG= chromium:677178 TEST=unit_tests Change-Id: Ia4f222dc0c79205072133455a1f9eada3db1a081 Reviewed-on: https://chromium-review.googlesource.com/433326 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Chris Ching <chingcodes@chromium.org> [modify] https://crrev.com/92da29e420fee89482bcedab1cf2d42c6d71433e/cbuildbot/build_status_unittest.py [modify] https://crrev.com/92da29e420fee89482bcedab1cf2d42c6d71433e/cbuildbot/build_status.py [modify] https://crrev.com/92da29e420fee89482bcedab1cf2d42c6d71433e/cbuildbot/manifest_version_unittest.py
,
Feb 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/c19a48d04bf8a474a8f4c6f79d1e4da8bf83d597 commit c19a48d04bf8a474a8f4c6f79d1e4da8bf83d597 Author: Ningning Xia <nxia@chromium.org> Date: Thu Feb 09 20:47:32 2017 SlaveStatus: Pass in validation_pool and pre-compute dependency map 1) add GetAppliedPatches in validation_pool to return cached Gerrit query results. 2) pass in validation_pool to SlaveStatus for CQ-master build. BUG= chromium:677178 TEST=unit_tests Change-Id: I155a191f807045c4f0c99ad6e22fa933226b75bd Reviewed-on: https://chromium-review.googlesource.com/433327 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Chris Ching <chingcodes@chromium.org> [modify] https://crrev.com/c19a48d04bf8a474a8f4c6f79d1e4da8bf83d597/cbuildbot/validation_pool.py [modify] https://crrev.com/c19a48d04bf8a474a8f4c6f79d1e4da8bf83d597/cbuildbot/validation_pool_unittest.py [modify] https://crrev.com/c19a48d04bf8a474a8f4c6f79d1e4da8bf83d597/cbuildbot/stages/completion_stages.py [modify] https://crrev.com/c19a48d04bf8a474a8f4c6f79d1e4da8bf83d597/cbuildbot/manifest_version.py [modify] https://crrev.com/c19a48d04bf8a474a8f4c6f79d1e4da8bf83d597/cbuildbot/build_status_unittest.py [modify] https://crrev.com/c19a48d04bf8a474a8f4c6f79d1e4da8bf83d597/cbuildbot/build_status.py
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/2721479cae0c44ad7c4d9a4bb2f8c129738bfe42 commit 2721479cae0c44ad7c4d9a4bb2f8c129738bfe42 Author: Ningning Xia <nxia@chromium.org> Date: Mon Feb 27 20:03:25 2017 GetRelevantChangesForSlaves: provide an include_master option Previously RelevantChanges.GetRelevantChangesForSlaves included the master build to its relevant changes in the return value. Provide the include_master option for this method, so that callers can decide whether to include master build in the result. TriageRelevantChanges would only need the dict result without the master build. BUG= chromium:677178 TEST=unit_tests Change-Id: Ib6be465ab49fac0d0461cc0eae6d16dbacd10686 Reviewed-on: https://chromium-review.googlesource.com/444029 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Chris Ching <chingcodes@chromium.org> [modify] https://crrev.com/2721479cae0c44ad7c4d9a4bb2f8c129738bfe42/cbuildbot/relevant_changes_unittest.py [modify] https://crrev.com/2721479cae0c44ad7c4d9a4bb2f8c129738bfe42/cbuildbot/stages/completion_stages.py [modify] https://crrev.com/2721479cae0c44ad7c4d9a4bb2f8c129738bfe42/cbuildbot/relevant_changes.py
,
Mar 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/dc465d16223ccb84ceab6c636915a19e75b95b8c commit dc465d16223ccb84ceab6c636915a19e75b95b8c Author: Ningning Xia <nxia@chromium.org> Date: Thu Mar 02 21:20:46 2017 Add TriageRelevantChanges and implement _ProcessCompletedBuilds Implemented _ProcessCompletedBuilds for the self-destructed commit queue, which processed all completed and not retriable builds. BUG= chromium:677178 TEST=unit_tests Change-Id: I8b289b2feb7a143de49f4ed40e5435749a567f6c Reviewed-on: https://chromium-review.googlesource.com/444847 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/dc465d16223ccb84ceab6c636915a19e75b95b8c/cbuildbot/relevant_changes_unittest.py [modify] https://crrev.com/dc465d16223ccb84ceab6c636915a19e75b95b8c/lib/fake_cidb.py [modify] https://crrev.com/dc465d16223ccb84ceab6c636915a19e75b95b8c/cbuildbot/relevant_changes.py
,
Mar 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/875502b6d79fa93e068e945cca45187a91694be7 commit 875502b6d79fa93e068e945cca45187a91694be7 Author: Ningning Xia <nxia@chromium.org> Date: Thu Mar 02 21:20:47 2017 TriageRelevantChanges: add _ProcessMightSubmitChanges Go through all the changes in current might_submit set. For each change, find out the slave builds which are relevant to the change. If all the relevant slaves completed with success, move the change from might_submit set to will_submit set. BUG= chromium:677178 TEST=unit_tests Change-Id: Ide86a19073d7797d8b3543fd69644c9d4a2048d1 Reviewed-on: https://chromium-review.googlesource.com/444848 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/875502b6d79fa93e068e945cca45187a91694be7/cbuildbot/relevant_changes_unittest.py [modify] https://crrev.com/875502b6d79fa93e068e945cca45187a91694be7/cbuildbot/relevant_changes.py
,
Mar 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/f5851306304f8a1ddaaa67bfc8c658c119dc5454 commit f5851306304f8a1ddaaa67bfc8c658c119dc5454 Author: Ningning Xia <nxia@chromium.org> Date: Mon Mar 06 20:01:57 2017 _GetAllSlaveCIDBStatusInfo: return cidb statuses for all slaves. _GetAllSlaveCIDBStatusInfo should return cidb statuses for all slaves; _GetNewSlaveCIDBStatusInfo should return cidb statuses for slaves not in completed_builds (a set of builds completed before). BUG= chromium:677178 TEST=unit_tests Change-Id: I0e62cef6e8067d874dc7761cba10661da04651ff Reviewed-on: https://chromium-review.googlesource.com/448937 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Chris Ching <chingcodes@chromium.org> [modify] https://crrev.com/f5851306304f8a1ddaaa67bfc8c658c119dc5454/cbuildbot/build_status_unittest.py [modify] https://crrev.com/f5851306304f8a1ddaaa67bfc8c658c119dc5454/cbuildbot/build_status.py
,
Mar 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/f5851306304f8a1ddaaa67bfc8c658c119dc5454 commit f5851306304f8a1ddaaa67bfc8c658c119dc5454 Author: Ningning Xia <nxia@chromium.org> Date: Mon Mar 06 20:01:57 2017 _GetAllSlaveCIDBStatusInfo: return cidb statuses for all slaves. _GetAllSlaveCIDBStatusInfo should return cidb statuses for all slaves; _GetNewSlaveCIDBStatusInfo should return cidb statuses for slaves not in completed_builds (a set of builds completed before). BUG= chromium:677178 TEST=unit_tests Change-Id: I0e62cef6e8067d874dc7761cba10661da04651ff Reviewed-on: https://chromium-review.googlesource.com/448937 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Chris Ching <chingcodes@chromium.org> [modify] https://crrev.com/f5851306304f8a1ddaaa67bfc8c658c119dc5454/cbuildbot/build_status_unittest.py [modify] https://crrev.com/f5851306304f8a1ddaaa67bfc8c658c119dc5454/cbuildbot/build_status.py
,
Mar 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/f5851306304f8a1ddaaa67bfc8c658c119dc5454 commit f5851306304f8a1ddaaa67bfc8c658c119dc5454 Author: Ningning Xia <nxia@chromium.org> Date: Mon Mar 06 20:01:57 2017 _GetAllSlaveCIDBStatusInfo: return cidb statuses for all slaves. _GetAllSlaveCIDBStatusInfo should return cidb statuses for all slaves; _GetNewSlaveCIDBStatusInfo should return cidb statuses for slaves not in completed_builds (a set of builds completed before). BUG= chromium:677178 TEST=unit_tests Change-Id: I0e62cef6e8067d874dc7761cba10661da04651ff Reviewed-on: https://chromium-review.googlesource.com/448937 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Chris Ching <chingcodes@chromium.org> [modify] https://crrev.com/f5851306304f8a1ddaaa67bfc8c658c119dc5454/cbuildbot/build_status_unittest.py [modify] https://crrev.com/f5851306304f8a1ddaaa67bfc8c658c119dc5454/cbuildbot/build_status.py
,
Mar 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/4321ac4c31ffcd1a0f8fbc246d0fcc09d3240087 commit 4321ac4c31ffcd1a0f8fbc246d0fcc09d3240087 Author: Ningning Xia <nxia@chromium.org> Date: Tue Mar 07 04:42:35 2017 Register TriageRelevantChanges instance in build_status.SlaveStatus. Register TriageRelevantChanges instance in SlaveStatus. Check TriageRelevantChanges.ShouldWait in SlaveStatus.ShouldWait. BUG= chromium:677178 TEST=unit_tests Change-Id: I81db2a4f5995b5ad53e1279920ca80ad9fd77512 Reviewed-on: https://chromium-review.googlesource.com/444849 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/4321ac4c31ffcd1a0f8fbc246d0fcc09d3240087/cbuildbot/build_status_unittest.py [modify] https://crrev.com/4321ac4c31ffcd1a0f8fbc246d0fcc09d3240087/cbuildbot/build_status.py [modify] https://crrev.com/4321ac4c31ffcd1a0f8fbc246d0fcc09d3240087/cbuildbot/manifest_version.py
,
Mar 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/4321ac4c31ffcd1a0f8fbc246d0fcc09d3240087 commit 4321ac4c31ffcd1a0f8fbc246d0fcc09d3240087 Author: Ningning Xia <nxia@chromium.org> Date: Tue Mar 07 04:42:35 2017 Register TriageRelevantChanges instance in build_status.SlaveStatus. Register TriageRelevantChanges instance in SlaveStatus. Check TriageRelevantChanges.ShouldWait in SlaveStatus.ShouldWait. BUG= chromium:677178 TEST=unit_tests Change-Id: I81db2a4f5995b5ad53e1279920ca80ad9fd77512 Reviewed-on: https://chromium-review.googlesource.com/444849 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/4321ac4c31ffcd1a0f8fbc246d0fcc09d3240087/cbuildbot/build_status_unittest.py [modify] https://crrev.com/4321ac4c31ffcd1a0f8fbc246d0fcc09d3240087/cbuildbot/build_status.py [modify] https://crrev.com/4321ac4c31ffcd1a0f8fbc246d0fcc09d3240087/cbuildbot/manifest_version.py
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/0110de4029c5144d34f0579b41ef1040bfd0fe19 commit 0110de4029c5144d34f0579b41ef1040bfd0fe19 Author: Ningning Xia <nxia@chromium.org> Date: Thu Mar 16 23:15:06 2017 Remove CommitQueueCompletion Stage check in TriageRelevantChanges. TriageRelevantChanges has been changed to rely on BuildStatus pickle files to calculate ignorable changes. If BuildStatus is missing status, we treat all failures as not ignorable. Remove CommitQueueCompletion stage check as it's not required by TriageRelevantChanges anymore. BUG= chromium:677178 TEST=unit_tests Change-Id: I99efee589c2e1cf375e104c1a5a0e3fad6a67b27 Reviewed-on: https://chromium-review.googlesource.com/454262 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/0110de4029c5144d34f0579b41ef1040bfd0fe19/cbuildbot/relevant_changes_unittest.py [modify] https://crrev.com/0110de4029c5144d34f0579b41ef1040bfd0fe19/cbuildbot/relevant_changes.py
,
Mar 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/942303f5be0bdbbbadf65721847cb16d0e2de128 commit 942303f5be0bdbbbadf65721847cb16d0e2de128 Author: Ningning Xia <nxia@chromium.org> Date: Fri Mar 17 03:30:50 2017 Trigger self-destruction on CQ. 1) add & change some logs in relevant_changes. 2) trigger self-destruction on CQ 3) save 'self_destructed_build' to metadata so the master can annotate inflight builds with more details. 4) if self_destructed is True, do not handle failures as timeout. BUG= chromium:677178 TEST=unit_tests Change-Id: I230a0af24a76ba6690d6900c4991c60917ae323a Reviewed-on: https://chromium-review.googlesource.com/454081 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/942303f5be0bdbbbadf65721847cb16d0e2de128/cbuildbot/relevant_changes.py [modify] https://crrev.com/942303f5be0bdbbbadf65721847cb16d0e2de128/cbuildbot/stages/completion_stages.py [modify] https://crrev.com/942303f5be0bdbbbadf65721847cb16d0e2de128/cbuildbot/build_status_unittest.py [modify] https://crrev.com/942303f5be0bdbbbadf65721847cb16d0e2de128/cbuildbot/stages/completion_stages_unittest.py [modify] https://crrev.com/942303f5be0bdbbbadf65721847cb16d0e2de128/cbuildbot/build_status.py [modify] https://crrev.com/942303f5be0bdbbbadf65721847cb16d0e2de128/lib/constants.py
,
Mar 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/644388649775e5e83ff6b9fab8b78d41bec04dcd commit 644388649775e5e83ff6b9fab8b78d41bec04dcd Author: Ningning Xia <nxia@chromium.org> Date: Tue Mar 21 02:30:12 2017 Add monarch metrics for self-destructed Commit-Queue BUG= chromium:677178 TEST=run_tests Change-Id: I349d56152e97c48d707067c658c879d7ed5dd6be Reviewed-on: https://chromium-review.googlesource.com/456654 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/644388649775e5e83ff6b9fab8b78d41bec04dcd/lib/constants.py [modify] https://crrev.com/644388649775e5e83ff6b9fab8b78d41bec04dcd/cbuildbot/stages/completion_stages.py [modify] https://crrev.com/644388649775e5e83ff6b9fab8b78d41bec04dcd/cbuildbot/build_status.py
,
Mar 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/ecae0ff6bbbcce58c2f2b06253565d63aa40ce8b commit ecae0ff6bbbcce58c2f2b06253565d63aa40ce8b Author: Ningning Xia <nxia@chromium.org> Date: Tue Mar 21 08:17:22 2017 Add dashboard urls for no_stat builds when self_destructed is True. 1) alter annotation text for failing builds without status.message. 2) add dashboard urls for no_stat builds when self_destructed is on. BUG= chromium:677178 TEST=unit_tests Change-Id: Ie00250472a4a168e907e11f74be1b3340133e931 Reviewed-on: https://chromium-review.googlesource.com/457158 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/ecae0ff6bbbcce58c2f2b06253565d63aa40ce8b/cbuildbot/stages/completion_stages_unittest.py [modify] https://crrev.com/ecae0ff6bbbcce58c2f2b06253565d63aa40ce8b/cbuildbot/stages/completion_stages.py
,
Mar 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/8c513c8cf72ce45c48005455c2083aa5e147c46a commit 8c513c8cf72ce45c48005455c2083aa5e147c46a Author: Ningning Xia <nxia@chromium.org> Date: Thu Mar 23 18:55:51 2017 Add cq_build_durations for CQ-master builds. Add cq_build_durations for CQ-master builds to reflect distribution metrics for self-destructed CQs and not-self-destructed CQs. BUG= chromium:677178 TEST=unit_tests Change-Id: I60bd07b5d9a0b5342569981586793d6d8d7f4e4c Reviewed-on: https://chromium-review.googlesource.com/457787 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Paul Hobbs <phobbs@google.com> [modify] https://crrev.com/8c513c8cf72ce45c48005455c2083aa5e147c46a/lib/constants.py [modify] https://crrev.com/8c513c8cf72ce45c48005455c2083aa5e147c46a/cbuildbot/stages/report_stages_unittest.py [modify] https://crrev.com/8c513c8cf72ce45c48005455c2083aa5e147c46a/cbuildbot/stages/report_stages.py
,
Jun 21 2017
,
Jan 22 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by nxia@chromium.org
, Jan 10 2017