Issue metadata
Sign in to add a comment
|
Can't switch to minimized windows from the switcher UI |
||||||||||||||||||||||
Issue descriptionChrome Version: 57.0.2962.0 Chrome OS Version: 9126.0 Chrome OS Platform: Reef <b>Network info: <network, encryption type, router model (if known)></b> Please specify Cr-* of the system to which this bug/feature applies (add the label below). Steps To Reproduce: (1) Open some apps(google chrome/file...) from all apps. (2) Minimize a window (3) Press F5 to bring up the switcher UI (4) Click on a window that was minimized. Expected Result: Window un-minimizes, brought to front Actual Result: Window remains invisible. How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) Always What is the impact to the user, and is there a workaround? If so, what is it? Please provide any additional information below. Attach a screen shot or log if possible. See crosbug.com/p/61249 for some more info on this. This used to work in build 9002, but failed somewhere before 9088. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Dec 27 2016
,
Dec 29 2016
it appears to me it was introduced in 9015/9016 integration.
,
Dec 29 2016
Identical problem on Skylake chromebook, 9015 is good while 9016 is bad.
,
Jan 19 2017
abodenha@ we need someone on the UI team to take a look at this one. Looks like a regression.
,
Jan 20 2017
Reproducible for me too and I'm pretty sure it worked late last year.
,
Jan 20 2017
OK actually this seems more serious than just being unable to use f5 to restore a window. It looks like the chosen window goes into a "restored but invisible state": - You can apparently click on it with the mouse - You can't restore it using alt-tab - You can close the invisible window with ctrl-w
,
Jan 20 2017
,
Jan 20 2017
varkha@, have you seen this before?
,
Jan 21 2017
I have a draft CL that should fix that at https://codereview.chromium.org/2637403013 .
,
Jan 23 2017
Valery, do you know if this is specific to m-57, or should we be trying to get this merged back into m-56 depending on how serious this is?
,
Jan 23 2017
#11, I haven't looked at which CL breaks it but I suspect it could be in 56, so yes, it would be great to merge this.
,
Jan 23 2017
The breaking CL was https://codereview.chromium.org/2525753002 (r434025 - in M-57 time but then merged into M-56 - see issue 667526 ). So we will need the fix merged indeed.
,
Jan 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f64e9220762c7c7d5237cb4b4222898c5b0f4dc commit 8f64e9220762c7c7d5237cb4b4222898c5b0f4dc Author: varkha <varkha@chromium.org> Date: Mon Jan 23 22:47:40 2017 [ash-md] Makes sure that minimized windows can be activated in overview When windows are minimized before entering overview mode, they are replaced with a widget that has mirrored layers. Opacity of the original window needs to be then set to 1 in order to make it visible (in WindowMirrorView::InitLayerOwner()). Upon exiting overview the original window's opacity is restored. This logic breaks if a window is selected - the opacity need not be restored (to zero). Make it so that the opacity is set to 1 upon exit if a window is selected. BUG= 677177 Review-Url: https://codereview.chromium.org/2637403013 Cr-Commit-Position: refs/heads/master@{#445524} [modify] https://crrev.com/8f64e9220762c7c7d5237cb4b4222898c5b0f4dc/ash/common/wm/overview/scoped_transform_overview_window.cc [modify] https://crrev.com/8f64e9220762c7c7d5237cb4b4222898c5b0f4dc/ash/common/wm/overview/scoped_transform_overview_window.h [modify] https://crrev.com/8f64e9220762c7c7d5237cb4b4222898c5b0f4dc/ash/common/wm/overview/window_selector.cc [modify] https://crrev.com/8f64e9220762c7c7d5237cb4b4222898c5b0f4dc/ash/common/wm/overview/window_selector.h [modify] https://crrev.com/8f64e9220762c7c7d5237cb4b4222898c5b0f4dc/ash/common/wm/overview/window_selector_item.cc [modify] https://crrev.com/8f64e9220762c7c7d5237cb4b4222898c5b0f4dc/ash/common/wm/overview/window_selector_item.h [modify] https://crrev.com/8f64e9220762c7c7d5237cb4b4222898c5b0f4dc/ash/wm/overview/window_selector_unittest.cc
,
Jan 23 2017
Requesting a merge.
,
Jan 23 2017
Requesting a merge into M-57 first.
,
Jan 23 2017
,
Jan 23 2017
Approving merge to m57.
,
Jan 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e86ab7d65162a39b16e19710445f09e357c27a1e commit e86ab7d65162a39b16e19710445f09e357c27a1e Author: Valery Arkhangorodsky <varkha@chromium.org> Date: Mon Jan 23 23:52:24 2017 [ash-md] Makes sure that minimized windows can be activated in overview When windows are minimized before entering overview mode, they are replaced with a widget that has mirrored layers. Opacity of the original window needs to be then set to 1 in order to make it visible (in WindowMirrorView::InitLayerOwner()). Upon exiting overview the original window's opacity is restored. This logic breaks if a window is selected - the opacity need not be restored (to zero). Make it so that the opacity is set to 1 upon exit if a window is selected. BUG= 677177 Review-Url: https://codereview.chromium.org/2637403013 Cr-Commit-Position: refs/heads/master@{#445524} (cherry picked from commit 8f64e9220762c7c7d5237cb4b4222898c5b0f4dc) Review-Url: https://codereview.chromium.org/2657453003 . Cr-Commit-Position: refs/branch-heads/2987@{#47} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/e86ab7d65162a39b16e19710445f09e357c27a1e/ash/common/wm/overview/scoped_transform_overview_window.cc [modify] https://crrev.com/e86ab7d65162a39b16e19710445f09e357c27a1e/ash/common/wm/overview/scoped_transform_overview_window.h [modify] https://crrev.com/e86ab7d65162a39b16e19710445f09e357c27a1e/ash/common/wm/overview/window_selector.cc [modify] https://crrev.com/e86ab7d65162a39b16e19710445f09e357c27a1e/ash/common/wm/overview/window_selector.h [modify] https://crrev.com/e86ab7d65162a39b16e19710445f09e357c27a1e/ash/common/wm/overview/window_selector_item.cc [modify] https://crrev.com/e86ab7d65162a39b16e19710445f09e357c27a1e/ash/common/wm/overview/window_selector_item.h [modify] https://crrev.com/e86ab7d65162a39b16e19710445f09e357c27a1e/ash/wm/overview/window_selector_unittest.cc
,
Jan 24 2017
This bug requires manual review: Only 6 days from stable, we might already have a stable candidate build Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 24 2017
,
Jan 25 2017
,
Jan 25 2017
,
Jan 25 2017
This bug requires manual review: Only 5 days from stable, we might already have a stable candidate build Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba1d61d4f88c04b5440233dbf7966eaffb159413 commit ba1d61d4f88c04b5440233dbf7966eaffb159413 Author: Valery Arkhangorodsky <varkha@chromium.org> Date: Wed Jan 25 20:40:22 2017 [ash-md] Makes sure that minimized windows can be activated in overview When windows are minimized before entering overview mode, they are replaced with a widget that has mirrored layers. Opacity of the original window needs to be then set to 1 in order to make it visible (in WindowMirrorView::InitLayerOwner()). Upon exiting overview the original window's opacity is restored. This logic breaks if a window is selected - the opacity need not be restored (to zero). Make it so that the opacity is set to 1 upon exit if a window is selected. BUG= 677177 Review-Url: https://codereview.chromium.org/2637403013 Cr-Commit-Position: refs/heads/master@{#445524} (cherry picked from commit 8f64e9220762c7c7d5237cb4b4222898c5b0f4dc) Review-Url: https://codereview.chromium.org/2654153002 . Cr-Commit-Position: refs/branch-heads/2924@{#866} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/ba1d61d4f88c04b5440233dbf7966eaffb159413/ash/common/wm/overview/scoped_transform_overview_window.cc [modify] https://crrev.com/ba1d61d4f88c04b5440233dbf7966eaffb159413/ash/common/wm/overview/scoped_transform_overview_window.h [modify] https://crrev.com/ba1d61d4f88c04b5440233dbf7966eaffb159413/ash/common/wm/overview/window_selector.cc [modify] https://crrev.com/ba1d61d4f88c04b5440233dbf7966eaffb159413/ash/common/wm/overview/window_selector.h [modify] https://crrev.com/ba1d61d4f88c04b5440233dbf7966eaffb159413/ash/common/wm/overview/window_selector_item.cc [modify] https://crrev.com/ba1d61d4f88c04b5440233dbf7966eaffb159413/ash/common/wm/overview/window_selector_item.h [modify] https://crrev.com/ba1d61d4f88c04b5440233dbf7966eaffb159413/ash/wm/overview/window_selector_unittest.cc
,
Jan 25 2017
,
Feb 6 2017
Chrome 57.0.2987.30/9202.17.0 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bleung@chromium.org
, Dec 27 2016