Issue metadata
Sign in to add a comment
|
Accessibility issue on controls in Chrome OS
Reported by
willg...@gmail.com,
Dec 27 2016
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; CrOS x86_64 9126.0.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2962.0 Safari/537.36 Platform: Platform 9126.0.0 (Official Build) canary-channel edgar Steps to reproduce the problem: 1. Open new incognito window 2. Switch to regular window What is the expected behavior? Incognito uses proper color for out of focus What went wrong? See attached screenshot: Did this work before? Yes 57.0.2951.0 Chrome version: 57.0.2962.0 Channel: canary OS Version: 9126.0.0 Flash Version: Looks almost like Chrome's in focus color for a regular window.
,
Jan 4 2017
Hi, Thank you for reporting this, but could you please describe the problem more. I cannot see what is wrong in your screenshot.
,
Jan 4 2017
Alex once referred me to sgabriel, bettes and rpop to discuss incognito color schemes. estade knew something about linux themes.
,
Jan 4 2017
may be due to one of my own or Bret's recent changes, will take a look.
,
Jan 4 2017
Yes, that's the new expected color. See the discussion in bug 645682 .
,
Jan 4 2017
That does seem like a problem. Should we re-purpose this bug for that? According to frame_caption_button.cc the buttons are #5A grey and when inactive are drawn with 20% opacity. The #5A seems standard across cros icons, so I'm not sure what should be changed.
,
Jan 4 2017
Sure. Re-opening. Yes but they are supposed to change to white when contrast is not reached. If you apply #5a everywhere, then they also become invisible on dark theme (see attached). So granted you keep this coloring paradigm on Chrome OS, controls need to turn #5a on incognito inactive and turn the proper color on themes as well, #fff or #5a depending on contrast ratio with the frame.
,
Jan 5 2017
,
Feb 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af5bd1316ab3fd3054d08471c0a25b4b7c66cf9c commit af5bd1316ab3fd3054d08471c0a25b4b7c66cf9c Author: bsep <bsep@chromium.org> Date: Tue Feb 07 22:40:42 2017 Revert incognito and theme inactive color changes. Partial revert of crrev.com/2541873004. We're not happy with the colors and we don't want to ship them in 57. But we're keeping the default non-incognito/inactive color change to #F5F5F5 because it dramatically increases contrast with the active frame. BUG= 645682 , 677172 Review-Url: https://codereview.chromium.org/2663363002 Cr-Commit-Position: refs/heads/master@{#448752} [modify] https://crrev.com/af5bd1316ab3fd3054d08471c0a25b4b7c66cf9c/chrome/browser/themes/browser_theme_pack.cc [modify] https://crrev.com/af5bd1316ab3fd3054d08471c0a25b4b7c66cf9c/chrome/browser/themes/theme_properties.cc
,
Feb 7 2017
Fixed via reversion. When we redo the colors again I will make sure the CrOS window controls always have the correct contrast.
,
Feb 7 2017
,
Feb 8 2017
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 8 2017
To manual reviewer: the fix is itself a reversion. It's fine to merge.
,
Feb 21 2017
Approving merge to M57 Chrome OS.
,
Feb 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d542e5990f46859423784528739ea9b5e406b3c8 commit d542e5990f46859423784528739ea9b5e406b3c8 Author: Bret Sepulveda <bsep@chromium.org> Date: Tue Feb 21 23:54:35 2017 Revert incognito and theme inactive color changes. Partial revert of crrev.com/2541873004. We're not happy with the colors and we don't want to ship them in 57. But we're keeping the default non-incognito/inactive color change to #F5F5F5 because it dramatically increases contrast with the active frame. TBR=estade@chromium.org BUG= 645682 , 677172 Review-Url: https://codereview.chromium.org/2663363002 Cr-Commit-Position: refs/heads/master@{#448752} (cherry picked from commit af5bd1316ab3fd3054d08471c0a25b4b7c66cf9c) Review-Url: https://codereview.chromium.org/2712583002 . Cr-Commit-Position: refs/branch-heads/2987@{#630} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/d542e5990f46859423784528739ea9b5e406b3c8/chrome/browser/themes/browser_theme_pack.cc [modify] https://crrev.com/d542e5990f46859423784528739ea9b5e406b3c8/chrome/browser/themes/theme_properties.cc
,
Mar 29 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mmenke@chromium.org
, Dec 28 2016