New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 677171 link

Starred by 1 user
Status: Duplicate
Merged: issue 634944
Owner:
aga...@chromium.org
Closed: Jan 2017
Cc:
tandrii@chromium.org
rmis...@chromium.org
█ andyb...@chromium.org
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Buildbucket plugin did not reuse builds from patchset with real change

Project Member Reported by brianosman@google.com, Dec 27 2016 
UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36

Steps to reproduce the problem:
Originally reported via email to Skia Infra:

I made a CL (https://skia-review.googlesource.com/c/6467). I accidentally gave it a CR +1 and CQ +2, which I didn't want to do. I cancelled the CQ, so I could instead observe the results of a Dry Run. However, at this point I can't actually get it to trigger a full dry run. Even after removing my own CR +1, and editing the description to force creation of a new PS, every time I +1 CQ, it just runs Skia Presubmit, but none of the other standard bots.

What is the expected behavior?

What went wrong?
See above.

Did this work before? N/A 

Chrome version: 55.0.2883.87  Channel: stable
OS Version: 10.0
Flash Version: Shockwave Flash 24.0 r0

Comment 1 by brianosman@chromium.org, Dec 27 2016

Owner: rmis...@chromium.org

Comment 2 by schenney@chromium.org, Dec 27 2016

Components: Infra>Codereview>Gerrit

Comment 3 by rmis...@google.com, Dec 27 2016

Cc: aga...@chromium.org andyb...@chromium.org rmis...@chromium.org tandrii@chromium.org
Owner: ----
Summary: Buildbucket plugin did not reuse builds from patchset with real change (was: Buildbucket / CQ Abbreviated after +1 from Self)
Looks like a bug in the buildbucket plugin. Since the difference between patchset 1 and patchset 3 is just a description change, patchset 3 should have inherited the builds from the previous patchset. Looks like the presubmit run in patchset 2 and patchset3 confused the plugin.

Comment 4 by andyb...@chromium.org, Dec 28 2016

Cc: -aga...@chromium.org
Labels: -Arch-x86_64 -Via-Wizard-Other Milestone-Dogfood Proj-Gerrit-Migration
Owner: aga...@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 5 by aga...@chromium.org, Jan 4 2017

Mergedinto: 634944
Status: Duplicate (was: Assigned)
Yes, it is re-using the builds for the prior patchset (because the code didn't change from the prior patchset) but the plugin doesn't yet display results from prior patchsets. That code has been written, and is just awaiting a deployment from the Gerrit folks.

Comment 6 by aga...@chromium.org, Jan 5 2017 

I now see all the tryjobs from PS1 displayed on PS2 and the subsequent patchsets.
►

Sign in to add a comment