New issue
Advanced search Search tips

Issue 677162 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Add autotest for ImageLoader, to test functionalities on all platforms

Project Member Reported by kerrnel@chromium.org, Dec 27 2016

Issue description

ImageLoader crashes with seccomp violations on 32-bit x86 due to differences in how the socket() syscalls are implemented on 32 and 64 bit. The seccomp filter needs to be updated to allow socketcall() and a few other 32-bit system calls.

The ultimate fix to this problem is to deploy an autotest for ImageLoader so that we can track how it behaves under all of our kernel versions and architectures.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/imageloader/+/c62685e1562001f93d89f85154e52f1a9d458670

commit c62685e1562001f93d89f85154e52f1a9d458670
Author: Greg Kerr <kerrnel@chromium.org>
Date: Thu Jan 05 21:27:39 2017

Fix crash on old version cleanup on 32 bit.

This fixes a crash in the cleanup of old component versions due to a
missing syscall in the seccomp filter.

BUG= chromium:677162 
TEST=emerge-${BOARD} imageloader and run platform_ImageLoader autotest

Change-Id: Ibafd946f6a5c9b599b91053602b09d66e040ef6a
Reviewed-on: https://chromium-review.googlesource.com/425196
Commit-Ready: Greg Kerr <kerrnel@chromium.org>
Tested-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/c62685e1562001f93d89f85154e52f1a9d458670/imageloader-seccomp-x86.policy

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/976b1ad72aee5e071cab5763d2f095ec7350eafb

commit 976b1ad72aee5e071cab5763d2f095ec7350eafb
Author: Greg Kerr <kerrnel@chromium.org>
Date: Thu Jan 05 00:11:17 2017

Add autotest for ImageLoader.

This adds an autotest for ImageLoader. The autotest runs ImageLoader in
the actual runtime environment, as a dbus environment, with the
sandboxing technologies enabled.

BUG= chromium:677162 
CQ-DEPEND=CL:425707
TEST=test_that -b ${BOARD} DUT platform_ImageLoader

Change-Id: I19e877c62853b411fe267434888e25c9e9296b2e
Reviewed-on: https://chromium-review.googlesource.com/425088
Tested-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[add] https://crrev.com/976b1ad72aee5e071cab5763d2f095ec7350eafb/client/site_tests/platform_ImageLoader/control
[add] https://crrev.com/976b1ad72aee5e071cab5763d2f095ec7350eafb/server/site_tests/platform_ImageLoaderServer/platform_ImageLoaderServer.py
[add] https://crrev.com/976b1ad72aee5e071cab5763d2f095ec7350eafb/client/site_tests/platform_ImageLoader/platform_ImageLoader.py
[modify] https://crrev.com/976b1ad72aee5e071cab5763d2f095ec7350eafb/client/common_lib/cros/dbus_send.py
[add] https://crrev.com/976b1ad72aee5e071cab5763d2f095ec7350eafb/server/site_tests/platform_ImageLoaderServer/control

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5b8de1a3110673a7af8efdf0744b686b2ead656a

commit 5b8de1a3110673a7af8efdf0744b686b2ead656a
Author: Greg Kerr <kerrnel@chromium.org>
Date: Thu Jan 12 20:00:05 2017

Increase timeout for platform_ImageLoader test.

platform_ImageLoader is failing to receiving a dbus-send result on some
boards. This increases the timeout to a very large value (20 seconds) to
see if those boards pass the test.

BUG= chromium:677162 
TEST=test_that -b ${BOARD} DUT_ip platform_ImageLoaderServer

Change-Id: Ibf1ac47b4fe8bddebc14067266e728c55adfffc2
Reviewed-on: https://chromium-review.googlesource.com/427345
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/5b8de1a3110673a7af8efdf0744b686b2ead656a/client/site_tests/platform_ImageLoader/platform_ImageLoader.py

Summary: Add autotest for ImageLoader, to test functionalities on all platforms (was: ImageLoader crashes with seccomp violations on 32-bit x86)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/aa326e3cc363552ced2bc98dca74945c67b8da74

commit aa326e3cc363552ced2bc98dca74945c67b8da74
Author: Greg Kerr <kerrnel@chromium.org>
Date: Mon Jan 16 02:49:34 2017

Test corrupt components.

Now that the basic autotest is running successfully, this adds cases
where the component is corrupt. These test cases are critical to
ensuring that ImageLoader is reliable as a security mechanism.

BUG= chromium:677162 
TEST=test_that -b ${BOARD} DUT_ip platform_ImageLoaderServer

Change-Id: If738be17600bdcf58342e236a08efd6152eb4775
Reviewed-on: https://chromium-review.googlesource.com/428439
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>
Trybot-Ready: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/aa326e3cc363552ced2bc98dca74945c67b8da74/client/site_tests/platform_ImageLoader/platform_ImageLoader.py

Status: Fixed (was: Started)

Sign in to add a comment