New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 677142 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug
Team-Security-UX



Sign in to add a comment

Security indicators: separator has incorrect dimensions and color on macOS

Project Member Reported by maxwalker@chromium.org, Dec 27 2016

Issue description

On macOS, the separator is slightly too big (is 2px X 20pt, should be 1px X 16pt) and the color is slightly off (too light in default theme, too dark in incognito).

Spec:
https://folio.googleplex.com/omnibox-spec/Non-Touch/Spec#%2FNon-Touch-Chip-EV-200.png

Spec Incognito:
https://folio.googleplex.com/omnibox-spec/Non-Touch/Spec#%2FNon-Touch-Chip-Incognito.png
 
macOS 1x.png
31.1 KB View Download
macOS 2x.png
68.2 KB View Download
Owner: shrike@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by shrike@chromium.org, Jan 17 2017

Cc: shrike@chromium.org
Owner: spqc...@chromium.org
Labels: M-60
Owner: shrike@chromium.org
Status: Started (was: Assigned)
Non-Retina.
Screen Shot 2017-05-05 at 12.10.47 PM.png
6.2 KB View Download
Screen Shot 2017-05-05 at 12.10.58 PM.png
6.8 KB View Download
Retina.
Screen Shot 2017-05-05 at 12.18.29 PM.png
12.7 KB View Download
Screen Shot 2017-05-05 at 12.18.46 PM.png
14.8 KB View Download
Project Member

Comment 6 by bugdroid1@chromium.org, May 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c56faf1fbb17173715d43a6d975933f8dac4f1a9

commit c56faf1fbb17173715d43a6d975933f8dac4f1a9
Author: shrike <shrike@chromium.org>
Date: Fri May 05 19:57:24 2017

[Mac] Adjust the size, position and color of security indicator divider.

The divider's height, position, and color were all slightly off-spec.

R=avi@chromium.org
BUG= 677142 

Review-Url: https://codereview.chromium.org/2861653004
Cr-Commit-Position: refs/heads/master@{#469761}

[modify] https://crrev.com/c56faf1fbb17173715d43a6d975933f8dac4f1a9/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
[modify] https://crrev.com/c56faf1fbb17173715d43a6d975933f8dac4f1a9/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm

Status: Fixed (was: Started)

Comment 8 by hdodda@chromium.org, May 11 2017

Cc: hdodda@chromium.org
Labels: Needs-Feedback
Tested the issue on Mac os 10.12.3 using chrome M60 #60.0.3095.5 and observed the security seperator and fonts size as attached in screenshot.

@ could someone look into the screenshot and confirm us if this is the expected result and we can add TE-Verified labels.

Thanks!
677142.png
30.1 KB View Download

Sign in to add a comment