New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 677106 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Undefined-shift in webrtc::Expand::AnalyzeSignal

Project Member Reported by ClusterFuzz, Dec 27 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6529198941536256

Fuzzer: libfuzzer_neteq_rtp_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Undefined-shift
Crash Address: 
Crash State:
  webrtc::Expand::AnalyzeSignal
  webrtc::Expand::Process
  webrtc::NetEqImpl::DoExpand
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=438480:438523

Minimized Testcase (2.79 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96LHmSVloEiDqN8hOT_BF_ZRvSv40Q3JlO9A13Nkakj3JTTn_p8gc7pl9gk_OOyMkzYrobL1lKQ4m321aBxe82nA3Wufg2-Qk12hII9-XTxtqRQIRm7Usey-AKV1otnsC1UiKLPc9a2GGpIcXEfc09IF3tLog?testcase_id=6529198941536256

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Components: Blink>WebRTC
Labels: Test-Predator-Wrong M-57
Components: -Blink>WebRTC Internals>WebRTC
Cc: tlegrand@chromium.org hlundin@chromium.org
Components: -Internals>WebRTC Blink>WebRTC>Audio
Labels: -OS-Linux -M-57 OS-All
Owner: ivoc@chromium.org
Status: Assigned (was: Untriaged)
Ivo, please, take a look at this.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/4843dd13aa3426d9a3caee768fc015d8731c5d18

commit 4843dd13aa3426d9a3caee768fc015d8731c5d18
Author: ivoc <ivoc@webrtc.org>
Date: Mon Jan 09 16:31:42 2017

Fix for left-shift of potentially negative values in NetEq.

Left shifting negative integers is undefined behavior, and should be prevented. This CL fixes one such instance in the NetEq Expand function.

BUG= chromium:677106 

Review-Url: https://codereview.webrtc.org/2616363003
Cr-Commit-Position: refs/heads/master@{#15966}

[modify] https://crrev.com/4843dd13aa3426d9a3caee768fc015d8731c5d18/webrtc/modules/audio_coding/neteq/expand.cc

Project Member

Comment 5 by ClusterFuzz, Jan 13 2017

ClusterFuzz has detected this issue as fixed in range 443187:443210.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6529198941536256

Fuzzer: libfuzzer_neteq_rtp_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Undefined-shift
Crash Address: 
Crash State:
  webrtc::Expand::AnalyzeSignal
  webrtc::Expand::Process
  webrtc::NetEqImpl::DoExpand
  
Sanitizer: undefined (UBSAN)

Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=438480:438523
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=443187:443210

Minimized Testcase (2.79 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96LHmSVloEiDqN8hOT_BF_ZRvSv40Q3JlO9A13Nkakj3JTTn_p8gc7pl9gk_OOyMkzYrobL1lKQ4m321aBxe82nA3Wufg2-Qk12hII9-XTxtqRQIRm7Usey-AKV1otnsC1UiKLPc9a2GGpIcXEfc09IF3tLog?testcase_id=6529198941536256

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Labels: M-57
Project Member

Comment 7 by ClusterFuzz, Jan 13 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6529198941536256 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment