New issue
Advanced search Search tips

Issue 677093 link

Starred by 3 users
Status: Fixed
Owner:
kojii@chromium.org
Closed: Jan 2017
Cc:
drott@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 649700



Sign in to add a comment

Han ideographic characters should not skip ink

Project Member Reported by kojii@chromium.org, Dec 27 2016 
Because Han ideograph characters tends to use all pixels in full em-box, skipping may disappear the whole underlines.

Also, skipping ink tends to look cheaper typography when applied to CJK characters.

Skipping ink for non-ideograph characters within CJK context is fine and is an improvements.

Related WebKit bug: http://wkb.ug/128145
CSS WG: https://github.com/w3c/csswg-drafts/issues/707
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8584def66acd7836e089a59a598f9f44e50ace7b

commit 8584def66acd7836e089a59a598f9f44e50ace7b
Author: kojii <kojii@chromium.org>
Date: Thu Jan 05 06:00:16 2017

Do not skip ink for ideographic scripts

This patch changes not to skip ink for ideographic scripts, where
skipping ink is inappropriate.

In order to know when not to apply ink skipping, this patch adds an
optional vector to GlyphBuffer containing the glyph indexes that are
exempt from ink skipping.

BUG= 677093 

Review-Url: https://codereview.chromium.org/2598393002
Cr-Commit-Position: refs/heads/master@{#441593}

[add] https://crrev.com/8584def66acd7836e089a59a598f9f44e50ace7b/third_party/WebKit/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip-ink-ideograph-expected.html
[add] https://crrev.com/8584def66acd7836e089a59a598f9f44e50ace7b/third_party/WebKit/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip-ink-ideograph.html
[modify] https://crrev.com/8584def66acd7836e089a59a598f9f44e50ace7b/third_party/WebKit/Source/platform/fonts/Font.cpp
[modify] https://crrev.com/8584def66acd7836e089a59a598f9f44e50ace7b/third_party/WebKit/Source/platform/fonts/GlyphBuffer.h
[modify] https://crrev.com/8584def66acd7836e089a59a598f9f44e50ace7b/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.cpp
[modify] https://crrev.com/8584def66acd7836e089a59a598f9f44e50ace7b/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.h
[modify] https://crrev.com/8584def66acd7836e089a59a598f9f44e50ace7b/third_party/WebKit/Source/platform/text/TextRun.h

Comment 2 by kojii@chromium.org, Jan 5 2017

Status: Fixed (was: Available)
►

Sign in to add a comment