Use HTTPS with Prepopulated AOL Search Option
Reported by
13hu...@gmail.com,
Dec 26 2016
|
|||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36 Steps to reproduce the problem: 1. In chrome://settings/searchEngines , set the prepopulated AOL search engine option as the default. 2. Enter a search in the address bar. What is the expected behavior? The AOL search domain supports HTTPS with TLS 1.2. The prepopulated engine definition for AOL should hardcode https within the AOL search URLs, as is the case with the existing Bing and Yahoo engine definitions. What went wrong? Search is sent to AOL over plaintext HTTP. Did this work before? No Chrome version: 55.0.2883.87 Channel: stable OS Version: 4.4.0-53 Flash Version: Shockwave Flash 23.0 r0 Find patched src/master/components/search_engines/prepopulated_engines.json attached. Had to change the suggest_url domain from autocomplete.search.aol.com to autosuggest.search.aol.com to properly support HTTPS.
,
Dec 28 2016
considering as feature request and marking it as Untriaged to get it addressed. Thanks..
,
Jan 4 2017
We don't normally do this until we either have a specific request from the engine (in this case, from AOL), or the site default changes to HTTPS. In this case, https://www.aol.com actively redirects to HTTP, and search.aol.com doesn't actively redirect to HTTPS. That said, we do have open dialog with AOL about increasing their use of HTTPS generally, and I know they plan to make improvements this year. Calling this WontFix for now, but happy to fix once AOL is officially OK with it.
,
Sep 11 2017
The search URLs were updated in https://chromium.googlesource.com/chromium/src.git/+/6e67d600e764d643cc215c38f465ecf6b89e9406 , but the suggest_url could still be changed to "https://autosuggest.search.aol.com"
,
Sep 12 2017
Yep
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/736875021f3b839c845c25ceceee3bc9e36c3e65 commit 736875021f3b839c845c25ceceee3bc9e36c3e65 Author: Peter Kasting <pkasting@chromium.org> Date: Wed Sep 13 18:18:08 2017 Switch AOL suggest URL to HTTPS. Bug: 677028 Change-Id: Ia09f45887ab155dfdb5209056639637ff333d915 Reviewed-on: https://chromium-review.googlesource.com/663783 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#501695} [modify] https://crrev.com/736875021f3b839c845c25ceceee3bc9e36c3e65/components/search_engines/prepopulated_engines.json
,
Sep 13 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by schenney@chromium.org
, Dec 27 2016