Users may have multiple camera devices. We should let them switch them easily rather than ask to go through Chrome settings.
The following revision refers to this bug: https://chromium.googlesource.com/apps/camera/+/771cb06bad0ae04c3253e12a94dc6693220f6f31 commit 771cb06bad0ae04c3253e12a94dc6693220f6f31 Author: Tomasz Mikolajewski <mtomasz@chromium.org> Date: Mon Dec 26 08:37:14 2016 Add support for multiple cameras. 1. Always reopen on the previously opened device. 2. Remember mirroring per device. The button for switching cameras will come separately. TEST=Tested manually with two USB cameras. BUG= chromium:677005 Change-Id: I8594148bcd08df760946e730ddab64f0d6e34873 Reviewed-on: https://chromium-review.googlesource.com/422796 Reviewed-by: Daichi Hirono <hirono@chromium.org> Tested-by: Tomasz Mikolajewski <mtomasz@chromium.org> [modify] https://crrev.com/771cb06bad0ae04c3253e12a94dc6693220f6f31/src/js/views/camera.js [modify] https://crrev.com/771cb06bad0ae04c3253e12a94dc6693220f6f31/src/js/main.js
The following revision refers to this bug: https://chromium.googlesource.com/apps/camera/+/a124dd66e0e6017590e25513673a6f7e5dfa26fd commit a124dd66e0e6017590e25513673a6f7e5dfa26fd Author: Tomasz Mikolajewski <mtomasz@chromium.org> Date: Thu Jan 05 02:05:06 2017 Add button for toggling multiple cameras. TEST=Tested manually with zero, one and two and three USB cameras. BUG= chromium:677005 Change-Id: I1c1a13584fd2682dca312a94c1420b7d0e36179b Reviewed-on: https://chromium-review.googlesource.com/425232 Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org> Tested-by: Tomasz Mikolajewski <mtomasz@chromium.org> [modify] https://crrev.com/a124dd66e0e6017590e25513673a6f7e5dfa26fd/src/manifest-tests.json [modify] https://crrev.com/a124dd66e0e6017590e25513673a6f7e5dfa26fd/src/manifest.json [modify] https://crrev.com/a124dd66e0e6017590e25513673a6f7e5dfa26fd/Makefile [add] https://crrev.com/a124dd66e0e6017590e25513673a6f7e5dfa26fd/src/images/camera_button_toggle.png [modify] https://crrev.com/a124dd66e0e6017590e25513673a6f7e5dfa26fd/src/views/main.html [modify] https://crrev.com/a124dd66e0e6017590e25513673a6f7e5dfa26fd/src/js/views/camera.js [modify] https://crrev.com/a124dd66e0e6017590e25513673a6f7e5dfa26fd/src/_locales/en/messages.json [modify] https://crrev.com/a124dd66e0e6017590e25513673a6f7e5dfa26fd/src/css/main.css [add] https://crrev.com/a124dd66e0e6017590e25513673a6f7e5dfa26fd/src/images/2x/camera_button_toggle.png
Thanks tomasz. I just tested the commits on my Electro device and user may easily switch between front and rear in the native Chrome camera app.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/771cb06bad0ae04c3253e12a94dc6693220f6f31 commit 771cb06bad0ae04c3253e12a94dc6693220f6f31 Author: Tomasz Mikolajewski <mtomasz@chromium.org> Date: Thu Jan 05 00:08:26 2017 Add support for multiple cameras. 1. Always reopen on the previously opened device. 2. Remember mirroring per device. The button for switching cameras will come separately. TEST=Tested manually with two USB cameras. BUG= chromium:677005 Change-Id: I8594148bcd08df760946e730ddab64f0d6e34873 Reviewed-on: https://chromium-review.googlesource.com/422796 Reviewed-by: Daichi Hirono <hirono@chromium.org> Tested-by: Tomasz Mikolajewski <mtomasz@chromium.org> [modify] https://crrev.com/771cb06bad0ae04c3253e12a94dc6693220f6f31/src/js/main.js [modify] https://crrev.com/771cb06bad0ae04c3253e12a94dc6693220f6f31/src/js/views/camera.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a124dd66e0e6017590e25513673a6f7e5dfa26fd commit a124dd66e0e6017590e25513673a6f7e5dfa26fd Author: Tomasz Mikolajewski <mtomasz@chromium.org> Date: Thu Jan 05 08:24:07 2017 Add button for toggling multiple cameras. TEST=Tested manually with zero, one and two and three USB cameras. BUG= chromium:677005 Change-Id: I1c1a13584fd2682dca312a94c1420b7d0e36179b Reviewed-on: https://chromium-review.googlesource.com/425232 Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org> Tested-by: Tomasz Mikolajewski <mtomasz@chromium.org> [modify] https://crrev.com/a124dd66e0e6017590e25513673a6f7e5dfa26fd/Makefile [modify] https://crrev.com/a124dd66e0e6017590e25513673a6f7e5dfa26fd/src/_locales/en/messages.json [modify] https://crrev.com/a124dd66e0e6017590e25513673a6f7e5dfa26fd/src/css/main.css [add] https://crrev.com/a124dd66e0e6017590e25513673a6f7e5dfa26fd/src/images/2x/camera_button_toggle.png [add] https://crrev.com/a124dd66e0e6017590e25513673a6f7e5dfa26fd/src/images/camera_button_toggle.png [modify] https://crrev.com/a124dd66e0e6017590e25513673a6f7e5dfa26fd/src/js/views/camera.js [modify] https://crrev.com/a124dd66e0e6017590e25513673a6f7e5dfa26fd/src/manifest-tests.json [modify] https://crrev.com/a124dd66e0e6017590e25513673a6f7e5dfa26fd/src/manifest.json [modify] https://crrev.com/a124dd66e0e6017590e25513673a6f7e5dfa26fd/src/views/main.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31d3598980408bb63150b4c44c053b1ee2ca2525 commit 31d3598980408bb63150b4c44c053b1ee2ca2525 Author: Tomasz Mikolajewski <mtomasz@chromium.org> Date: Thu Jan 05 00:08:26 2017 Add support for multiple cameras. 1. Always reopen on the previously opened device. 2. Remember mirroring per device. The button for switching cameras will come separately. TEST=Tested manually with two USB cameras. BUG= chromium:677005 Change-Id: I8594148bcd08df760946e730ddab64f0d6e34873 Reviewed-on: https://chromium-review.googlesource.com/422796 Reviewed-by: Daichi Hirono <hirono@chromium.org> Tested-by: Tomasz Mikolajewski <mtomasz@chromium.org>
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/80476e2207d5ea445fbefc1242660c9e78b2620a commit 80476e2207d5ea445fbefc1242660c9e78b2620a Author: Tomasz Mikolajewski <mtomasz@chromium.org> Date: Thu Jan 05 08:24:07 2017 Add button for toggling multiple cameras. TEST=Tested manually with zero, one and two and three USB cameras. BUG= chromium:677005 Change-Id: I1c1a13584fd2682dca312a94c1420b7d0e36179b Reviewed-on: https://chromium-review.googlesource.com/425232 Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org> Tested-by: Tomasz Mikolajewski <mtomasz@chromium.org>
Comment 1 by mtomasz@chromium.org
, Dec 26 2016